Closed
Bug 931459
Opened 12 years ago
Closed 12 years ago
Move LOCAL_INCLUDES to moz.build in dom/
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla28
People
(Reporter: Ms2ger, Assigned: Ms2ger)
References
(Blocks 1 open bug)
Details
(Whiteboard: [qa-])
Attachments
(1 file)
|
33.88 KB,
patch
|
mshal
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #823035 -
Flags: review?(mshal)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 823035 [details] [diff] [review]
Patch v1
Everything looks good to me, but I definitely recommend a try run. Alphabetizing the include list always makes me worry that we'll be changing which headers get picked up. As a side note, the size of LOCAL_INCLUDES in dom/bindings is frightening :)
Attachment #823035 -
Flags: review?(mshal) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
|
|
||
Updated•11 years ago
|
Whiteboard: [qa-]
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•