Closed Bug 931915 Opened 6 years ago Closed 6 years ago

Add an AppendRoundedRectToPath helper to Moz2D, then make gfxContext::RoundedRectangle use it

Categories

(Core :: Graphics, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla28

People

(Reporter: jwatt, Assigned: jwatt)

References

(Blocks 1 open bug)

Details

(Whiteboard: [qa-])

Attachments

(2 files)

This code is cribbed from gfxContext::RoundedRectangle, but hacked up a fair bit to get rid of the dependencies on Mozilla code that Moz2D doesn't want to have.
Attached patch patchSplinter Review
Attachment #823449 - Flags: review?(bas)
Blocks: 931996
Summary: Add an AppendRoundedRectToPath helper to Moz2D → Add an AppendRoundedRectToPath helper to Moz2D, then make gfxContext::RoundedRectangle use it
Attachment #823670 - Flags: review? → review?(bas)
Bas, any idea why WinXP is failing to link this?

https://tbpl.mozilla.org/php/getParsedLog.php?id=29825670&tree=Try&full=1#error0
I tried changing the aCornerRadii type to |const Size*|, but that doesn't help. Still getting:

gfxContext.obj : error LNK2019: unresolved external symbol "void __cdecl mozilla::gfx::AppendRoundedRectToPath(class mozilla::gfx::PathBuilder *,struct mozilla::gfx::RectTyped<struct mozilla::gfx::UnknownUnits> const &,struct mozilla::gfx::SizeTyped<struct mozilla::gfx::UnknownUnits> const *,bool)" (?AppendRoundedRectToPath@gfx@mozilla@@YAXPAVPathBuilder@12@ABU?$RectTyped@UUnknownUnits@gfx@mozilla@@@12@PBU?$SizeTyped@UUnknownUnits@gfx@mozilla@@@12@_N@Z) referenced in function "public: void __thiscall gfxContext::RoundedRectangle(struct gfxRect const &,struct gfxCornerSizes const &,bool)" (?RoundedRectangle@gfxContext@@QAEXABUgfxRect@@ABUgfxCornerSizes@@_N@Z)

http://pear.warosu.org/c++filtjs/ says that the missing symbol demangles to:

void __cdecl mozilla::gfx::AppendRoundedRectToPath(class mozilla::gfx::PathBuilder *,struct mozilla::gfx::RectTyped const &,struct mozilla::gfx::SizeTyped const *,bool)

when it should be:

void __cdecl mozilla::gfx::AppendRoundedRectToPath(class mozilla::gfx::PathBuilder *,struct mozilla::gfx::RectTyped<struct mozilla::gfx::UnknownUnits> const &,struct mozilla::gfx::SizeTyped<struct mozilla::gfx::UnknownUnits> const *,bool)

Bas, any idea what's happening to the "<struct mozilla::gfx::UnknownUnits>" part that's missing off the second and third args on XP?
Blocks: 703159
Attachment #823449 - Flags: review?(bas) → review+
Attachment #823670 - Flags: review?(bas) → review+
Gah, the Try push showed it failing to link on the reference from content in a future patch that builds on this, not on the reference from inside its own library! XP sucks.

Thanks, Ed.
Blocks: 932761
https://hg.mozilla.org/mozilla-central/rev/f9b22be50b69
https://hg.mozilla.org/mozilla-central/rev/425e452372a2
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.