932729 - [DSDS][Gaia][Sim Manager] add rename functions for simcards

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

As title, add rename buttons' functions.

Comment 1

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

IN this

Comment 2

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

In this bug, we can rename existing sim cards.

Comment 3

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

In latest UX spec (v0.5), there is no rename functionality anymore. 

In this way, I will close this bug directly.

Comment 4

[Noemí Freire (:noemi)]

Hi,

This feature is out of v1.3 scope but will be covered in future releases so reopening this bug and nominating to 1.4?

Comment 6

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Hi Hsin-Yi,

is there any plan running on Gecko side for this feature :) ?

Comment 7

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to EJ Chen [:eragonj] from comment #6)
> Hi Hsin-Yi,
> 
> is there any plan running on Gecko side for this feature :) ?

Hi EJ,

I believe no gecko work is required for this issue. Please see https://bugzilla.mozilla.org/show_bug.cgi?id=949707#c7 Thank you!

Comment 8

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Yeah ok, 

I will maintain a object in mozSettings to maintain a key-value pair with iccId as its key and name as its value.

Thanks all.

Comment 9

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Attachment: patch on github

Hi Arthur, 

I just implemented this rename function and will add more tests later. 

Please help me review this when you have time, thanks :)

Comment 10

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Hi Joe, 

just asked Carrie about this and it seems that recently there is no schedule for this bug in v1.4.

Can you update with us about this feature to let us know whether it is in v1.4 scope or not ? 

Thanks :)

Comment 11

[Joe Cheng [:jcheng] (please needinfo)]

It is currently not in v1.4
We may add this to the backlog for later releases

Comment 12

[Francisco Jordano [:arcturus] [:francisco]]

+10000, IMHO, having this feature is necessary to disambiguate the use of the sims in the rest of the apps like contacts, cost control, etc.

Comment 13

[Francisco Jordano [:arcturus] [:francisco]]

my previous comment was about to add this to 1.4 :P

Comment 14

[Noemí Freire (:noemi)]

(In reply to Joe Cheng [:jcheng] from comment #11)
> It is currently not in v1.4
> We may add this to the backlog for later releases

This issue needs to be fixed in v1.4 in order to avoid annoying effects, please see Bug 949707, notice that if this bug is not fixed, it will impact on dsds correct behavior (import/export, long tap scenarios…). The "tag" associated to each SIM card needs to be unique and be linked to an specific icc (identify unambiguously each SIM card), a label for each icc is needed.

Comment 15

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8349935 [details] [review]
patch on github

Clear the review request as we haven't decided whether we are going to have this feature in v1.4.

Comment 16

[Wilfred Mathanaraj [:WDM]]

For now we want to keep SIM1 and SIM2 as the names - there has been some discussion in the meeting if we do really need the rename function for an end user to rename the SIM cards.

Though its seen as a nice feature to have, its resulting in more complicated design in other areas of the DSDS implementation.

This is to be discussed again in a meeting and moved forward accordingly. NI still on me till then.

Comment 17

[Noemí Freire (:noemi)]

(In reply to Wilfred Mathanaraj [:WDM] from comment #16)
> For now we want to keep SIM1 and SIM2 as the names - there has been some
> discussion in the meeting if we do really need the rename function for an
> end user to rename the SIM cards.
> 
> Though its seen as a nice feature to have, its resulting in more complicated
> design in other areas of the DSDS implementation.
> 
> This is to be discussed again in a meeting and moved forward accordingly. NI
> still on me till then.

Hi,

Please refer to https://bugzilla.mozilla.org/show_bug.cgi?id=932729#c14, beyond including rename function we need to assure that The "tag" associated to each SIM card needs to be unique and be linked to an specific icc (identify unambiguously each SIM card), a label for each icc is needed or we will see bad effects such as the ones gathered in Bug 949707. Notice that in Bug 944572 the approach followed was SIM1=slot0 and SIM2=slot1 but if user swaps the SIMs the info shown, i.e in contacts window, will be wrong.

Comment 18

[Ken Chang[:kenkai]]

It isn't a RIL feature now.

Comment 19

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Untake this first because i have to track the other important bugs.

Comment 20

[Noemí Freire (:noemi)]

Adding to backlog to be able to track it

Comment 21

[Joe Cheng [:jcheng] (please needinfo)]

this bug does not need to block bug 947189

Comment 22

[BMO Automation]

Firefox OS is not being worked on