Closed Bug 932729 Opened 7 years ago Closed 3 years ago

[DSDS][Gaia][Sim Manager] add rename functions for simcards

Categories

(Firefox OS Graveyard :: Gaia::Settings, defect)

x86
macOS
defect
Not set
normal

Tracking

(tracking-b2g:backlog)

RESOLVED WONTFIX
tracking-b2g backlog

People

(Reporter: eragonj, Unassigned)

References

Details

Attachments

(1 file)

As title, add rename buttons' functions.
IN this
Summary: [DSDS][Gaia][Sim Manager] add rename button function → [DSDS][Gaia][Sim Manager] add rename functions for simcards
In this bug, we can rename existing sim cards.
Target Milestone: --- → 1.3 Sprint 5 - 11/22
In latest UX spec (v0.5), there is no rename functionality anymore. 

In this way, I will close this bug directly.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → INVALID
Hi,

This feature is out of v1.3 scope but will be covered in future releases so reopening this bug and nominating to 1.4?
Status: RESOLVED → REOPENED
blocking-b2g: --- → 1.4?
Resolution: INVALID → ---
Target Milestone: 1.3 Sprint 5 - 11/22 → ---
Blocks: backlog-RIL/Net/Conn
No longer blocks: 928280
Duplicate of this bug: 949707
Blocks: 947189
Hi Hsin-Yi,

is there any plan running on Gecko side for this feature :) ?
Flags: needinfo?(htsai)
(In reply to EJ Chen [:eragonj] from comment #6)
> Hi Hsin-Yi,
> 
> is there any plan running on Gecko side for this feature :) ?

Hi EJ,

I believe no gecko work is required for this issue. Please see https://bugzilla.mozilla.org/show_bug.cgi?id=949707#c7 Thank you!
Flags: needinfo?(htsai)
Yeah ok, 

I will maintain a object in mozSettings to maintain a key-value pair with iccId as its key and name as its value.

Thanks all.
Attached file patch on github
Hi Arthur, 

I just implemented this rename function and will add more tests later. 

Please help me review this when you have time, thanks :)
Attachment #8349935 - Flags: review?(arthur.chen)
Hi Joe, 

just asked Carrie about this and it seems that recently there is no schedule for this bug in v1.4.

Can you update with us about this feature to let us know whether it is in v1.4 scope or not ? 

Thanks :)
Flags: needinfo?(jcheng)
It is currently not in v1.4
We may add this to the backlog for later releases
Flags: needinfo?(jcheng) → needinfo?(wmathanaraj)
+10000, IMHO, having this feature is necessary to disambiguate the use of the sims in the rest of the apps like contacts, cost control, etc.
my previous comment was about to add this to 1.4 :P
(In reply to Joe Cheng [:jcheng] from comment #11)
> It is currently not in v1.4
> We may add this to the backlog for later releases

This issue needs to be fixed in v1.4 in order to avoid annoying effects, please see Bug 949707, notice that if this bug is not fixed, it will impact on dsds correct behavior (import/export, long tap scenarios…). The "tag" associated to each SIM card needs to be unique and be linked to an specific icc (identify unambiguously each SIM card), a label for each icc is needed.
Comment on attachment 8349935 [details] [review]
patch on github

Clear the review request as we haven't decided whether we are going to have this feature in v1.4.
Attachment #8349935 - Flags: review?(arthur.chen)
For now we want to keep SIM1 and SIM2 as the names - there has been some discussion in the meeting if we do really need the rename function for an end user to rename the SIM cards.

Though its seen as a nice feature to have, its resulting in more complicated design in other areas of the DSDS implementation.

This is to be discussed again in a meeting and moved forward accordingly. NI still on me till then.
(In reply to Wilfred Mathanaraj [:WDM] from comment #16)
> For now we want to keep SIM1 and SIM2 as the names - there has been some
> discussion in the meeting if we do really need the rename function for an
> end user to rename the SIM cards.
> 
> Though its seen as a nice feature to have, its resulting in more complicated
> design in other areas of the DSDS implementation.
> 
> This is to be discussed again in a meeting and moved forward accordingly. NI
> still on me till then.

Hi,

Please refer to https://bugzilla.mozilla.org/show_bug.cgi?id=932729#c14, beyond including rename function we need to assure that The "tag" associated to each SIM card needs to be unique and be linked to an specific icc (identify unambiguously each SIM card), a label for each icc is needed or we will see bad effects such as the ones gathered in Bug 949707. Notice that in Bug 944572 the approach followed was SIM1=slot0 and SIM2=slot1 but if user swaps the SIMs the info shown, i.e in contacts window, will be wrong.
Depends on: 945324
It isn't a RIL feature now.
No longer blocks: backlog-RIL/Net/Conn
blocking-b2g: 1.4? → ---
Flags: needinfo?(wmathanaraj)
Untake this first because i have to track the other important bugs.
Assignee: ejchen → nobody
Adding to backlog to be able to track it
blocking-b2g: --- → backlog
this bug does not need to block bug 947189
No longer blocks: 947189
blocking-b2g: backlog → ---
Firefox OS is not being worked on
Status: REOPENED → RESOLVED
Closed: 7 years ago3 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.