928280 - [DSDS][Gaia] Need Sim cards manager in settings app

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Arthur Chen [:arthurcc][inactive after 6/30]]

Users should be able to use sim cards manager in settings app to change related settings.

Comment 1

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Arthur, what's the scope of this bug ? It seems that this bug has a bigger scope than the others, in this way, can we define this one precisely ? 

(Right now, I am following UX's draft and try to making a UI.)

Maybe we can have a offline discussion about all our related bugs, what do you think :D ?

Comment 2

[Arthur Chen [:arthurcc][inactive after 6/30]]

Feel free to open sub bugs for tracking if you would like to see this one as a meta bug. Remember to set correct dependency.

Comment 3

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Based on multisim WebAPI, in bug 926302, we already defined the settings key for default service Ids, and gecko listens to their changes. Seems this bug covers DSDS2 AC2, i.e. "There should be a way to select a SIM card for each of these services: MO Voice/USSD/SS, MO Text, MO Data call," so I left a comment here.

settings keys gecko is listening to: ril.mms.defaultServiceId, ril.sms.defaultServiceId, ril.voicemail.defaultServiceId and ril.telephony.defaultServiceId

Comment 4

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Triage: +'ing coz it's a 1.3 feature.

EJ, please work with Arthur to come up with a engineering plan and maybe convert this bug to meta bug.

Comment 5

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

(In reply to Tim Guan-tin Chien [:timdream] (MoCo-TPE) (please ni?) from comment #4)
> Triage: +'ing coz it's a 1.3 feature.
> 
> EJ, please work with Arthur to come up with a engineering plan and maybe
> convert this bug to meta bug.

Ok, I will create some bugs depend on this, thanks Tim.

Comment 6

[Arthur Chen [:arthurcc][inactive after 6/30]]

EJ, could you set the target milestones for them? Thanks.

Comment 7

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

(In reply to Hsin-Yi Tsai  [:hsinyi] from comment #3)
> Based on multisim WebAPI, in bug 926302, we already defined the settings key
> for default service Ids, and gecko listens to their changes. Seems this bug
> covers DSDS2 AC2, i.e. "There should be a way to select a SIM card for each
> of these services: MO Voice/USSD/SS, MO Text, MO Data call," so I left a
> comment here.
> 
> settings keys gecko is listening to: ril.mms.defaultServiceId,
> ril.sms.defaultServiceId, ril.voicemail.defaultServiceId and
> ril.telephony.defaultServiceId

Hsin-Yi, may I ask a question ?

In DSDS SIM manager, we have "outgoing call", "outgoing messages" and "outgoing data". According to your comment, it seems that
"outgoing call" maps to "ril.telephony.defaultServiceId" and "ril.voicemail.defaultServiceId",
"outgoing messages" maps to "ril.mms.defaultServiceId" and "ril.sms.defaultServiceId". 

But how about "outgoing data" ? which key should I set ? 

If I misunderstood anything, please let me know.

Big thanks :)

Comment 8

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to EJ Chen [:eragonj] from comment #7)
> (In reply to Hsin-Yi Tsai  [:hsinyi] from comment #3)
> > Based on multisim WebAPI, in bug 926302, we already defined the settings key
> > for default service Ids, and gecko listens to their changes. Seems this bug
> > covers DSDS2 AC2, i.e. "There should be a way to select a SIM card for each
> > of these services: MO Voice/USSD/SS, MO Text, MO Data call," so I left a
> > comment here.
> > 
> > settings keys gecko is listening to: ril.mms.defaultServiceId,
> > ril.sms.defaultServiceId, ril.voicemail.defaultServiceId and
> > ril.telephony.defaultServiceId
> 
> Hsin-Yi, may I ask a question ?

EJ, sure :)

> 
> In DSDS SIM manager, we have "outgoing call", "outgoing messages" and
> "outgoing data". According to your comment, it seems that
> "outgoing call" maps to "ril.telephony.defaultServiceId" and
> "ril.voicemail.defaultServiceId",

Right!

> "outgoing messages" maps to "ril.mms.defaultServiceId" and
> "ril.sms.defaultServiceId". 
> 

Seems not true. Per discussion with UX,  "outgoing messages" maps to "ril.sms.defaultServiceId"
while "ril.mms.defaultServiceId" is going to be bound to "outgoing data."

> But how about "outgoing data" ? which key should I set ? 
> 

We didn't define the key for outgoing data in bug 926302 as at that moment gecko didn't need that.
I suggest we use "ril.data.defaultServiceId" that is also proposed in bug 926372 comment 9. Looks good? 

> If I misunderstood anything, please let me know.
> 
> Big thanks :)

Comment 9

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

(In reply to Hsin-Yi Tsai  [:hsinyi] from comment #8) 
> We didn't define the key for outgoing data in bug 926302 as at that moment
> gecko didn't need that.
> I suggest we use "ril.data.defaultServiceId" that is also proposed in bug
> 926372 comment 9. Looks good? 

Yeah, I have checked the comment before asking the key maps and I just want to make sure the key is as what you mentioned in bug 926372 comment 9. 

That change looks good to me and let's just use it :D

In a nut shell, for "outgoing messages", I will map to "ril.mms.defaultServiceId" and "ril.data.defaultServiceId".

Thanks Hsin-Yi :D

Comment 10

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

This bug depends on the other follow-up bugs, I will update related information on them separately.

Comment 11

[Kai-Chih Hu [:khu]]

If the device is ready this week, this bug will be ready in the 1st week of sprint 6.

Comment 12

[Ken Chang[:kenkai]]

Bug 932730 is no long 1.3+ and isn't block for this bug.

Comment 13

[Kai-Chih Hu [:khu]]

May I know if this is planed to land before the end of this week? Or, next week? Thanks.

Comment 14

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Hi Kevin,

this is the story bug and it

Comment 15

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

(In reply to EJ Chen [:eragonj] from comment #14)
Hi Kevin,

this is the story bug and it is depended on the one I mentioned on bug 928295. 

This will be postponed to next week too. 

Thanks.

Comment 16

[Kai-Chih Hu [:khu]]

Can we close this bug before the end of this week?

Comment 17

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

(In reply to Kevin Hu [:khu] from comment #16)
> Can we close this bug before the end of this week?

Kevin, 

if we don't consider bug 944263 and we assume cardState will return with right values as what we thought, then this bug is only dependent on bug 928295 (add simcard security).

For bug 928295, Arthur is reviewing my code now, we hope we can close that before end of the week so that this bug will be closed at the same time.

Thanks Kevin.

Comment 18

[Ken Chang[:kenkai]]

(In reply to EJ Chen [:eragonj] from comment #17)
> if we don't consider bug 944263 and we assume cardState will return with
Hmm...We had discussed this bug before. It doesn't block this bug.

Comment 19

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to Ken Chang[:ken] from comment #18)
> (In reply to EJ Chen [:eragonj] from comment #17)
> > if we don't consider bug 944263 and we assume cardState will return with
> Hmm...We had discussed this bug before. It doesn't block this bug.

Sorry, I was the one setting the dependency. If it's not the case, feel free to correct that.

Comment 20

[Kai-Chih Hu [:khu]]

This can be closed once bug 928295 is closed.

Comment 21

[Kai-Chih Hu [:khu]]

We really need to know when the bug can be landed, because DSDS is a committed feature. Can you help to provide the ETA? Thank you.

Comment 22

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

(In reply to Kevin Hu [:khu] from comment #20)
> This can be closed once bug 928295 is closed.

I just landed bug 928295 so this bug can be closed. 

Thanks.

Comment 23

[Enpei]

Verified.
Fugu
Gaia      a119a0692c24c5ed7c55bab838bae3ecdb9dbec9
Gecko     15ee4e78431b45922b41dea882464b0ccb6b4fac
BuildID   20140110174141
Version   28.0a2