Closed Bug 933635 Opened 7 years ago Closed 7 years ago

B2G NFC: Move ipc code in SystemWorkerManager to ipc/nfc

Categories

(Firefox OS Graveyard :: NFC, defect)

ARM
Linux
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
1.2 C4(Nov8)

People

(Reporter: allstars.chh, Assigned: dgarnerlee)

References

Details

Attachments

(3 files, 1 obsolete file)

In Bug 674741 we have those IPC code (talks to daemon) in SystemWorkerManager.cpp, however in Bug 920551 those ipc code has been moved to ipc/ folder.

So file this bug to follow up these changes to move ipc code to ipc/nfc.
Attachment #825760 - Flags: review?(khuey)
Attached patch Patch 3 (v1) NFC IPC Sources (obsolete) — Splinter Review
Attachment #825763 - Flags: review?(allstars.chh)
Attachment #825761 - Flags: review?(khuey)
Comment on attachment 825763 [details] [diff] [review]
Patch 3 (v1) NFC IPC Sources

Review of attachment 825763 [details] [diff] [review]:
-----------------------------------------------------------------

Please update the title of Patch name and add r=me

::: ipc/nfc/Nfc.cpp
@@ +12,3 @@
>  #include <sys/socket.h>
>  #include <sys/un.h>
> +#include <netdb.h> // For gethostbyname.

Why this?

@@ +22,4 @@
>  #endif
>  
>  #include "jsfriendapi.h"
> +#include "nsTArray.h"

remove this if no needed.

@@ +153,3 @@
>  
>  private:
> +        nsAutoPtr<UnixSocketRawData> mMessage;

nit, indent.
Attachment #825763 - Flags: review?(allstars.chh) → review+
Assignee: nobody → dgarnerlee
Attachment #825760 - Attachment description: Patch 1 (v1) NFC IPC Makefiles → Patch 1 (v1) NFC IPC Makefiles r=khuey
Attachment #825761 - Attachment description: Patch 2 (v1) SystemWorkerManagager IDL changes → Patch 2 (v1) SystemWorkerManagager IDL changes r=khuey
Fixed nits.
Attachment #825763 - Attachment is obsolete: true
Attachment #825812 - Attachment description: Patch 3 (v2) NFC IPC Sources → Patch 3 (v2) NFC IPC Sources r=allstars.chh
Try output (NFC IPC only), mostly green.
https://tbpl.mozilla.org/?tree=Try&rev=33dd611e4752
Keywords: checkin-needed
Depends on: 976537
You need to log in before you can comment on or make changes to this bug.