933635 - B2G NFC: Move ipc code in SystemWorkerManager to ipc/nfc

Status: RESOLVED FIXED

(Firefox OS Graveyard :: NFC, defect)

Description

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

In Bug 674741 we have those IPC code (talks to daemon) in SystemWorkerManager.cpp, however in Bug 920551 those ipc code has been moved to ipc/ folder.

So file this bug to follow up these changes to move ipc code to ipc/nfc.

Comment 1

[Garner Lee]

Attachment: Patch 1 (v1) NFC IPC Makefiles r=khuey

Comment 2

[Garner Lee]

Attachment: Patch 2 (v1) SystemWorkerManagager IDL changes r=khuey

Comment 3

[Garner Lee]

Attachment: Patch 3 (v1) NFC IPC Sources

Comment 4

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Comment on attachment 825763 [details] [diff] [review]
Patch 3 (v1) NFC IPC Sources

Review of attachment 825763 [details] [diff] [review]:
-----------------------------------------------------------------

Please update the title of Patch name and add r=me

::: ipc/nfc/Nfc.cpp
@@ +12,3 @@
>  #include <sys/socket.h>
>  #include <sys/un.h>
> +#include <netdb.h> // For gethostbyname.

Why this?

@@ +22,4 @@
>  #endif
>  
>  #include "jsfriendapi.h"
> +#include "nsTArray.h"

remove this if no needed.

@@ +153,3 @@
>  
>  private:
> +        nsAutoPtr<UnixSocketRawData> mMessage;

nit, indent.

Comment 5

[Garner Lee]

Attachment: Patch 3 (v2) NFC IPC Sources r=allstars.chh

Fixed nits.

Comment 6

[Garner Lee]

Try output (NFC IPC only), mostly green.
https://tbpl.mozilla.org/?tree=Try&rev=33dd611e4752

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/38ed1b74a242
https://hg.mozilla.org/integration/b2g-inbound/rev/4708172b8925
https://hg.mozilla.org/integration/b2g-inbound/rev/d7ee85336570

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/38ed1b74a242
https://hg.mozilla.org/mozilla-central/rev/4708172b8925
https://hg.mozilla.org/mozilla-central/rev/d7ee85336570