Closed Bug 933992 Opened 6 years ago Closed 6 years ago

sLoadTasks removal incorrectly uses long, not Integer

Categories

(Firefox for Android :: General, defect, critical)

All
Android
defect
Not set
critical

Tracking

()

RESOLVED FIXED
Firefox 28
Tracking Status
firefox26 --- unaffected
firefox27 + fixed
firefox28 --- fixed

People

(Reporter: rnewman, Assigned: rnewman)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

No description provided.
This will cause sLoadMap to grow endlessly, and -- due to some of the inefficiencies revealed in Bug 931843 -- it'll hold on to every view, every thumbnail, ...
Summary: sLoadMap removal incorrectly uses long, not Integer → sLoadTasks removal incorrectly uses long, not Integer
[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
  FaviconsRewrite.

User impact if declined: 
  Eventual OOM.

Testing completed (on m-c, etc.): 
  Tested locally with logging, verified that sLoadTasks tends towards 0 items. Patch up for review now, will bake on m-c.

Risk to taking this patch (and alternatives if risky): 
  Should be none.

String or IDL/UUID changes made by this patch:
  None.
Attachment #826140 - Flags: review?(mark.finkle)
Attachment #826140 - Flags: approval-mozilla-aurora?
Attachment #826140 - Flags: review?(mark.finkle) → review+
https://hg.mozilla.org/integration/fx-team/rev/d6136cbe47d1
Severity: normal → critical
Target Milestone: --- → Firefox 28
Depends on: FaviconRevamp
Attachment #826140 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Looks like this merge didn't get recorded.

https://hg.mozilla.org/mozilla-central/rev/d6136cbe47d1
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.