Closed
Bug 933992
Opened 12 years ago
Closed 12 years ago
sLoadTasks removal incorrectly uses long, not Integer
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox26 unaffected, firefox27+ fixed, firefox28 fixed)
RESOLVED
FIXED
Firefox 28
| Tracking | Status | |
|---|---|---|
| firefox26 | --- | unaffected |
| firefox27 | + | fixed |
| firefox28 | --- | fixed |
People
(Reporter: rnewman, Assigned: rnewman)
References
Details
Attachments
(1 file)
|
1012 bytes,
patch
|
sriram
:
review+
bajaj
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•12 years ago
|
||
This will cause sLoadMap to grow endlessly, and -- due to some of the inefficiencies revealed in Bug 931843 -- it'll hold on to every view, every thumbnail, ...
|
|
Assignee | |
Updated•12 years ago
|
Summary: sLoadMap removal incorrectly uses long, not Integer → sLoadTasks removal incorrectly uses long, not Integer
|
|
Assignee | |
Comment 2•12 years ago
|
||
[Approval Request Comment]
Bug caused by (feature/regressing bug #):
FaviconsRewrite.
User impact if declined:
Eventual OOM.
Testing completed (on m-c, etc.):
Tested locally with logging, verified that sLoadTasks tends towards 0 items. Patch up for review now, will bake on m-c.
Risk to taking this patch (and alternatives if risky):
Should be none.
String or IDL/UUID changes made by this patch:
None.
Attachment #826140 -
Flags: review?(mark.finkle)
Attachment #826140 -
Flags: approval-mozilla-aurora?
|
||
Updated•12 years ago
|
Attachment #826140 -
Flags: review?(mark.finkle) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
Severity: normal → critical
Target Milestone: --- → Firefox 28
|
|
Assignee | |
Updated•12 years ago
|
Blocks: fennec-mem, 932054
Depends on: FaviconRevamp
|
||
Updated•12 years ago
|
status-firefox26:
--- → unaffected
|
|
||
Updated•12 years ago
|
Attachment #826140 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
|
|
Assignee | |
Comment 4•12 years ago
|
||
Looks cheerful on fx-team, so:
https://hg.mozilla.org/releases/mozilla-aurora/rev/4aca57f111d3
|
||
Updated•12 years ago
|
status-firefox28:
--- → fixed
|
|
Assignee | |
Comment 5•12 years ago
|
||
Looks like this merge didn't get recorded.
https://hg.mozilla.org/mozilla-central/rev/d6136cbe47d1
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
||
Updated•5 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•