935100 - [Download Manager] Download list edit mode

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Cristian Rodriguez (:crdlc)]

A user deletes downloads by firstly tapping the edit button

Comment 1

[Borja Salguero [:borjasalguero]]

Attachment: Pull request

Comment 2

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8346472 [details] [review]
Pull request

Great work!

Left some comments on github but are pretty simple.

Now time for those tests and we are ready to go!

Thanks a lot Borja!

Comment 3

[Borja Salguero [:borjasalguero]]

Comment on attachment 8346472 [details] [review]
Pull request

After the first review of Francisco, all comments addressed and a bunch of tests added. Kaze, r?

Comment 4

[Borja Salguero [:borjasalguero]]

Comment on attachment 8346472 [details] [review]
Pull request

Francisco, all your comments addressed! r?

Comment 5

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8346472 [details] [review]
Pull request

\o/ edit mode on the way!

Comment 6

[Fabien Cazenave [:kaze]]

Comment on attachment 8346472 [details] [review]
Pull request

R=me with the two last nits.

One note though: the “edit” icon is almost invisible with the new theme, which makes the whole feature almost impossible to discover with the targeted device. Pavel, is that something you’re aware of? Is there already an open bug for that, or should we create one?

Comment 7

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Nope ... But i will check this tomorrow morning and I will ping you back

Comment 8

[Borja Salguero [:borjasalguero]]

Pavel, I created this bug for fixing this https://bugzilla.mozilla.org/show_bug.cgi?id=947181 , could you take a look? Thanks!

Comment 9

[Borja Salguero [:borjasalguero]]

Waiting to Travis for merging after landing last changes requested by :kaze. Thanks a lot!!! :)

Comment 10

[Borja Salguero [:borjasalguero]]

https://github.com/mozilla-b2g/gaia/commit/0cabcbb20f0fbd51860618f8d80f6c284121ec72
https://github.com/borjasalguero/gaia/commit/edbc085cd48d62997c463315945efe388c0df0c9
R+. Merged!