Closed Bug 935100 Opened 9 years ago Closed 9 years ago

[Download Manager] Download list edit mode

Categories

(Firefox OS Graveyard :: Gaia, defect)

All
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
1.3 C1/1.4 S1(20dec)

People

(Reporter: crdlc, Assigned: borjasalguero)

References

Details

(Whiteboard: [systemsfe])

Attachments

(1 file)

46 bytes, text/x-github-pull-request
kaze
: review+
arcturus
: review+
arcturus
: feedback+
Details | Review
A user deletes downloads by firstly tapping the edit button
Blocks: 935082
Whiteboard: [systemsfe]
Blocks: 906257
No longer blocks: 935082
Depends on: 935088
Depends on: 947181
Assignee: nobody → borja.bugzilla
Depends on: 940298
Status: NEW → ASSIGNED
Attached file Pull request
Attachment #8346472 - Flags: feedback?(francisco.jordano)
Comment on attachment 8346472 [details] [review]
Pull request

Great work!

Left some comments on github but are pretty simple.

Now time for those tests and we are ready to go!

Thanks a lot Borja!
Attachment #8346472 - Flags: feedback?(francisco.jordano) → feedback+
Target Milestone: --- → 1.3 C1/1.4 S1(20dec)
Comment on attachment 8346472 [details] [review]
Pull request

After the first review of Francisco, all comments addressed and a bunch of tests added. Kaze, r?
Attachment #8346472 - Flags: review?(kaze)
Comment on attachment 8346472 [details] [review]
Pull request

Francisco, all your comments addressed! r?
Attachment #8346472 - Flags: review?(francisco.jordano)
Comment on attachment 8346472 [details] [review]
Pull request

\o/ edit mode on the way!
Attachment #8346472 - Flags: review?(francisco.jordano) → review+
Comment on attachment 8346472 [details] [review]
Pull request

R=me with the two last nits.

One note though: the “edit” icon is almost invisible with the new theme, which makes the whole feature almost impossible to discover with the targeted device. Pavel, is that something you’re aware of? Is there already an open bug for that, or should we create one?
Attachment #8346472 - Flags: review?(kaze) → review+
Flags: needinfo?(pivanov)
Nope ... But i will check this tomorrow morning and I will ping you back
Flags: needinfo?(pivanov)
Pavel, I created this bug for fixing this https://bugzilla.mozilla.org/show_bug.cgi?id=947181 , could you take a look? Thanks!
Flags: needinfo?(pivanov)
Waiting to Travis for merging after landing last changes requested by :kaze. Thanks a lot!!! :)
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Flags: needinfo?(pivanov)
You need to log in before you can comment on or make changes to this bug.