936385 - [music2] [1] Re-layout the whole ui

Status: RESOLVED INVALID

(Firefox OS Graveyard :: Gaia::Music, defect)

Description

[Dominic Kuo [:dkuo]]

This is the first action item for music2 to adapt the phone/tablet ui, basically this work is to have the ui structure(modify the index.html and css) so that we can implement the features base on it.

This item should cover:
1-1. Handle tablet and phone sizes.
1-2. Handle switching between landscape and portrait.

Comment 1

[eshapiro]

Attachment: pull request

Comment 2

[Dominic Kuo [:dkuo]]

Evan, thanks for working on this so quickly, I got the review request and reviewing it, thanks!

Comment 3

[Dominic Kuo [:dkuo]]

Comment on attachment 830180 [details]
pull request

Evan,

The patch looks good to me, however, some ui changes is not sync with the latest spec. Also, the new js files that you newly added are not jslinted, there are several lint errors. And since we are using strict mode in gaia, you should add "use strict" at the start of every js file, so I am cancelling the review request.

Here is how to install and use the gjslint:
https://developers.google.com/closure/utilities/docs/linter_howto

To speed up the progress, I am addressing those issue and will land it for you because after this first patch is landed, Jim and I can start to implement [2], [3] and [4] in parallel and won't be blocked by this bug.

Comment 4

[Dominic Kuo [:dkuo]]

Attachment: Cherry-picked Evan's patch with issues addressed

Evan,

This is the modified patch that I cherry-picked from your branch with issues addressed, I think the patch covers 1-2 but 1-1, but it's enough for the basic structure so I will land it first, please work on 1-1 and I will leave this bug open so that we can still trace it, thanks.

Comment 5

[Dominic Kuo [:dkuo]]

1-2 landed on master: 7bb12c33a7df34e4f210879ceebb0bc3e792a01d

Comment 6

[Francis Lee [:frlee]]

this is subset of Music2 re-layout for tablet, tag it 1.3+ with target milestones.

Comment 7

[Jim Porter (:squib)]

Closing all music2-specific bugs. The current plan is to gradually incorporate bits of music2 into the current music app, since it will take too long to achieve feature parity in music2.