Closed Bug 936997 Opened 6 years ago Closed 6 years ago

[Flatfish][Window Mgmt] Make modal dialogs flexible

Categories

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::System::Window Mgmt
Platform:
x86
macOS
Type:
defect
Priority:
Not set

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: gasolin, Assigned: gasolin)

References

Details

Attachments

(6 files)

confirm dialog spec
477.78 KB, image/png
Details
alert dialog
477.29 KB, image/png
Details
pull request redirect to github
46 bytes, text/x-github-pull-request
alive
: review+
Details | Review
phone dialog UI (not affect)
78.45 KB, image/png
Details
tablet modal dialog 1
427.15 KB, image/png
Details
tablet modal dialog 2
422.95 KB, image/png
Details 
Follow up of bug 928306.

In previous patch we focus on 1280x800 layout, but its not flexible to other resolutions.

We got new spec and let's implement it by focusing the dialog itself
Attached image confirm dialog spec —
Blocks: flatfish, 935816
Assignee: nobody → gasolin
Attached image alert dialog — 
WIP need UX feedback
Comment on attachment 830174 [details] [review]
pull request redirect to github

Get UX feedback Offline

We'd update the following UI Spec with following values:

  box-shadow: 0 0 1rem #222222;
  border: 0.1rem solid #282828;
Attachment #830174 - Flags: review?(alive)
Alert dialog UX confirmed, good to go!
Please attach "after change" mobile and tablet's picture to this bug, thanks.
Also, please use the term "modal dialog".
Flags: needinfo?(gasolin)
Flags: needinfo?(gasolin)
Summary: [Flatfish][Window Mgmt] Make attention dialogs flexible → [Flatfish][Window Mgmt] Make modal dialogs flexible
Attached image tablet modal dialog 1 —
Attached image tablet modal dialog 2 —
Attachment #830174 - Flags: review?(alive) → review+
merged in gaia-master https://github.com/mozilla-b2g/gaia/commit/0a677be401a72ded7caf11fc44c921e74b1521b6

thanks!
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.