937470 - Eliminate unsafe uses of cloneNode() with no arguments and importNode() with no boolean arg from calendar code

Status: RESOLVED FIXED

(Calendar :: General, defect)

Description

[Boris Zbarsky [:bzbarsky]]

Like bug 937462 but for calendar.  I see some relevant cloneNode() calls in calendar/base/content/dialogs/calendar-event-dialog.js.

Flagging the people last involved in that code, since they presumably know whether it needs adjusting....

Comment 1

[Stefan Sitter [:ssitter]]

Attachment: 937470-cloneNode.diff

Patch changes cloneNode() to cloneNode(true) that should be the same if I read correct.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 830999 [details] [diff] [review]
937470-cloneNode.diff

It's the same now, but it'll stop being the same.  That's the whole point.  Please see bug 937641.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Er, I mean bug 937461.

Comment 4

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 830999 [details] [diff] [review]
937470-cloneNode.diff

bz, not sure why you asked ssitter to review his own patch. If this is how to fix it, r=philipp. Otherwise feel free to handle it differently.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 830999 [details] [diff] [review]
937470-cloneNode.diff

Er, because I totally misread things.  Sorry.  :(

Comment 6

[Stefan Sitter [:ssitter]]

Pushed to https://hg.mozilla.org/comm-central/rev/f583af6bca1a