Closed Bug 937470 Opened 7 years ago Closed 7 years ago

Eliminate unsafe uses of cloneNode() with no arguments and importNode() with no boolean arg from calendar code

Categories

(Calendar :: General, defect)

Product:
Calendar
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: bzbarsky, Assigned: ssitter)

References

Details

Attachments

(1 file)

937470-cloneNode.diff
1.14 KB, patch
Fallen
: review+
Details | Diff | Splinter Review 
Like bug 937462 but for calendar.  I see some relevant cloneNode() calls in calendar/base/content/dialogs/calendar-event-dialog.js.

Flagging the people last involved in that code, since they presumably know whether it needs adjusting....
Flags: needinfo?(ssitter)
Flags: needinfo?(bv1578)
Patch changes cloneNode() to cloneNode(true) that should be the same if I read correct.
Assignee: nobody → ssitter
Status: NEW → ASSIGNED
Attachment #830999 - Flags: review?(philipp)
Flags: needinfo?(ssitter)
Flags: needinfo?(bv1578)
Comment on attachment 830999 [details] [diff] [review]
937470-cloneNode.diff

It's the same now, but it'll stop being the same.  That's the whole point.  Please see bug 937641.
Attachment #830999 - Flags: review?(ssitter)
Er, I mean bug 937461.
Comment on attachment 830999 [details] [diff] [review]
937470-cloneNode.diff

bz, not sure why you asked ssitter to review his own patch. If this is how to fix it, r=philipp. Otherwise feel free to handle it differently.
Attachment #830999 - Flags: review?(philipp) → review+
Comment on attachment 830999 [details] [diff] [review]
937470-cloneNode.diff

Er, because I totally misread things.  Sorry.  :(
Attachment #830999 - Flags: review?(ssitter)
Pushed to https://hg.mozilla.org/comm-central/rev/f583af6bca1a
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
OS: Mac OS X → All
Hardware: x86 → All
Resolution: --- → FIXED
Target Milestone: --- → 3.0
You need to log in before you can comment on or make changes to this bug.