Closed
Bug 937470
Opened 12 years ago
Closed 12 years ago
Eliminate unsafe uses of cloneNode() with no arguments and importNode() with no boolean arg from calendar code
Categories
(Calendar :: General, defect)
Calendar
General
Tracking
(Not tracked)
RESOLVED
FIXED
3.0
People
(Reporter: bzbarsky, Assigned: ssitter)
References
Details
Attachments
(1 file)
|
1.14 KB,
patch
|
Fallen
:
review+
|
Details | Diff | Splinter Review |
Like bug 937462 but for calendar. I see some relevant cloneNode() calls in calendar/base/content/dialogs/calendar-event-dialog.js.
Flagging the people last involved in that code, since they presumably know whether it needs adjusting....
Flags: needinfo?(ssitter)
Flags: needinfo?(bv1578)
|
Assignee | |
Comment 1•12 years ago
|
||
Patch changes cloneNode() to cloneNode(true) that should be the same if I read correct.
Assignee: nobody → ssitter
Status: NEW → ASSIGNED
Attachment #830999 -
Flags: review?(philipp)
Flags: needinfo?(ssitter)
Flags: needinfo?(bv1578)
|
Reporter | |
Comment 2•12 years ago
|
||
Comment on attachment 830999 [details] [diff] [review]
937470-cloneNode.diff
It's the same now, but it'll stop being the same. That's the whole point. Please see bug 937641.
Attachment #830999 -
Flags: review?(ssitter)
|
|
Reporter | |
Comment 3•12 years ago
|
||
Er, I mean bug 937461.
|
||
Comment 4•12 years ago
|
||
Comment on attachment 830999 [details] [diff] [review]
937470-cloneNode.diff
bz, not sure why you asked ssitter to review his own patch. If this is how to fix it, r=philipp. Otherwise feel free to handle it differently.
Attachment #830999 -
Flags: review?(philipp) → review+
|
|
Reporter | |
Comment 5•12 years ago
|
||
Comment on attachment 830999 [details] [diff] [review]
937470-cloneNode.diff
Er, because I totally misread things. Sorry. :(
Attachment #830999 -
Flags: review?(ssitter)
|
|
Assignee | |
Comment 6•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
OS: Mac OS X → All
Hardware: x86 → All
Resolution: --- → FIXED
Target Milestone: --- → 3.0
You need to log in
before you can comment on or make changes to this bug.
Description
•