938510 - switch to tooltool gcc from bug 913442

Status: RESOLVED DUPLICATE of bug 1075183

(Firefox Build System :: General, defect)

Description

[Trevor Saunders (:tbsaunde)]

I'd need to dig through email to get the links but I've tested the following things on try
- try: -b do -p linux,linux64 -u all builds and has no unexpected test issues.
- talos results are the same as trunk, with the exception of cracken (or however its spelled) which seems to have improved? but may just be a fluke.
- 10 or so retriggers don't cause any ICEs

So I guess we might as well try putting this in actual production unless glandium or froydnj have an objection.

Comment 1

[Trevor Saunders (:tbsaunde)]

Attachment: gcc.patch

Comment 2

[Trevor Saunders (:tbsaunde)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6fd717549b5a

Comment 3

[Trevor Saunders (:tbsaunde)]

backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/b50d2b2f98e0 because b2g desktop builds don't seem to get tooltool packages

Comment 4

[Trevor Saunders (:tbsaunde)]

and after adding the manifest to b2g/config/tooltool/linux{32,64}/ we hit https://tbpl.mozilla.org/php/getParsedLog.php?id=30916585&tree=Try because those builds are done in the mozilla-centos-i686 env :( so I guess we can either block on releng  changing that or hack around it somehow.

Comment 5

[Mike Hommey [:glandium]]

Comment on attachment 832769 [details] [diff] [review]
gcc.patch

Review of attachment 832769 [details] [diff] [review]:
-----------------------------------------------------------------

::: build/unix/mozconfig.linux
@@ +4,5 @@
> +CXX="$topsrcdir/gcc/bin/g++"
> +
> +# We want to make sure we use binutils and other binaries in the tooltool
> +# package.
> +mk_add_options PATH="$topsrcdir/gcc:$PATH"

while I'm (re)looking at this: there's a missing /bin here.

Comment 6

[Trevor Saunders (:tbsaunde)]

Attachment: gcctest

turns out in addition to b2g be done on i686 vlagrind jobs don't use tooltool at all :/

Comment 7

[Mike Hommey [:glandium]]

Comment on attachment 8368269 [details] [diff] [review]
gcctest

Review of attachment 8368269 [details] [diff] [review]:
-----------------------------------------------------------------

Note the patch summary refers to the wrong bug ;)

::: build/unix/mozconfig.linux
@@ +1,4 @@
>  . "$topsrcdir/build/mozconfig.common"
>  
> +# some b2g desktop builds still happen on i686 machines, and the tooltool
> +# toolchain is x86_64 only.

b2g desktop should be building on x86-64, but it doesn't use tooltool manifests.

@@ +3,5 @@
> +# some b2g desktop builds still happen on i686 machines, and the tooltool
> +# toolchain is x86_64 only.
> +# We also deal with valgrind builds here, they don't use tooltool manifests at
> +# all yet.
> +if [ -z "$building_b2g" -a -z "$building_valgrind" ]

might as well make that $no_tooltool

Comment 8

[Trevor Saunders (:tbsaunde)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5509778fb65b

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5509778fb65b

Comment 10

[Rail Aliiev [:rail]]

I believe this broke l10n, see bug 966793

Comment 11

[Mike Hommey [:glandium]]

Let's say this is a dupe of bug 1075183. There's bug 965151 for the valgrind part.