Closed Bug 938518 Opened 11 years ago Closed 11 years ago

[Flatfish] make Activity menu not fill fullscreen

Categories

(Firefox OS Graveyard :: Gaia, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED DUPLICATE of bug 935820

People

(Reporter: gasolin, Unassigned)

References

Details

Attachments

(1 file)

Attached image activity menu UI spec
expect: 

On tablet long press the homescreen,
and the activity menu showed as a modal dialog
Blocks: flatfish, 935816
Whiteboard: [good first bug][mentor=gasolin][mentor-lang=zh]
hi Fred,

are you able to have someone to fix this basic issue?
blocking-b2g: --- → 1.3+
Flags: needinfo?(gasolin)
Whiteboard: [good first bug][mentor=gasolin][mentor-lang=zh] → [good first bug][mentor=gasolin][mentor-lang=zh][developer+]
We are occupied till the middle of next week. If someone want to take this, I'd glad to be a mentor
Flags: needinfo?(gasolin)
blocking-b2g: 1.3+ → ---
Hi Fred,
Can I get assigned this bug? I am interested in this.Can you please provide more info about this.It would be helpful. :)
Thanks
Flags: needinfo?(gasolin)
Sure! This bug is a bit challenge on setup environment for simulate tablet and mostly work is done by CSS, Happy hacking!


To solve this bug, You could check slides about developing FirefoxOS (gaia) to know the overall develop flow first
http://www.slideshare.net/gasolin/develop-firefox-os1-28348187

then you need to setup some environment to solve this bug:

1. fork gaia from github, clone your gaia repository to local machine
2. run gaia with nightly browser
3. change the responsive view size to '1312x831'
(Scale nighly browser to 1312x831, which fix the correct mapping to 1280x768)

Then you have everything setup to solve this bug.


Please frequently post on bugzilla and let me know which steps you are currently on, so I can help you on time :)
Assignee: nobody → rishav006
Flags: needinfo?(gasolin)
Hi Fred,

I already set up gaia and running in nightly.
Tell me more about this bug and any other necessary info that will help in fixing the bug .

Thanks
Flags: needinfo?(gasolin)
Wow, it's a good start.

To fix this bug, seach gaia/apps/system to find where the activity menu located in
(hint: always check index.html first)

Once you find it, try to change something on activity menu and make sure it's the right place you'd like to hack.
There are some similar UI ex: bug 928306 are landed in gaia, so you could follow the similar way to fix this bug.

After you feel done, please switch nighly browser layout to make sure the layout still works as usual in phone layout.
Flags: needinfo?(gasolin)
Sorry I made a mistake, the Activity menu(dialog) showed here is done by

* the dialog is triggered by apps/homescreen/js/homescreen.js/onContextMenu, which triggered js/wallpaper.js (since tablet does not search enabled yet)

and have complicated call path, so it's not a good first bug.


If you still interest in these kind of bug, please try bug 935820 first.
Assignee: rishav006 → nobody
Whiteboard: [good first bug][mentor=gasolin][mentor-lang=zh][developer+]
For flatfish, it's the same dialog as bug 935820.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: