93936 - "Work Offline" text in status bar is very unclear

Status: VERIFIED FIXED

(SeaMonkey :: UI Design, defect)

Description

[Benjamin Mucci]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Macintosh; U; PPC; en-US; rv:0.9.3+) Gecko/20010806
BuildID:    2001080608

The "Work" should be remove because it's a "Status" Bar and the other option
(Work online) isn't displayed in same time. Offline/Online should be enough to
discribe the ACTUAL state not the state AFTER clicking... at least IMO.

Comment 1

[Zach Lipton [:zach]]

probably should be "working." mpt: what do you think?

Zach

Comment 2

[Benjamin Mucci]

In fact why the icon isn't enough..?

Comment 3

[grylchan]

Anyone know if this related to this bug, 43406?

or is there another bug out there that landed this
option?

Comment 4

[jglick]

The text should not be there at all.  On hover over, a tooltip with that text 
should appear though.

Comment 5

[Matthew T (active 1999-2002)]

I agree with Jennifer here. The text is misleading and distracting, and takes up
valuable status bar space. It should be removed completely. There are other bugs
on making the online/offline icon clearer.

--> XP Apps/GUI, normal severity because of the high visibility of the problem.

Comment 6

[Bradley Hart]

what do we think of the icon's current tooltip? What about just cutting out 
the text and leaving the icon and tooltip as they are now?

Comment 7

[Claudius Gayle]

How did this get checked-in in the first place?
The tooltip currently reads: "You are online|offline. Click the icon to go
offline|online" It's been like that for a long time, no need to change.

The actual words next to the connected plug icon that read "Work (Off|On)line"
very much need to go away and that's the final answer, regis.

Comment 8

[Blake Ross]

This text should always have been there from a code perspective, but somehow
hewitt exposed it with his box cleanup.

Comment 9

[James Paige]

Okay, I figured out how to fix this puppy.

look at
http://lxr.mozilla.org/seamonkey/source/xpfe/communicator/resources/content/utilityOverlay.xul#27
What needs to be removed is the line that says:
  label="&offlineGoOfflineCmd.label;"

That is causing the label to appear in the first place.

Then look at
http://lxr.mozilla.org/seamonkey/source/xpfe/communicator/resources/content/utilityOverlay.js#78

What needs to be removed there are the two lines that say:

  broadcaster.setAttribute("label", bundle.GetStringFromName("goonline"));

and

  broadcaster.setAttribute("label", bundle.GetStringFromName("gooffline"));

Which change the label when your online/offline state changes.

With those three lines removed or commented out, the icky label dies.

Somebody else is going to have to make a patch for this, I dont have a
development system, I just tested the fix by hacking the jar files on the
2001081003 Win95 nightly build.

Comment 10

[Blake Ross]

Yes, and then what happens when you go off and online?  Does the menuitem label
change in the File menu?

Comment 11

[James Paige]

D'oh! yeah, you are right. That label in the file menu isnt changing when I go
offline and online now :(

Comment 12

[Matthew T (active 1999-2002)]

*** Bug 93715 has been marked as a duplicate of this bug. ***

Comment 13

[James Paige]

Question for somebody who knows:

look at the CSS class statusbarpanel-icononly defined in global.css

.statusbarpanel-icononly {
  padding: 0px;
}

This is the class used by the online/offline icon, the security lock icon, and
probably a number of other statusbar icons.

I see nothing there that makes it textless. Is there supposed to be a CSS rule
in there that somehow prevents the text from appearing? Or is the textlessness
of statusbarpanel-icononly defined elsewhere? Or are people using
statusbarpanel-icononly simply expected, on their honor, not to assign a label
to it?

I observed (and yes I am aware this is a bad thing to do, and does not even
remotely resemble a satisfactory fix) I observed that if I changed this to:

.statusbarpanel-icononly {
  max-width: 32px;
  padding: 0px;
}

I fixed the symptoms (of course, I probably screw up things elsewhere too)

so anyway. my point is, is there something more that needs to go in
statusbarpanel-icononly ? some kind of magical "text-display:disabled;" or
"label:hidden;" or some such thing like that?

Comment 14

[James Paige]

Oh, hey. I *might* have just answered my own question...

It appears that the entire purpose of
/xpfe/communicator/resources/content/utilityOverlay.css is to prevent the text
from displaying on the offline-status thingy, which is of class
statusbarpane-icononly

here is the entire file, all 8 lines of it:

  /** 
   * Essential behaviour styles for Communicator package
   **/

  #offline-status > .statusbar-panel-text
    {
      display: none;
    }

Comment 15

[Gervase Markham [:gerv]]

mozillauser: try removing the XUL line but leaving the broadcasters. 

Gerv

Comment 16

[Blake Ross]

There we go.  That's the reason.  hewitt added a box to statusbarpanel so that 
style rule is failing.  Not that that's not incredibly lame anyways (having the 
text but hiding it).

Comment 17

[Joe Hewitt (gone)]

fixed

Comment 18

[Eric Hodel]

Please do not remove the text, only hide it.  It allows skin designers to create
icon-free skins.  I had thought there was a bug on adding text for the
online/offline button, but maybe I only asked about it.

Comment 19

[grylchan]

This the bug you are talking about Eric, bug 43406?

Comment 20

[Eric Hodel]

That isn't the bug I was thinking of, it was only skinnability minded and
probably only discussed on IRC.  I just wanted to make sure the status text
would stay but remain hidden.  (Like the modern nav buttons don't have Back,
Forward, Reload, Stop, etc., but the text is still there for classic.)

Comment 21

[R.K.Aa.]

*** Bug 96996 has been marked as a duplicate of this bug. ***

Comment 22

[Claudius Gayle]

VERIFIED Fixed with 20010907 builds