939504 - Leftover <CanGC> Template on AtomizeChars in BIG ENDIAN case breaking the build

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Landry Breuil (:gaston)]

Sparc64 tip fails to build with

/home/buildslave/mozilla-central-sparc64/build/js/src/jsatom.cpp: In function 'bool js::XDRAtom(js::XDRState<mode>*, js::MutableHandleAtom)':
/home/buildslave/mozilla-central-sparc64/build/js/src/jsatom.cpp:507:24: error: no match for 'operator<' (operand types are 'JSAtom*(js::ExclusiveContext*, const jschar*, size_t, js::InternBehavior) {aka JSAtom*(js::ExclusiveContext*, const char16_t*, long unsigned int, js::InternBehavior)}' and 'js::AllowGC')
     atom = AtomizeChars<CanGC>(cx, chars, nchars);

(from http://buildbot.rhaalovely.net/builders/mozilla-central-sparc64/builds/614/steps/build/logs/stdio)

It seems to be a fallout of the last commit to jsatom.cpp removing those templates, but forgetting to update the !LITTLE_ENDIAN side.

changeset:   154277:53b2cdf230dc
user:        Brian Hackett <[e-mail]>
date:        Sat Nov 09 19:53:53 2013 -0700
summary:     Bug 928050 - Don't GC during atomization, r=billm.

Comment 1

[Landry Breuil (:gaston)]

Will remove <CanGC> on my builder and report success/failure..

Comment 2

[Landry Breuil (:gaston)]

Attachment: remove leftover <CanGC>

Build seems to go much further with <CanGC> removed, see http://buildbot.rhaalovely.net/builders/mozilla-central-sparc64/builds/615

Comment 3

[Landry Breuil (:gaston)]

note: this build failed later on because of bug 939355 but js was definitely built

Comment 4

[Landry Breuil (:gaston)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3d3a8f13aa66

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/3d3a8f13aa66