Closed Bug 940049 Opened 11 years ago Closed 11 years ago

Regression: Favicon does not always load on first page-load

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Version:
27 Branch
Platform:
ARM
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox27 verified, firefox28 fixed, fennec28+)

Status:
RESOLVED FIXED
Milestone:
Firefox 28
Tracking Flags:
Tracking Status
firefox27 --- verified
firefox28 --- fixed
fennec 28+ ---

People

(Reporter: aaronmt, Assigned: rnewman)

References

(
URL
)

Details

(Keywords: regression, reproducible) 

See video: http://people.mozilla.org/~atrain/misc/favicon.mp4

This is about ~80% reproducible for me currently. Simply visiting Twitter on a new profile will not display the site favicon.

--
Nightly (11/18) | LG Nexus 4 (Android 4.4)
Are you able to reproduce this on a site that *doesn't* redirect to a mobile page, Aaron?

(twitter.com -> m.twitter.com)
Could this be one of the edgecases covered in Bug 920331?

Bug 914027 never did get the finished up.
(In reply to Richard Newman [:rnewman] from comment #1)
> Are you able to reproduce this on a site that *doesn't* redirect to a mobile
> page, Aaron?
> 
> (twitter.com -> m.twitter.com)

Yes.
tracking-fennec: --- → ?
Reproducible again on Twitter on office WiFi this time around, Nightly (11/20) on my Galaxy S4 (Android 4.3)
Assignee: nobody → rnewman
tracking-fennec: ? → 28+
Aaron: I'm able to reproduce this with Aurora, but not with current Nightly. Could you re-verify?
status-firefox27: --- → affected
I'll take a look tomorrow.
Flags: needinfo?(aaron.train)
Yes, this if fixed on Nightly and broken on Aurora. Do we know which bug?
Flags: needinfo?(aaron.train)
Uplifting these:

 0 A 18c49e0f4eb5: Bug 941982 - Clean up about: page handling. r=mcomella
 1 A b660e7e10184: Bug 941868 - Part 1: add NonEvictingLruCache. r=mcomella
 2 A b5a3121b05c1: Bug 941868 - Part 2: load and cache certain preloaded favicons on launch, and remove favicon from about:home's HTML content. r=mcomella
 3 A cffd41d1d7e8: Bug 941868 - Part 3: don't evict built-in bitmaps, either. r=mcomella
 4 A a164ef0013e7: Bug 941868 - Part 4: tidying and enforcing TabEvent non-null-tab constraint. r=mcomella
 5 A 2296ea325107: Bug 941868 - Part 5a: uncontested cleanup and logging. r=mcomella

fixes this in my local build.
Depends on: 941868, 941982
I've submitted approval requests for those two bugs. Will upload an APK to test shortly.
Status: NEW → ASSIGNED
http://people.mozilla.org/~rnewman/firsticon.apk

Aaron, does this solve things for you? (And otherwise meet your quality bar for Aurora?)
Flags: needinfo?(aaron.train)
Keywords: qawanted
(In reply to Richard Newman [:rnewman] from comment #10)
> http://people.mozilla.org/~rnewman/firsticon.apk
> 
> Aaron, does this solve things for you? (And otherwise meet your quality bar
> for Aurora?)

Yes this build fine for me, thanks.
Flags: needinfo?(aaron.train)
Keywords: qawanted
See Bug 941868 for fix.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
status-firefox27: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 28
Verified fixed on:
Build: Firefox for Android 27 Beta 2
Device: LG Nexus 4
OS: Android 4.2.2
status-firefox27: fixed → verified
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.