940129 - Build part of widget/gonk in unified mode

Status: RESOLVED WONTFIX

(Core Graveyard :: Widget: Gonk, defect)

Comment 1

[Benoit Jacob [:bjacob] (mostly away)]

Attachment: Build part of widget/gonk in unified mode

:roc for actual code changes, :ehsan for build changes.

This is only a partial builds. Some parts like libdisplay and nsWindow.cpp gave me too much trouble with android LOG macros getting redefined, so I just left them out rather than making a too complicated patch.

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 8334325 [details] [diff] [review]
Build part of widget/gonk in unified mode

Review of attachment 8334325 [details] [diff] [review]:
-----------------------------------------------------------------

::: widget/gonk/nsAppShell.cpp
@@ -75,5 @@
>  # define VERBOSE_LOG(args...)                   \
>      (void)0
>  #endif
>  
> -using namespace android;

I think you should just build this file in SOURCES instead of adding android:: prefixes everywhere.

Comment 3

[(no longer active)]

Comment on attachment 8334325 [details] [diff] [review]
Build part of widget/gonk in unified mode

Review of attachment 8334325 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with what roc suggested.

::: widget/gonk/moz.build
@@ +65,5 @@
>  ]
>  
> +# nsWindow.cpp gave me weird build errors then I tried to put it in UNIFIED_SOURCES.
> +# Apparently due to LOG or related logging macros being redefined.
> +# Worth re-trying at some point.

Please rewrite this comment in passive voice.  :-)

Comment 4

[Benoit Jacob [:bjacob] (mostly away)]

Attachment: v2

Comment 5

[Benoit Jacob [:bjacob] (mostly away)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6f476f02c21e

Comment 6

[Benoit Jacob [:bjacob] (mostly away)]

backed out: https://hg.mozilla.org/integration/mozilla-inbound/rev/21a8de163f5b

Comment 7

[Benoit Jacob [:bjacob] (mostly away)]

Attachment: last attempt, still fails

https://tbpl.mozilla.org/?tree=Try&rev=3bf3468d3471

still failing; giving up, the scope of this porting was very limited anyways.