94020 - change Tasks > Mail to Tasks > Mail & News

Status: VERIFIED FIXED

(SeaMonkey :: UI Design, defect)

Description

[sairuh (rarely reading bugmail)]

summary sez it all. spun off from bug 87195.

assigning to stephend --apparently he has a patch for changing the Tasks menu
item Mail to Mail & News.

what do folx think of this?

Comment 1

[sairuh (rarely reading bugmail)]

cc'ing the writers, since this change might affect the documentation.

Comment 2

[Asa Dotzler [:asa]]

Yes!!!
(sorry for shouting)

Comment 3

[[e-mail] (gone - use [e-mail] instead)]

sorry guys...

*** This bug has been marked as a duplicate of 20988 ***

Comment 4

[sairuh (rarely reading bugmail)]

stephend: sorry, i don't understand how renaming the Tasks > Mail menu item to
Tasks > Mail & News is the same as Newsgroups not being implemented from the
Tasks menu. after all, aren't we just launching the mailnews window when we
select Mail nowadays?

Comment 5

[[e-mail] (gone - use [e-mail] instead)]

This bug and its variations have a long sordid history.  See bug 69892, which 
privately I was told was a DUP of bug 20988.  My bug had the same exact intent 
of this, as it makes sense that newsgroups would only be on the menu once.

I can't think of a case where you'd want:

Tasks | Mail & News to open just Mail, and a separate Tasks | Newsgroups to go 
to your default server.  In that case, Tasks | Mail & News would be redundant, 
since later down the menu, News has a representation.

If we let this bug stand by itself, and rename it to Tasks | Mail & News, and 
that opens just Mail, then bug 20988 would become invalid by reason of 
redunancy, wouldn't it?  Jennifer, your take?

Comment 6

[[e-mail] (gone - use [e-mail] instead)]

http://www.mozilla.org/projects/ui/communicator/framework/menu_framework/#tasks

I believe that is the spec?

Comment 7

[jglick]

I guess the question is, do we want:

1. One menu item, "Mail & News". Selecting the menu item opens the Mail/News 
window with no focus (or maybe first account, probably a mail acct, has focus).

2. Two separate menu items, "Mail" and "News" (or Newsgroups). Selecting Mail 
opens the window with focus to the first mail acct. If no account exists yet, 
the new account wizard opens with mail acct selected by default. Selecting 
"News" opens the window with focus to the first news acct (like 4.x does). If no 
news acct exists yet, new account wizard opens with news acct seleted by 
default.

Thoughts?

Comment 8

[(not reading, please use [e-mail] instead)]

I'd suggest one item "Mail & News" that opens the default account.

4.x had the concept of default news (and default mail) accounts.
mozilla only has one default account.

doing two tasks properly would mean fixing
http://bugzilla.mozilla.org/show_bug.cgi?id=16343, and us extending the account
manager UI to have default news and default non-news, and migrating the
"default" news account pref.

all of that is mozilla 2.0 stuff, given our current priorities.

I'd say go with "Mail & News" and when then time comes, we can split it up.

Comment 9

[sairuh (rarely reading bugmail)]

i agree with seth, for the time being have a single menu item to handle Mail &
News...so, will reopen this puppy for the nonce.

Comment 10

[jglick]

OK, unless anyone disagrees, lets go with "Mail & News".

Comment 11

[[e-mail] (gone - use [e-mail] instead)]

I actually got sr=blake from bug 94037 for the changes in that bug (these bugs
are very related).  Timeless checked in the fix for *this* bug with the patch
that I'm about to attach.  r=robinf/jglick carried over from bug 94037.  sorry
about the mix-up.

Comment 12

[[e-mail] (gone - use [e-mail] instead)]

Attachment: Patch that was committed.

Comment 13

[[e-mail] (gone - use [e-mail] instead)]

My apologies to all on this list - I kept seeing strange build errors (XML 
parsing errors), but couldn't figure out how my "lowly" DTD changes could have 
caused them.  So, I got the usual sr approval, and had timeless check-in for me.
Why my changes caused the XML errors (this is so obvious, it's stupid):

the "&" in a DTD's entity signifies a unique identifier, and in this case, 
Mozilla, on startup of -mail, was looking for "Mail" which is parsed fine, 
since it's just a string, and also "& News", which it thought was a reference 
to an identifier, instead of a unique string, like I intended it to be.  So, 
the short story is that Suresh graciously saved my rear and fixed the XML 
parsing errors (taskbar was missing mail/addressbook, etc) and he checked 
in, "Mail News".  This is just a tourniquet to stop moz's bleeding, but I 
intend to figure out how to escape the ampersand, and if we can't then, "Mail 
and News" or "Mail/News".  Again, my humblest apologies.

Comment 14

[timeless]

r=timeless for the new patch which uses & i should have caught that when i 
was committing...

Comment 15

[[e-mail] (gone - use [e-mail] instead)]

Attachment: Correct (working) patch

Comment 16

[Ben Goodger (use ben at mozilla dot org for email)]

sr=[e-mail]

Comment 17

[[e-mail] (gone - use [e-mail] instead)]

Fixed for real this time.

C:\moz_src\mozilla\mailnews\base\resources\locale\en-US>cvs commit -m "94020.  '
Mail' into 'Mail & News'.  r=timeless, sr=ben (correct fix this time)" mailTasks
Overlay.dtd
Checking in mailTasksOverlay.dtd;
/cvsroot/mozilla/mailnews/base/resources/locale/en-US/mailTasksOverlay.dtd,v  <-
-  mailTasksOverlay.dtd
new revision: 1.8; previous revision: 1.7
done

Comment 18

[sairuh (rarely reading bugmail)]

checked the following windows, and Tasks > Mail & News is happily there.

Navigator
Mail & News
Instant Messenger
Address Book
Composer
mail compose
IM compose

vrfy fixed:

linux, 2001.08.15.14-comm
mac OS 9.1 [emul on X], 2001.08.15.08-comm
winNT, 2001.08.15.06-comm

thx a lot, stephend!

Comment 19

[Matthew T (active 1999-2002)]

*** Bug 81748 has been marked as a duplicate of this bug. ***