87195 - prefs: "Offline and Disk Space" in tree is too wide

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Backend, defect, P3)

Description

[sairuh (rarely reading bugmail)]

Offliine and Disk Space is now the widest item in the preferences dialog
category tree. it affects all platforms, and both skins.

jglick et al., is there any way to shorten this?

Comment 1

[sairuh (rarely reading bugmail)]

see bug 80404, a more generic bug for this problem.

will attach screenshots.

Comment 2

[grylchan]

Dupe of Bug 84692?

Or check this bug which is improving offline and disk space ui 
bug 81753

Maybe we need to merge some of these bugs into 1?

Comment 3

[sairuh (rarely reading bugmail)]

clarification:

this doesn't look as bad on win32 --unless the scrollbar is present, in which
case only "Offline and Disk Sp..." appears.

on linux [either theme], when there's no scrollbar, there needs to be a bit more
whitespace btwn the label and the edge of the tree's pane. when the scrollbar is
present, "Offline and Disk Sp..." is displayed.

on mac [either theme], whether or not there's a scrollbar, "Offline and Disk
Sp..." is always displayed.

Comment 4

[sairuh (rarely reading bugmail)]

not quite bug 84692...will add dep for bug 81753.

Comment 5

[sairuh (rarely reading bugmail)]

Attachment: linux classic shot, no scrollbar

Comment 6

[sairuh (rarely reading bugmail)]

Attachment: linux modern shot, with scrollbar

Comment 7

[sairuh (rarely reading bugmail)]

correction on Mac observation:

"Offline and Disk Sp..." displayed when there's no scrollbar [either theme].

"Offline and Disk ..." displayed where the scrollbar is present [either theme].
                 ^
                 |
                whitespace btwn the word and the ellipses.

Comment 8

[timeless]

the easiest fix is to split it into two panels.

Comment 9

[jglick]

In the short term, does using "&" instead of "and" make a difference?

Comment 10

[jglick]

For all items of course (not just Offline & Disk Space).

Comment 11

[sairuh (rarely reading bugmail)]

jglick, cool suggestions.

not sure if there are bugs for changing to "Mail & Newsgroups" or "Privacy &
Security" already. however, they'd each have different owners anyhow.

i'd think Offline & Diskspace would still spill over, at least on mac and on
linux [w/scrollbar for latter].

Comment 12

[Diane Sun]

Attachment: Fix to enlarge the window x-size

Comment 13

[Diane Sun]

*** Bug 87276 has been marked as a duplicate of this bug. ***

Comment 14

[Diane Sun]

Request R & SR,  Bhuvan and Seth?

Comment 15

[Håkan Waara]

No, no, no!  I am very doubtful that Ben, Mpt, Blake or anyone else wants to
enlare the preferences window even more.

There have been endless discussions about the pref windows size, and the
solution is not to increase it for each new addition.

If you are going to change the pref window. I suggest you choose Ben as sr=/r=
as opposed to Seth. He has been working on pref window lately.

Comment 16

[Blake Ross]

Right, this dialog is not being resized.

Skillful avoidance of the:

"<!-- This dialog has a fixed size and is not resizable. 
     You MAY NOT increase the size of this dialog. 
     Questions, Comments -> [e-mail] -->"

message right above that tag, though, I must say...

Comment 17

[Blake Ross]

If anything, why don't you make the tree wider?

But before we go there, I'd love to hear why Offline and Disk Space are grouped 
together...

Comment 18

[Håkan Waara]

I argued to do that (and, IIRC, have it as a "global" panel in Account Settings
where it belongs) in another Offline and Disk Space bug.

Comment 19

[Diane Sun]

Attachment: Make the window resizable

Comment 20

[Diane Sun]

Request R & SR again.

Comment 21

[Håkan Waara]

Um, Diane, see previous comments -- reasons for why this patch would probably be
disapproved by Ben.

Comment 22

[(not reading, please use [e-mail] instead)]

diane, wait for ben or german to comment on why the pref window is not going to
be resizable.

ben is the module owner for that dialog, so you'll need his review.

Comment 23

[Diane Sun]

Request R & SR on either way, attachment 40018 [details] [diff] [review] or 43596,  Ben, German?  

Comment 24

[Ben Goodger (use ben at mozilla dot org for email)]

No. This dialog is not ever going to be made resizable on the trunk. 
Resizability is never an excuse for content that does not fit. 

I suggest modifying the Offline and Disk Space UI so that the content fits. 

Soon I will impose further restrictions on new content being developed for this 
preferences dialog and file bugs on outstanding issues. 

Comment 25

[Blake Ross]

Missed 0.9.3.

Comment 26

[Diane Sun]

Attachment: Screenshot

Comment 27

[Diane Sun]

Attachment: Fix to change the word in UI

Comment 28

[(not reading, please use [e-mail] instead)]

I'm ok with changing "Offline And Disk Space" to "Offline & Disk Space".

We've already changed to "Offline & Disk Space" in the account manager, so this
makes sense.

but as always, please wait for jglick to OK the UI change.

note, changing " and " to " & " may not be enough.  4.x had just "Offline".  The
"Offline & Disk Space" panel is close to running out of room.  If we plan on
adding more items, we might need to re-spec the tree.

jglick / diane:  do you know if any more items are going to be added to this
pref panel?

either way, jglick, can you update the spec?  the spec doesn't have much on
"Offline" in prefs.

see:  http://www.mozilla.org/mailnews/specs/prefs/Preferences.html

Comment 29

[jglick]

Screenshot(id=44652)looks good. 

Offline spec is here:
http://www.mozilla.org/mailnews/specs/offline/images/PrefOff1.gif

I will update this spec and the prefs spec.

Comment 30

[(not reading, please use [e-mail] instead)]

sr=sspitzer on http://bugzilla.mozilla.org/showattachment.cgi?attach_id=44653

for consistency, I think we should do:

"Mail and Newsgroups" -> "Mail & Newsgroups"
"Privacy and Security" -> "Privacy & Security"

ben/german/jglick/robin, any objections?

Comment 31

[jglick]

I like "Mail & News" personally. :-)

Comment 32

[sairuh (rarely reading bugmail)]

seth/jen: agreed, i'd like to replace 'and' with '&' in this and the other prefs
categories --wait, i already said that on 2001-06-21 18:14. ;) anyone find those
as separate, existing bugs? [pardon my grogginess --still pulling self from
vacation mode.]

Comment 33

[(not reading, please use [e-mail] instead)]

sounds like we are all in agreement.

1) we should also convert "Copies and Folders" to "Copies & Folders" in account
manager.

2) I also like "Mail & News" better than "Mail & Newsgroups".   If we do that,
"Tasks | Mail" should be "Tasks | Mail & News".  (I think stephend owns that
bug, or started a patch for it once.)

jglick, any objection to that?  we should probably start spinning off bugs for
all these changes.

Comment 34

[sairuh (rarely reading bugmail)]

related bugs filed:

bug 94018: change all instances of 'Mail and Newsgroups' to 'Mail & News'
bug 94020: change Tasks > Mail to Tasks > Mail & News
bug 94022: change 'Copies and Folders' to 'Copies & Folders'
bug 94026: change 'Privacy and Security' to 'Privacy & Security'

Comment 35

[jglick]

sounds good. :-)

Comment 36

[eddyk]

r=eddyk on http://bugzilla.mozilla.org/showattachment.cgi?attach_id=44653

Comment 37

[Diane Sun]

checked in.

Comment 38

[grylchan]

Commercial builds
2001082008 - win nt 4.0
2001082108 - linux 2.2, mac 9.0.4

Verified for both themes that the Offline and Disk Space panel in the 
Preferences window:
  - that Offline and Disk Space is changed to Offline & Disk Space
  - the category column displays correctly
  - the Offline & Disk Space panel is displayed correctly
  - proper defaults are set