940289 - Bookmarks menu slow to respond on mouse over

Status: RESOLVED WORKSFORME

(Firefox :: Toolbars and Customization, defect)

Description

[B.J. Herbison]

Steps to reproduce:
* Open the bookmarks menu.
* Mouse over entries with submenus.

Expected result:
Submenus open rapidly.

Actual result:
There is a delay before the submenus open.

The delay also happens for sub-submenus.

Depending on screen position and bookmark length the submenus may appear to the left or the right. When the menus don't appear immediately I start to look in the direction I expect the menu to appear (the same direction as the last menu). It's disconcerting when the menu then appears on the other side.

This doesn't appear to be an Australis issue, the lag appears to be about the same with Firefox 25 and Nightly 28. I just happened to notice the effect as I was paying more attention to the bookmarks menu today with the new appearance.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

I'm going to guess that this is because we're synchronously constructing those menupopups with the bookmarks data. It might be worthwhile to see if we can pump out some nodes into the menupopups in chunks to let the event loop breathe...

But I think that might be orthogonal to Australis.

Mano - assuming I've got all my facts straight here, are there any big technical challenges to let the event loop breathe some while constructing those menupopups?

Comment 2

[Asaf Romano (gone)]

You'd have to check in what ways the corresponding places view (the one in browserPlacesViews.js, that is) are assuming the user only interacts with a fully loaded view. The only thing I can think about off-hand is D&D logic.

Comment 4

[Matt Brubeck (:mbrubeck)]

Attachment: patch

Keyboard navigation of menus sets the [_moz-menuactive] attribute.

Comment 5

[Matt Brubeck (:mbrubeck)]

Comment on attachment 8363984 [details] [diff] [review]
patch

Sorry, wrong bug.  (That patch was meant for bug 940286.)

Comment 6

[Mike de Boer [:mikedeboer]]

This is indeed not Australis related, as suggested in comment 0.
Setting P- to clear it for Australis tracker(s).

Comment 7

[Albert Scheiner [:alberts]]

confirming on macOS and resetting bug status

Comment 8

[B.J. Herbison]

I have not seen this problem for quite a while.