941132 - getElementPosition not matching webdriver command getElementLocation

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Andreas Tolfsen ❲:ato❳]

Marionette uses "getElementPosition" for closing windows while the
expected webdriver command is "getElementLocation".

This incompatibility makes it harder to use Marionette directly
without maintaining a WebDriver-to-Marionette command conversion set.

Comment 1

[David Burns :automatedtester]

raised https://www.w3.org/Bugs/Public/show_bug.cgi?id=24132 to add it to the spec

Comment 2

[Andreas Tolfsen ❲:ato❳]

Attachment: 0001-Bug-941132-getElementPosition-not-matching-webdriver.patch

try: https://tbpl.mozilla.org/?tree=Try&rev=62f92588cd0c

Comment 3

[David Burns :automatedtester]

Comment on attachment 8362548 [details] [diff] [review]
0001-Bug-941132-getElementPosition-not-matching-webdriver.patch

Review of attachment 8362548 [details] [diff] [review]:
-----------------------------------------------------------------

just realised I missed this, r+ can be carried forward if this is corrected

::: testing/marionette/marionette-listener.js
@@ +1707,4 @@
>    }
>  }
>  
> +/** Get the element's top left-hand corner point. */

Can we have this back as multi line please

Comment 4

[Andreas Tolfsen ❲:ato❳]

Attachment: 0001-Bug-941132-getElementPosition-not-matching-webdriver.patch

Comment 5

[Ryan VanderMeulen [:RyanVM]]

This doesn't apply on top of the other patches you requested checkin on. Please rebase and indicate the proper landing order.

Comment 6

[Andreas Tolfsen ❲:ato❳]

Attachment: 0001-Bug-941132-getElementPosition-not-matching-webdriver.patch

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/236a56500ef3

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Something in the push for this, bug 941136, and bug 961792 broke all Marionette-based test suites. Backed out.
https://hg.mozilla.org/integration/mozilla-inbound/rev/80ac99aa1dbf

https://tbpl.mozilla.org/php/getParsedLog.php?id=33345104&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=33345278&tree=Mozilla-Inbound

Comment 9

[Andreas Tolfsen ❲:ato❳]

It seems the sinning commit is bug 941132:

https://tbpl.mozilla.org/?tree=Try&rev=596c2cbd9f84 <--
https://tbpl.mozilla.org/?tree=Try&rev=723688651c6c
https://tbpl.mozilla.org/?tree=Try&rev=07d800bd841b

Comment 10

[Andreas Tolfsen ❲:ato❳]

Attachment: 0001-Bug-941132-getElementPosition-not-matching-webdriver.patch

Fixed typo in patch which caused Mn tests to catch fire.  Carrying forward r+.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/866c407c65f8

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/866c407c65f8

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/c7f586adde66