Closed Bug 941132 Opened 7 years ago Closed 7 years ago

getElementPosition not matching webdriver command getElementLocation

Categories

(Testing :: Marionette, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(firefox28 fixed, firefox29 fixed)

RESOLVED FIXED
mozilla29
Tracking Status
firefox28 --- fixed
firefox29 --- fixed

People

(Reporter: ato, Assigned: ato)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 3 obsolete files)

Marionette uses "getElementPosition" for closing windows while the
expected webdriver command is "getElementLocation".

This incompatibility makes it harder to use Marionette directly
without maintaining a WebDriver-to-Marionette command conversion set.
Assignee: nobody → ato
Status: NEW → ASSIGNED
Attachment #8362548 - Flags: review?(dburns) → review+
Comment on attachment 8362548 [details] [diff] [review]
0001-Bug-941132-getElementPosition-not-matching-webdriver.patch

Review of attachment 8362548 [details] [diff] [review]:
-----------------------------------------------------------------

just realised I missed this, r+ can be carried forward if this is corrected

::: testing/marionette/marionette-listener.js
@@ +1707,4 @@
>    }
>  }
>  
> +/** Get the element's top left-hand corner point. */

Can we have this back as multi line please
Attachment #8362548 - Attachment is obsolete: true
Attachment #8362910 - Flags: review+
Keywords: checkin-needed
This doesn't apply on top of the other patches you requested checkin on. Please rebase and indicate the proper landing order.
Keywords: checkin-needed
Attachment #8362910 - Attachment is obsolete: true
Attachment #8363077 - Flags: review+
Keywords: checkin-needed
Fixed typo in patch which caused Mn tests to catch fire.  Carrying forward r+.
Attachment #8363760 - Flags: review+
Keywords: checkin-needed
Attachment #8363077 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/866c407c65f8
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
Keywords: checkin-needed
Whiteboard: checking-needed-aurora
You need to log in before you can comment on or make changes to this bug.