941136 - getUrl not matching webdriver command getCurrentUrl

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Andreas Tolfsen ❲:ato❳]

Marionette uses "getUrl" for getting the current browser window's URL
while the expected webdriver command is "getCurrentUrl".

This incompatibility makes it harder to use Marionette directly
without maintaining a WebDriver-to-Marionette command conversion set.

Comment 1

[David Burns :automatedtester]

Raised https://www.w3.org/Bugs/Public/show_bug.cgi?id=24131 as its not currently in the specification

Comment 2

[Andreas Tolfsen ❲:ato❳]

Attachment: 0001-Bug-941136-getUrl-not-matching-webdriver-command-get.patch

try: https://tbpl.mozilla.org/?tree=Try&rev=bc5c2a19e682

Comment 3

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8362490 [details] [diff] [review]
0001-Bug-941136-getUrl-not-matching-webdriver-command-get.patch

Forgot to update the Python client.  There's nothing functionally wrong with the current patch, but I'll upload a new one that covers everything in one go.

Comment 4

[Andreas Tolfsen ❲:ato❳]

Attachment: 0001-Bug-941136-getUrl-not-matching-webdriver-command-get.patch

Uploaded new patch that also updates the Python client.

new try: https://tbpl.mozilla.org/?tree=Try&rev=5c2a5766db49

Comment 5

[David Burns :automatedtester]

Comment on attachment 8362556 [details] [diff] [review]
0001-Bug-941136-getUrl-not-matching-webdriver-command-get.patch

Review of attachment 8362556 [details] [diff] [review]:
-----------------------------------------------------------------

r+ if you can update the with the comment

::: testing/marionette/marionette-listener.js
@@ +1236,4 @@
>    curFrame.location = msg.json.url;
>  }
>  
> +/** Get URL of the top level browsing context. */

Can we have this multi line again

Comment 6

[Andreas Tolfsen ❲:ato❳]

Attachment: 0001-Bug-941136-getUrl-not-matching-webdriver-command-get.patch

Comment 7

[Ryan VanderMeulen [:RyanVM]]

This doesn't apply on top of the other patches you requested checkin on. Please rebase and indicate the proper landing order.

Comment 8

[Andreas Tolfsen ❲:ato❳]

Attachment: 0001-Bug-941136-getUrl-not-matching-webdriver-command-get.patch

Rebased patch.  Please apply this first, then the updated patch from bug 941132.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/02130207774e

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Something in the push for this, bug 941132, and bug 961792 broke all Marionette-based test suites. Backed out.
https://hg.mozilla.org/integration/mozilla-inbound/rev/80ac99aa1dbf

https://tbpl.mozilla.org/php/getParsedLog.php?id=33345104&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=33345278&tree=Mozilla-Inbound

Comment 11

[Andreas Tolfsen ❲:ato❳]

It seems the sinning commit is bug 941132:

https://tbpl.mozilla.org/?tree=Try&rev=596c2cbd9f84 <--
https://tbpl.mozilla.org/?tree=Try&rev=723688651c6c
https://tbpl.mozilla.org/?tree=Try&rev=07d800bd841b

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/df11842197ff

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/df11842197ff

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/7ecef9a70b64