Closed
Bug 941136
Opened 11 years ago
Closed 11 years ago
getUrl not matching webdriver command getCurrentUrl
Categories
(Remote Protocol :: Marionette, defect)
Tracking
(firefox28 fixed, firefox29 fixed)
RESOLVED
FIXED
mozilla29
People
(Reporter: ato, Assigned: ato)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 3 obsolete files)
|
4.63 KB,
patch
|
ato
:
review+
|
Details | Diff | Splinter Review |
Marionette uses "getUrl" for getting the current browser window's URL
while the expected webdriver command is "getCurrentUrl".
This incompatibility makes it harder to use Marionette directly
without maintaining a WebDriver-to-Marionette command conversion set.
|
||
Comment 1•11 years ago
|
||
Raised https://www.w3.org/Bugs/Public/show_bug.cgi?id=24131 as its not currently in the specification
|
Assignee | |
Updated•11 years ago
|
Status: NEW → ASSIGNED
QA Contact: ato
|
|
Assignee | |
Comment 2•11 years ago
|
||
Attachment #8362490 -
Flags: review?(dburns)
|
|
Assignee | |
Comment 3•11 years ago
|
||
Comment on attachment 8362490 [details] [diff] [review]
0001-Bug-941136-getUrl-not-matching-webdriver-command-get.patch
Forgot to update the Python client. There's nothing functionally wrong with the current patch, but I'll upload a new one that covers everything in one go.
Attachment #8362490 -
Flags: review?(dburns)
|
|
Assignee | |
Comment 4•11 years ago
|
||
Uploaded new patch that also updates the Python client.
new try: https://tbpl.mozilla.org/?tree=Try&rev=5c2a5766db49
Attachment #8362490 -
Attachment is obsolete: true
Attachment #8362556 -
Flags: review?(dburns)
|
|
||
Comment 5•11 years ago
|
||
Comment on attachment 8362556 [details] [diff] [review]
0001-Bug-941136-getUrl-not-matching-webdriver-command-get.patch
Review of attachment 8362556 [details] [diff] [review]:
-----------------------------------------------------------------
r+ if you can update the with the comment
::: testing/marionette/marionette-listener.js
@@ +1236,4 @@
> curFrame.location = msg.json.url;
> }
>
> +/** Get URL of the top level browsing context. */
Can we have this multi line again
Attachment #8362556 -
Flags: review?(dburns) → review+
|
|
Assignee | |
Comment 6•11 years ago
|
||
Attachment #8362556 -
Attachment is obsolete: true
Attachment #8362905 -
Flags: review+
|
|
Assignee | |
Updated•11 years ago
|
Keywords: checkin-needed
|
||
Comment 7•11 years ago
|
||
This doesn't apply on top of the other patches you requested checkin on. Please rebase and indicate the proper landing order.
Keywords: checkin-needed
|
|
Assignee | |
Comment 8•11 years ago
|
||
Rebased patch. Please apply this first, then the updated patch from bug 941132.
Attachment #8362905 -
Attachment is obsolete: true
Attachment #8363075 -
Flags: review+
|
|
Assignee | |
Updated•11 years ago
|
Keywords: checkin-needed
|
|
||
Comment 9•11 years ago
|
||
Assignee: nobody → ato
Keywords: checkin-needed
|
|
||
Comment 10•11 years ago
|
||
Something in the push for this, bug 941132, and bug 961792 broke all Marionette-based test suites. Backed out.
https://hg.mozilla.org/integration/mozilla-inbound/rev/80ac99aa1dbf
https://tbpl.mozilla.org/php/getParsedLog.php?id=33345104&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=33345278&tree=Mozilla-Inbound
|
|
Assignee | |
Comment 11•11 years ago
|
||
|
|
Assignee | |
Updated•11 years ago
|
Keywords: checkin-needed
|
|
||
Comment 12•11 years ago
|
||
Keywords: checkin-needed
|
||
Comment 13•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
|
|
Assignee | |
Updated•11 years ago
|
Keywords: checkin-needed
Whiteboard: checking-needed-aurora
|
|
||
Comment 14•11 years ago
|
||
status-firefox28:
--- → fixed
status-firefox29:
--- → fixed
Keywords: checkin-needed
Whiteboard: checking-needed-aurora
|
|
Assignee | |
Updated•10 years ago
|
QA Contact: ato
|
||
Updated•2 years ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•