Closed Bug 941136 Opened 7 years ago Closed 6 years ago
Url not matching webdriver command get Current Url
Marionette uses "getUrl" for getting the current browser window's URL while the expected webdriver command is "getCurrentUrl". This incompatibility makes it harder to use Marionette directly without maintaining a WebDriver-to-Marionette command conversion set.
Raised https://www.w3.org/Bugs/Public/show_bug.cgi?id=24131 as its not currently in the specification
Comment on attachment 8362490 [details] [diff] [review] 0001-Bug-941136-getUrl-not-matching-webdriver-command-get.patch Forgot to update the Python client. There's nothing functionally wrong with the current patch, but I'll upload a new one that covers everything in one go.
Uploaded new patch that also updates the Python client. new try: https://tbpl.mozilla.org/?tree=Try&rev=5c2a5766db49
Comment on attachment 8362556 [details] [diff] [review] 0001-Bug-941136-getUrl-not-matching-webdriver-command-get.patch Review of attachment 8362556 [details] [diff] [review]: ----------------------------------------------------------------- r+ if you can update the with the comment ::: testing/marionette/marionette-listener.js @@ +1236,4 @@ > curFrame.location = msg.json.url; > } > > +/** Get URL of the top level browsing context. */ Can we have this multi line again
Attachment #8362556 - Flags: review?(dburns) → review+
This doesn't apply on top of the other patches you requested checkin on. Please rebase and indicate the proper landing order.
Rebased patch. Please apply this first, then the updated patch from bug 941132.
Assignee: nobody → ato
Something in the push for this, bug 941132, and bug 961792 broke all Marionette-based test suites. Backed out. https://hg.mozilla.org/integration/mozilla-inbound/rev/80ac99aa1dbf https://tbpl.mozilla.org/php/getParsedLog.php?id=33345104&tree=Mozilla-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=33345278&tree=Mozilla-Inbound
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
You need to log in before you can comment on or make changes to this bug.