961792 - Avoid needless iteration when looking up current window ID in Marionette

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Andreas Tolfsen ❲:ato❳]

At testing/marionette/marionette-server.js:1164 the for-each loop used to look up the current window's server-assigned unique identifier continues after the response has been sent.  This is unnecessary and a potential synchronization problem.

Comment 1

[Andreas Tolfsen ❲:ato❳]

Attachment: 0001-Bug-961792-Break-iteration-when-browser-is-found.patch

try: https://tbpl.mozilla.org/?tree=Try&rev=ef2d2e329c7f

Comment 2

[Malini Das [:mdas] - Away, not checking bugmail]

Comment on attachment 8362611 [details] [diff] [review]
0001-Bug-961792-Break-iteration-when-browser-is-found.patch

Review of attachment 8362611 [details] [diff] [review]:
-----------------------------------------------------------------

good catch!

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/301044380886

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Something in the push for this, bug 941132, and bug 941136 broke all Marionette-based test suites. Backed out.
https://hg.mozilla.org/integration/mozilla-inbound/rev/80ac99aa1dbf

https://tbpl.mozilla.org/php/getParsedLog.php?id=33345104&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=33345278&tree=Mozilla-Inbound

Comment 5

[Andreas Tolfsen ❲:ato❳]

It seems the sinning commit is bug 941132:

https://tbpl.mozilla.org/?tree=Try&rev=596c2cbd9f84 <--
https://tbpl.mozilla.org/?tree=Try&rev=723688651c6c
https://tbpl.mozilla.org/?tree=Try&rev=07d800bd841b

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ae45c9201c8b

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ae45c9201c8b