Closed Bug 941173 Opened 12 years ago Closed 12 years ago

[User Story] Browser Chrome: Reload

Categories

(Firefox OS Graveyard :: Gaia::System::Browser Chrome, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::System::Browser Chrome
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(feature-b2g:2.1)

Status:
RESOLVED FIXED
Milestone:
2.1 S2 (15aug)
Project Flags:
feature-b2g 2.1

People

(Reporter: pdol, Assigned: benfrancis)

References

Details

(Whiteboard: [ucid:System123, 1.4:P2][tako][systemsfe], system-browser, [p=2])

Attachments

(2 files)

Screenshot of browser chrome
109.34 KB, image/png
Details
Screenshot of browser chrome with GAIA_DEV_PIXELS_PER_PX=1.5
35.59 KB, image/png
Details
User Story: As a user I want to reload a web page so that I can refresh the page to see the latest version. Acceptance Criteria: Functionality should match existing Browser functionality unless described otherwise in UX spec.
Blocks: browser-chrome-mvp
Component: Gaia::System → Gaia::System::Browser
No longer blocks: browser-chrome-mvp
Blocks: browser-chrome-mvp
Estimating as 2 points.
Whiteboard: [ucid:System123, 1.4:P2, ft:systems-fe], system-browser → [ucid:System123, 1.4:P2, ft:systems-fe], system-browser, [p=2]
Blocks: 1.4-systems-fe
Flags: in-moztrap?(nhirata.bugzilla)
No longer blocks: 1.4-systems-fe
blocking-b2g: --- → backlog
feature-b2g: --- → 2.1
Whiteboard: [ucid:System123, 1.4:P2, ft:systems-fe], system-browser, [p=2] → [ucid:System123, 1.4:P2, ft:systemsfe], system-browser, [p=2]
Assignee: nobody → bfrancis
blocking-b2g: backlog → ---
Whiteboard: [ucid:System123, 1.4:P2, ft:systemsfe], system-browser, [p=2] → [ucid:System123, 1.4:P2][tako][systemsfe], system-browser, [p=2]
Target Milestone: --- → 2.1 S1 (1aug)
Looks like Vivien is working on this in bug 1039519, not much point in it being assigned to me. https://bugzilla.mozilla.org/show_bug.cgi?id=1039519#c22
Assignee: bfrancis → 21
I've gone through the spec and what's implemented and I believe this feature is done now. I'm not sure how we want to handle closing out these user stories. Francis/Peter - do you guys want to do any kind of individual acceptance runs on individual user stories? I'm marking this as fixed for now, but we can re-open if there's more work here that I don't know about.
Status: NEW → RESOLVED
Closed: 12 years ago
Flags: needinfo?(pdolanjski)
Flags: needinfo?(fdjabri)
Resolution: --- → FIXED
The reload button seems to be working as expected, but as mentioned in bug #941172, I'm finding the stop/reload button really hard to target. Only one out of every two or three taps seems to register. What's the tap target size? Eric, could you check the reload button and make sure it's implemented according to the visual spec? Thanks.
Flags: needinfo?(fdjabri) → needinfo?(epang)
(In reply to Francis Djabri [:djabber] from comment #4) > The reload button seems to be working as expected, but as mentioned in bug > #941172, I'm finding the stop/reload button really hard to target. Only one > out of every two or three taps seems to register. What's the tap target size? > > Eric, could you check the reload button and make sure it's implemented > according to the visual spec? Thanks. This doesn't look like it's been implemented to the visual spec. There's also a few other visual items that need to be changed but I'll add a comment to bug 945259 since this is for the reload button. The latest visual spec can be found here: https://mozilla.box.com/s/oedme1y7u6m3s6lxvk0a The icons should be much larger - the spec also includes the hit targets. Image assets can be found here: https://mozilla.box.com/s/xleyd4fnpl5e2gvo2bxr Kevin, please let me know if you have any questions! Thanks!
Flags: needinfo?(epang)
Reopening from Eric's comment.
Status: RESOLVED → REOPENED
Flags: needinfo?(pdolanjski)
Resolution: FIXED → ---
Target Milestone: 2.1 S1 (1aug) → 2.1 S2 (15aug)
Assignee: 21 → nobody
Assignee: nobody → bfrancis
Depends on: 1053416
Eric, can you re-test now that bug 1053416 has landed to increase the size of the reload and stop buttons. Is this to spec now? Thanks
Flags: needinfo?(epang)
Flags: needinfo?(epang) → needinfo?(kgrandon)
Does that mean you want me to verify the UX of this? :) Fwiw it looks good to me. Ben - should we just close this and have product/ux run verification on the closed stories?
Flags: needinfo?(kgrandon)
OK, I think this is ready for acceptance.
Status: REOPENED → RESOLVED
Closed: 12 years ago → 12 years ago
Keywords: verifyme
Resolution: --- → FIXED
Eric asked me to take a look at this as he was having device troubles. The button seems to be the right size, but the icon looks a little blurry to me. Eric, could you take a look at the screen shot and confirm?
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Francis, how are you updating your device? Are you using a nightly build or are you doing make install-gaia? Eric pointed out to me that if you do a make install-gaia manually you need to do "GAIA_DEV_PIXELS_PER_PX=1.5 make install-gaia" in order to get the 1.5x assets for the Flame.
Flags: needinfo?(fdjabri)
Here's a screenshot with GAIA_DEV_PIXELS_PER_PX=1.5
(In reply to Ben Francis [:benfrancis] from comment #13) > Created attachment 8473618 [details] > Screenshot of browser chrome with GAIA_DEV_PIXELS_PER_PX=1.5 > > Here's a screenshot with GAIA_DEV_PIXELS_PER_PX=1.5 Thanks for taking a look for me Francis! I now see it from the nightly build and I think it looks great! Thanks Ben :)
Flags: needinfo?(fdjabri)
OK, marking as RESOLVED FIXED, please re-open if there are any further issues.
Status: REOPENED → RESOLVED
Closed: 12 years ago → 12 years ago
Resolution: --- → FIXED
Keywords: verifyme
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: