Closed Bug 973621 Opened 10 years ago Closed 10 years ago

[Meta] Implement new bottom chrome visuals & options menu

Categories

(Firefox OS Graveyard :: Gaia::System::Browser Chrome, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED INVALID

People

(Reporter: janjongboom, Assigned: janjongboom)

References

Details

Attachments

(3 files)

Meta bug for all features that are implemented in the bottom chrome, including new visuals, and the initial implementation of the options menu.
Blocks: 941173
Blocks: 941174
Blocks: 941180
Blocks: 941181
Blocks: 941270
Attached file Patch
This implements the new visuals, showing/hiding of the bottom part of the chrome. It also adds the options menu, including working options for 'Reload', 'Add to Home Screen' (not implement according to spec, wip in bug 941180), 'Share', and 'Forward'.

Open issues: 
* New window functionality (in bug 941270). The menu button is added in this patch.
* Disabled state for menu items (e.g. forward action) (waiting for UX spec)
* Detection whether an app is launched from homescreen, and disable 'Add to Home Screen' in that case. Probably in bug 941180.
* Hit state of back button (waiting for UX spec)
Assignee: nobody → janjongboom
Comment on attachment 8377156 [details] [review]
Patch

Dale, can you do a preliminary review of this code or dispatch it to Kevin or Ben?
Attachment #8377156 - Flags: review?(dale)
Attachment #8377156 - Flags: review?(dale) → review?(bfrancis)
Comment on attachment 8377156 [details] [review]
Patch

I'm really sorry Jan but we've just had some schedule changes and the new system browser has now been punted to 1.5. In addition to this, Francis has recently finished a new UX spec for "unified chrome" https://mozilla.app.box.com/s/pb7xhx7f2obtcm0dz3no in which we merge the top and bottom bars of the system browser.

In light of this, and the fact that we've now been asked not to land any more features on master until 1.4 branches, I don't think it makes sense to land the the new non-collapsible bottom bar.

I know this might be frustrating, but we're going to be turning off the Rocketbar for 1.4 as well.
Attachment #8377156 - Flags: review?(bfrancis)
Needinfo Peter for confirmation that we should no longer implement the system browser bottom bar UX spec.
Flags: needinfo?(pdolanjski)
Hmpf, that pisses me off quite a bit given that I received updated visuals for this thing just this week.
Jan, I apologize about the churn around this, particularly in the area of System Browser/Rocket bar.

Francis, can you confirm that the latest spec (with the unified chrome) is the one we are moving forward with?
Flags: needinfo?(pdolanjski) → needinfo?(fdjabri)
Peter, I think that the unified chrome is a proposal that I would like to prototype and test. It seems to me to solve a couple of key problems - one being the discoverability of the rocket bar, and another being maximizing the amount of space for single-page websites. If we have the bottom chrome, as discussed in Paris, then there simply is no good way of dismissing it and re-invoking it, unless we somehow merge it with the top chrome. 

So I suggest we go forward with the unified chrome for the purposes of prototyping and testing, but if we discover that it leads to other problems, we should keep the bottom chrome as a back-up solution.
Flags: needinfo?(fdjabri)
Marking this invalid for now as we have a new unified Chrome spec where the bottom bar is merged with the Rocketbar. We can re-open if this plan changes following user testing.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: