941175 - [User Story] [Meta] Browser Chrome: View URL

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Browser Chrome, defect)

Description

[Peter Dolanjski [:pdol]]

User Story:
As a user I want to view the URL of the web page I'm currently on so that I can see which website I am currently viewing.

Acceptance Criteria:
Functionality should match existing Browser functionality unless described otherwise in UX spec.

Comment 1

[Ben Francis [:benfrancis]]

Let's try to start here.

Comment 2

[Ben Francis [:benfrancis]]

Working on a Frankenstein branch off Alive's window manager branch + Dale's Browser2 icon patch, until Alive's new window manager lands.

https://github.com/benfrancis/gaia/tree/system-browser

Comment 3

[Ben Francis [:benfrancis]]

Switched to a new branch on top of the rocketbar feature branch
https://github.com/benfrancis/gaia/tree/941175

Problem is I also need to integrate with Alive's new Window Manager which is currently on the other branch...

Comment 4

[Ben Francis [:benfrancis]]

For a moment I thought this had already been implemented on master. If you type a URL into the Rocketbar it opens a new browser window, then if you open the Rocketbar again it will show the URL of the web page.

But if you try to view the URL in the browser window opened by the Browser2 icon you'll see that it doesn't work. I think that's because the URL shown in the above case is actually what the cards view is reporting as the title of the window.

I'm going to work on a more complete implementation which actually uses locationchange events and keeps track of the current URL as a property of Rocketbar.

Comment 5

[Ben Francis [:benfrancis]]

Attachment: https://github.com/mozilla-b2g/gaia/pull/15687

Comment 6

[Ben Francis [:benfrancis]]

Estimating as 2 points.

Comment 7

[Dale Harvey (:daleharvey)]

Comment on attachment 8365143 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/15687

Implementation looks good, few minor comments but they dot particularly need addressed, however this patch very definitely needs integration tests, those unit tests dont cover much surface area and this type of feature is perfect for testing, will clear review for now

Comment 8

[Ben Francis [:benfrancis]]

Urgh. It looks like this now has merge conflicts with all the Rocketbar patches currently landing on master (without integration tests) in the great "let's land the half-baked prototype Rocketbar in master" initiative over in bug 959353.

I'll look at this tomorrow.

Comment 9

[Ben Francis [:benfrancis]]

OK, I've resolved all the conflicts.

https://github.com/mozilla-b2g/gaia/pull/15687

I'll now look at ramping up integration tests for the Rocketbar inside the system app.

Comment 10

[Ben Francis [:benfrancis]]

Turning this into a meta bug. This never landed because it didn't have r+ but Kevin has now done a part implementation in a dependent bug which we will use instead and track any follow-up work as blocking this user story.

Comment 11

[Dale Harvey (:daleharvey)]

This landed but wasnt closed out

Comment 13

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Test cases for the browser app are being used:

https://moztrap.mozilla.org/manage/case/9276/
https://moztrap.mozilla.org/manage/case/7206/