941215 - E-mail with APZ on lets you pan out and mixes up touch events

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

Description

[Milan Sreckovic [:milan] (needinfo for best results)]

Attachment: Setting device width; without this change, behavior is worse.

Update e-mail app index.html (attached) - see bug 916185.  Turn on APZ from the dev. settings.  Restart the phone.

These problems mostly show up until we've scrolled through all the e-mails the first time.  Somethings gets cached at that point, and it starts behaving better.

1. The panning in the e-mail app flashes a lot.  Feels like we may end up with unpainted areas.

2. Clicking on individual e-mails ends up not working at all, or gets a wrong e-mail.

Comment 2

[Milan Sreckovic [:milan] (needinfo for best results)]

Also, the new account was setup (e.g., the "All done!" page) has "Add another account" and "Continue to Mail" buttons too far down.

Comment 3

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 8335517 [details] [diff] [review]
Setting device width; without this change, behavior is worse.

This looks like something we want / thought we had already, yes?  (The viewport stuff may have been something I cargo-culted from your cards.js stuff / deuxdrop in the first place :)

Comment 4

[Andrew Sutherland [:asuth] (he/him)]

(In reply to Milan Sreckovic [:milan] from comment #2)
> Also, the new account was setup (e.g., the "All done!" page) has "Add
> another account" and "Continue to Mail" buttons too far down.

With the patch or without the patch?  (I saw there was a comment 1 that got redacted that suggested it was with the patch, so I'm guessing that was wrong.)

Also, what device/DPI is this on (and if hi-dpi, was it a hi-dpi build?)

Comment 5

[James Burke [:jrburke]]

Comment on attachment 8335517 [details] [diff] [review]
Setting device width; without this change, behavior is worse.

Review of attachment 8335517 [details] [diff] [review]:
-----------------------------------------------------------------

Good change, added values make sense.

Comment 6

[Milan Sreckovic [:milan] (needinfo for best results)]

This was on unagi, trying on other devices.

Botond, can you check the part where the touch events go to the wrong item and the div is too large so the scroll at the bottom moves the controls?

Comment 7

[Milan Sreckovic [:milan] (needinfo for best results)]

Blocking a blocker for 1.3

Comment 8

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

I wonder if this is a duplicate of bug 942760.

Also please not that I have already landed a big patch that changes all the viewports or add one if it is missing. The content value of the meta may dance a little bit in the coming days, trying to find the exact right value, or just using it to workaround some bugs while they are fixed in the platform.

I have personally no strong opinion about the default values it needs to be and my feeling is that whatever is decided should not slow us down to try to grab as much bugs as possible by playing with the viewport until the platform is ready.

Comment 10

[Botond Ballo [:botond]]

(In reply to Milan Sreckovic [:milan] from comment #6)
> This was on unagi, trying on other devices.
> 
> Botond, can you check the part where the touch events go to the wrong item
> and the div is too large so the scroll at the bottom moves the controls?

Both of these issues are fixed by my patches for bug 942799 and bug 942995.

Comment 11

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Is there anything else to do in this bug ?

Comment 12

[Milan Sreckovic [:milan] (needinfo for best results)]

Not that I can tell.