Build netwerk/dns in unified mode

RESOLVED FIXED in mozilla28

Status

()

Core
Networking
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Michael Shuen, Assigned: Michael Shuen)

Tracking

unspecified
mozilla28
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qa-])

Attachments

(1 attachment, 2 obsolete attachments)

Comment hidden (empty)
(Assignee)

Comment 1

5 years ago
Created attachment 8335794 [details] [diff] [review]
Patch
Attachment #8335794 - Flags: review?(ehsan)

Comment 2

5 years ago
Comment on attachment 8335794 [details] [diff] [review]
Patch

Review of attachment 8335794 [details] [diff] [review]:
-----------------------------------------------------------------

Why are you not unifying the files in SOURCES here?  If you have a good reason you should add that as a comment to the SOURCES variable.  Note that we can unify C files together and C++ files together as well, you can just put them all in UNIFIED_SOURCES and the build system will figure it out.
Attachment #8335794 - Flags: review?(ehsan)
(Assignee)

Comment 3

5 years ago
Oh. I was thinking that there might be more bustage (you tactfully informed me of this at bug 940153 comment 6) due to files with special build flags, bug 939615.

Comment 4

5 years ago
(In reply to comment #3)
> Oh. I was thinking that there might be more bustage (you tactfully informed me
> of this at bug 940153 comment 6) due to files with special build flags, bug
> 939615.

You're right about nsEffectiveTLDService.cpp, but what about the .c files there?  (And note that you should still say why you're exlcuding nsEffectiveTLDService.cpp in the comment.)
(Assignee)

Comment 5

5 years ago
Created attachment 8335842 [details] [diff] [review]
Patch (v2)
Attachment #8335794 - Attachment is obsolete: true
Attachment #8335842 - Flags: review?(ehsan)

Updated

5 years ago
Attachment #8335842 - Flags: review?(ehsan) → review+
(Assignee)

Comment 6

5 years ago
Created attachment 8336476 [details] [diff] [review]
Patch for checkin. r=ehsan
Attachment #8335842 - Attachment is obsolete: true
(Assignee)

Updated

5 years ago
Keywords: checkin-needed

Comment 7

5 years ago
Pushed a follow-up fix for a warnings-as-errors bustage: https://hg.mozilla.org/integration/mozilla-inbound/rev/2d8d46e3e15c
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/b4867e279d3c
https://hg.mozilla.org/mozilla-central/rev/2d8d46e3e15c
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28

Updated

5 years ago
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.