942140 - [Settings] when invoked as an activity, we should have a cross instead of a back button and pressing it should move back to the caller

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Noemí Freire (:noemi)]

Unagi device master 11/22 build:
Gecko: 07ce8fb
Gaia: 68943ea
Build Identifier: 20131122111853
Platform version: 28.0a1

STR:
1. Open messaging app
2. Tap on new message icon or an existing message thread
3. Tap on more options icon "..."
4. Tap on Settings, then Cellular & Data > Message Settings is opened (wrong path, it will be changed in bug 942123)


EXPECTED:
Once in Cellular & Data > Message Settings,
back button should take the user back where they came from and settings changes made won't be applied
OK button should take the user back where they came from and settings changes made will be applied

ACTUAL:
Once in Cellular & Data > Message Settings, neither back button nor OK one are responsive, there is no way to back apart from long tap on home

Comment 1

[Julien Wajsberg [:julienw]]

This is a settings issue that doesn't handle the configure activity correctly.

Flagging Arthur on this :)

Comment 2

[Arthur Chen [:arthurcc][inactive after 6/30]]

It is expected as currently settings app does not support inline activities. :(

Comment 3

[Julien Wajsberg [:julienw]]

Arthur, I disagree with this. Even "window" activities can use a returnValue and call "postResult".

Comment 4

[Arthur Chen [:arthurcc][inactive after 6/30]]

I agree. I Just wanted to point out that it is not a bug but more like a feature request.

Comment 5

[Julien Wajsberg [:julienw]]

Yep, I agree with that :)

Except it really breaks our workflow right now :(

Comment 6

[Julien Wajsberg [:julienw]]

This also impacts the Download Manager feature.

Comment 7

[Francisco Jordano [:arcturus] [:francisco]]

Can try to take a look.

Assigning to myself, if I don't find the cycles tomorrow will return it back.

Comment 8

[Francisco Jordano [:arcturus] [:francisco]]

Attachment: Pointer to PR 14168

Hi Kaze, sending the review:

- Added a new dataset element 'dialog' to the panel in settings opened by the activity.
- Changing the current back icon for a close one.
- When closing an activity coming back to the opener app, and restoring settings status (since it will keep open in the background)

Cheers,
F.

Comment 9

[Fabien Cazenave [:kaze]]

Comment on attachment 8340182 [details] [review]
Pointer to PR 14168

Besides the comments I left on your PR, I’m a bit worried that this patch assumes that all activity panels have to be direct “children” of the main #root panel. Are we sure it will always be true? And that we’re not breaking existing activities?

Comment 10

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8340182 [details] [review]
Pointer to PR 14168

Thanks for the review Kaze,

addressed the comments, new review ready :)

Comment 11

[Francisco Jordano [:arcturus] [:francisco]]

Landed after travis green \o/

https://github.com/mozilla-b2g/gaia/commit/fc2d23dbf2989edd0b8131d00e94b18d5cfb3a1c

Comment 12

[isabelrios]

This bugs has been checked with 12/04 master build:
Gecko-2dc4d2d
Gaia-573304f

And it is ok, but there is a particular scenario related to it for which a new follow up bug has been open, please see: Bug 946250

Comment 13

[Tim Guan-tin Chien [:timdream] (please needinfo)]

This bug reaches v1.3 before branching. Update flags to express the fact (hope I did this correctly).