946250 - Follow up to bug 942140 When settings is invoked from messaging and closed from home button it does not recover its original status

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[isabelrios]

12/04 Master build:
Gecko-2dc4d2d
Gaia-573304f

STR:
1. Open messaging app
2. Tap on new message icon or an existing message thread
3. Tap on more options icon "..."
4. Once Messaging settings screen is open, tap on Home key
5. Messaging app is open without user interaction (this is ok), so tap on Home again
6. Then, open Settings app from main menu

EXPECTED
Settings menu is open in Messaging settings view showing its options and buttons correctly.

ACTUAL
Messaging settings menu is open with the close button ('x') instead of the back button ('<').
If you tap on 'x' to close the menu, you are taken to Settings main menu, tapping again in Messaging Settings will open the menu agian with the 'x' button instead of the back ('<') one.

Comment 1

[Julien Wajsberg [:julienw]]

Isabel, do you know if similar issues exist in the SMS app when, for example, you use the "send sms" button in the contacts app?

Comment 2

[isabelrios]

(In reply to Julien Wajsberg [:julienw] from comment #1)
> Isabel, do you know if similar issues exist in the SMS app when, for
> example, you use the "send sms" button in the contacts app?

Hi Julien,

I did some tests and cannot see something similar.
- Without Messaging app in background: From Contacts tapping on SMS icon the Messaging composer is open with the option to close 'x'. If Messaging app is open and a new Message is created, on the header you see the back button. This happens both closing the Messaging composer by tapping on 'x' or going out by tapping on 'Home' key and then opening Messaging app

But, if -Messaging app is in background:
Tapping on Messaging icon from contacts, the Messaging app is open in the inbox view, not in the composer one. This looks like a regression, if there is not a bug about it, will file a new one.

Comment 3

[Julien Wajsberg [:julienw]]

Thanks! Yes please file this bug :)

Comment 4

[isabelrios]

Done! Bug 946678
Thanks

Comment 5

[Tim Guan-tin Chien [:timdream] (please needinfo)]

(In reply to Isabel Rios [:isabel_rios] from comment #0)
> ACTUAL
> Messaging settings menu is open with the close button ('x') instead of the
> back button ('<').
> If you tap on 'x' to close the menu, you are taken to Settings main menu,
> tapping again in Messaging Settings will open the menu agian with the 'x'
> button instead of the back ('<') one.

Triage: severe user confusion based on comment above.

Comment 6

[Francisco Jordano [:arcturus] [:francisco]]

Attachment: Pointer to PR 14461

Comment 7

[Francisco Jordano [:arcturus] [:francisco]]

Landed:

https://github.com/mozilla-b2g/gaia/commit/9ef1819d2b5b3d0db48538b6b4b8a0af0440a3c2

Comment 8

[Francisco Jordano [:arcturus] [:francisco]]

Despite of being 1.3, this bug didn't make it to 1.3 branch, since the tree was closed (being the patch ready).

Noemi, what flags should we use to try to uplift to 1.3?

Comment 9

[Noemí Freire (:noemi)]

(In reply to Francisco Jordano [:arcturus] from comment #8)
> Despite of being 1.3, this bug didn't make it to 1.3 branch, since the tree
> was closed (being the patch ready).
> 
> Noemi, what flags should we use to try to uplift to 1.3?

Since this bug is a 1.3+ one, there shouldn't be any problem on uplifting it to v1.3 branch, it seems the specific v1.3 status flag has not been created yet ("status-b2g-v1.3") so we can't mark v1.3 as "affected". ni to John Ford, in case he can help us with the uplift to v1.3 branch. Thanks!

Comment 10

[Julien Wajsberg [:julienw]]

Anyway, the "affected" value does not help uplifting at all. Only the "1.3+" flag and the fact that the "status" flag is not to "fixed". I think we use "status-firefox28" flag for v1.3.

NI John Ford works fine too ;)

Comment 11

[Fabien Cazenave [:kaze]]

Comment on attachment 8343730 [details] [review]
Pointer to PR 14461

Post-mortem r+.

Comment 13

[Tim Guan-tin Chien [:timdream] (please needinfo)]

We must land this patch to v1.3. This is a regression of bug 942140.

Comment 14

[John Ford [:jhford] CET/CEST Berlin Time]

[v1.3 16a9b1a] Merge pull request #14461 from arcturus/bug-946250