942680 - Regression: Google Search engine and search suggestions opt-in hidden behind urlbar

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Awesomescreen, defect)

Description

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

Attachment: screenshot-1

# environment
* http://hg.mozilla.org/mozilla-central/rev/74ab61b8d0f0
* Nexus 5

# Summary
* See screenshots.

* On the awesome screen, search results are buried in locationbar.
  * see the screenshot-1
  * This is always reproducible.

* Viewport margin-top is broken. The margin-top is sometimes too wide.
  * see the screenshot-2
  * This is sometimes reproducible if we set "browser.chrome.dynamictoolbar=false".

Comment 1

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

Attachment: screenshot-2

Comment 2

[Aaron Train [:aaronmt]]

Do you have steps to reproduce? I too have a Nexus 5, but am not not seeing any issues with the margins in Google as the case is in your second screenshot.

Comment 3

[Aaron Train [:aaronmt]]

Needed search suggestions my mistake. Yes, I see this on my Galaxy S4 as well.

Comment 4

[Aaron Train [:aaronmt]]

Regression from bug 768667? This also pushes the opt-in search suggestion prompt off the screen on first-run.

Comment 5

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

These appear to be two separate issues, both reproducible on my Galaxy Nexus. I'm changing this issue to resolve the issue in screenshot-1 (search results are hidden behind the url bar) and filed bug 943083 for screenshot-2 (margin at the top of the page with dynamic toolbar disabled).

And to be clear:

> Needed search suggestions my mistake. Yes, I see this on my Galaxy S4 as well.

Relevant to this bug.

> Regression from bug 768667?

Unlikely since (I believe) this uses a different code path. Likely relevant to bug 943083, however.

Comment 6

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8337507 [details]
screenshot-2

Linked from bug 943083.

Comment 8

[u421692]

fx-team regression window:
1384887369 Good
1384891229 Bad

http://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=5f45833d636c&tochange=26df3bab1ab9

Comment 9

[Paul [pwd]]

While bug 743644 is undoubtedly a separate issue, perhaps it should be duped over to this one?

Comment 10

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

(In reply to Paul [sabret00the] from comment #9)
> While bug 743644 is undoubtedly a separate issue, perhaps it should be duped
> over to this one?

It's similarity. But I think this bug is caused by the near changeset.

Comment 12

[Wesley Johnston (:wesj)]

Attachment: Patch

I thought I uploaded this :( Its probably in a different bug

Comment 13

[Lucas Rocha (:lucasr)]

Comment on attachment 8342482 [details] [diff] [review]
Patch

You've uploaded this to bug 943083. I've reviewed it there :-)

Comment 14

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/integration/fx-team/rev/4d64a37dac18

Comment 15

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4d64a37dac18