942780 - B2G MMS : misuse of MMS.Address.resolveType, causing failure of updating delivery/read reports

Status: RESOLVED FIXED

(Firefox OS Graveyard :: RIL, defect)

Description

[Vicamo Yang [:vicamo][:vyang]]

+++ This bug was initially created as a clone of Bug #934931 +++

|MMS.Address.resolveType()| actually returns a string, not a js object |{type: foo, address: bar}|.

Comment 1

[Vicamo Yang [:vicamo][:vyang]]

Depends on bug 940884 so that we can have patches for it.

Comment 2

[Vicamo Yang [:vicamo][:vyang]]

s/patches/test cases/

Comment 3

[Gene Lian (I already quit Mozilla)]

Does this cause any regression or bad side-effects?

Comment 4

[Gene Lian (I already quit Mozilla)]

MMS delivery report is committed feature, we need to move fast. I'd suggest we can carry on without fixing the bug 940884 first.

Btw, because both .type are undefined, so it's somehow working...

  if (typedAddress.type !== typedStoredAddress.type) {
    // Not even my type.  Skip.
    continue;
  }

Comment 5

[Vicamo Yang [:vicamo][:vyang]]

Attachment: patch

Comment 6

[Gene Lian (I already quit Mozilla)]

Comment on attachment 8338367 [details] [diff] [review]
patch

Review of attachment 8338367 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you!

Comment 7

[Vicamo Yang [:vicamo][:vyang]]

Per comment 4, move test cases to bug 943263 instead.

Comment 8

[Vicamo Yang [:vicamo][:vyang]]

https://hg.mozilla.org/integration/b2g-inbound/rev/f66d18acab45

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/f66d18acab45