943275 - Intermittent TEST-UNEXPECTED-FAIL | test_conference.js | ScriptTimeoutException: timed out

Status: RESOLVED FIXED

(Testing :: Marionette Client and Harness, defect)

Description

[Carsten Book [:Tomcat]]

b2g_emulator_vm b2g-inbound opt test marionette-webapi on 2013-11-25 18:15:16 PST for push 353d97cdf854

slave: tst-linux64-ec2-375

https://tbpl.mozilla.org/php/getParsedLog.php?id=31070474&tree=B2g-Inbound


raise ScriptTimeoutException(message=message, status=status, stacktrace=stacktrace)
TEST-UNEXPECTED-FAIL | test_conference.js | ScriptTimeoutException: timed out

Comment 1

[Legacy TBPL/Treeherder Robot]

philor
https://tbpl.mozilla.org/php/getParsedLog.php?id=31136041&tree=Mozilla-Inbound
b2g_emulator_vm mozilla-inbound opt test marionette-webapi on 2013-11-26 20:04:22
revision: 3964ce61dacf
slave: tst-linux64-spot-056

raise ScriptTimeoutException(message=message, status=status, stacktrace=stacktrace)
TEST-UNEXPECTED-FAIL | test_conference.js | ScriptTimeoutException: timed out
Return code: 2560
Marionette exited with return code 2560: harness failures
# TBPL FAILURE #

Comment 2

[Legacy TBPL/Treeherder Robot]

KWierso
https://tbpl.mozilla.org/php/getParsedLog.php?id=31193012&tree=Mozilla-Inbound
b2g_emulator_vm mozilla-inbound opt test marionette-webapi on 2013-11-27 16:44:22
revision: cefc32f6979f
slave: tst-linux64-ec2-467

raise ScriptTimeoutException(message=message, status=status, stacktrace=stacktrace)
TEST-UNEXPECTED-FAIL | test_outgoing_emergency_in_airplane_mode.js | ScriptTimeoutException: timed out
raise ScriptTimeoutException(message=message, status=status, stacktrace=stacktrace)
TEST-UNEXPECTED-FAIL | test_emergency_label.js | ScriptTimeoutException: timed out
raise ScriptTimeoutException(message=message, status=status, stacktrace=stacktrace)
TEST-UNEXPECTED-FAIL | test_conference.js | ScriptTimeoutException: timed out
Return code: 2560
Marionette exited with return code 2560: harness failures
# TBPL FAILURE #

Comment 3

[Legacy TBPL/Treeherder Robot]

philor
https://tbpl.mozilla.org/php/getParsedLog.php?id=31636590&tree=Mozilla-Inbound
b2g_emulator_vm mozilla-inbound opt test marionette-webapi on 2013-12-07 18:12:49
revision: 3c63decb4e7e
slave: tst-linux64-ec2-044

raise ScriptTimeoutException(message=message, status=status, stacktrace=stacktrace)
TEST-UNEXPECTED-FAIL | test_conference.js | ScriptTimeoutException: timed out
Return code: 2560
Marionette exited with return code 2560: harness failures
# TBPL FAILURE #

Comment 4

[Legacy TBPL/Treeherder Robot]

philor
https://tbpl.mozilla.org/php/getParsedLog.php?id=31700034&tree=Mozilla-Central
b2g_emulator_vm mozilla-central opt test marionette-webapi on 2013-12-09 12:57:54
revision: a79294ed7ebe
slave: tst-linux64-ec2-179

raise ScriptTimeoutException(message=message, status=status, stacktrace=stacktrace)
TEST-UNEXPECTED-FAIL | test_conference.js | ScriptTimeoutException: timed out
Return code: 2560
Marionette exited with return code 2560: harness failures
# TBPL FAILURE #

Comment 5

[Legacy TBPL/Treeherder Robot]

KWierso
https://tbpl.mozilla.org/php/getParsedLog.php?id=31707742&tree=B2g-Inbound
b2g_emulator_vm b2g-inbound opt test marionette-webapi on 2013-12-09 15:27:11
revision: 25fd60694d45
slave: tst-linux64-spot-312

raise ScriptTimeoutException(message=message, status=status, stacktrace=stacktrace)
TEST-UNEXPECTED-FAIL | test_conference.js | ScriptTimeoutException: timed out
TEST-UNEXPECTED-FAIL | test_call_mute.js | MarionetteException: Emulator callback still pending when finish() called
Return code: 2560
Marionette exited with return code 2560: harness failures
# TBPL FAILURE #

Comment 6

[Legacy TBPL/Treeherder Robot]

philor
https://tbpl.mozilla.org/php/getParsedLog.php?id=32703236&tree=Mozilla-Aurora
b2g_emulator_vm mozilla-aurora opt test marionette-webapi on 2014-01-08 08:02:20
revision: 805bb36dbeee
slave: tst-linux64-ec2-383

raise ScriptTimeoutException(message=message, status=status, stacktrace=stacktrace)
TEST-UNEXPECTED-FAIL | test_conference.js | ScriptTimeoutException: timed out
Return code: 2560
Marionette exited with return code 2560: harness failures
# TBPL FAILURE #

Comment 7

[Legacy TBPL/Treeherder Robot]

KWierso
https://tbpl.mozilla.org/php/getParsedLog.php?id=33199196&tree=Fx-Team
b2g_emulator_vm fx-team opt test marionette-webapi on 2014-01-17 15:50:15
revision: 60395c47c63b
slave: tst-linux64-ec2-009

raise ScriptTimeoutException(message=message, status=status, stacktrace=stacktrace)
TEST-UNEXPECTED-FAIL | test_conference.js | ScriptTimeoutException: timed out
TEST-UNEXPECTED-FAIL | test_call_mute.js | MarionetteException: Emulator callback still pending when finish() called
Return code: 10

Comment 8

[Legacy TBPL/Treeherder Robot]

philor
https://tbpl.mozilla.org/php/getParsedLog.php?id=33252431&tree=Mozilla-Inbound
b2g_emulator_vm mozilla-inbound opt test marionette-webapi on 2014-01-19 12:02:25
revision: 7a92abc01bd9
slave: tst-linux64-spot-413

raise ScriptTimeoutException(message=message, status=status, stacktrace=stacktrace)
TEST-UNEXPECTED-FAIL | test_conference.js | ScriptTimeoutException: timed out
raise ScriptTimeoutException(message=message, status=status, stacktrace=stacktrace)
TEST-UNEXPECTED-FAIL | test_audiomanager_phonestate.js | ScriptTimeoutException: timed out
Return code: 10
01-19 15:17:34.130    45    45 I Gecko   : MARIONETTE TEST RESULT:TEST-UNEXPECTED-FAIL | test_conference.js | telephony.active - got null, expected [object XrayWrapper [object TelephonyCall]]
01-19 15:17:34.130    45    45 I Gecko   : MARIONETTE TEST RESULT:TEST-UNEXPECTED-FAIL | test_conference.js | telephony.calls - got 0, expected 1
01-19 15:17:34.130    45    45 I Gecko   : MARIONETTE TEST RESULT:TEST-UNEXPECTED-FAIL | test_conference.js | undefined - got undefined, expected [object XrayWrapper [object TelephonyCall]]
01-19 15:17:38.070    45    45 I Gecko   : MARIONETTE TEST RESULT:TEST-UNEXPECTED-FAIL | test_conference.js | undefined - false was false, expected true
01-19 15:17:38.110    45    45 I Gecko   : MARIONETTE TEST RESULT:TEST-UNEXPECTED-FAIL | test_conference.js | telephony.active - got null, expected [object XrayWrapper [object TelephonyCall]]
01-19 15:17:38.110    45    45 I Gecko   : MARIONETTE TEST RESULT:TEST-UNEXPECTED-FAIL | test_conference.js | undefined - got [object XrayWrapper [object TelephonyCall]], expected [object XrayWrapper [object TelephonyCall]]

Comment 9

[Hsin-Yi Tsai (she/her) [:hsinyi]]

There's a flaw in test_conference.js. 

When there's already a connected conference call, answering a new incoming call triggers conference state change. We should wait for |conference.onstatechange| before checking the state of the conference call. However, the current code doesn't do that.

Comment 10

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Attachment: patch v1 - wait for conference.statechange event before checking it's state

Comment 11

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Comment on attachment 8367759 [details] [diff] [review]
patch v1 - wait for conference.statechange event before checking it's state

There's a flaw in test_conference.js. 

When there's already a connected conference call, answering a new incoming call triggers conference state change. We should wait for |conference.onstatechange| before checking the state of the conference call. However, the current code doesn't do that.

Hi Aknow, may I have your review on this? Thanks.

Comment 12

[Szu-Yu Chen [:aknow] (inactive)]

Comment on attachment 8367759 [details] [diff] [review]
patch v1 - wait for conference.statechange event before checking it's state

Review of attachment 8367759 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/telephony/test/marionette/test_conference.js
@@ +132,5 @@
> +  };
> +  let receive = function(name) {
> +    receivedPending(name, pending, done);
> +  };
> +  let pending = ["call.onconnecting", "call.onconnected"];

In other functions, we usually put 'pending' part above 'receive' part.

@@ +151,5 @@
>    call.onconnecting = function onconnectingIn(event) {
>      log("Received 'connecting' call event for incoming call.");
>      call.onconnecting = null;
>      checkEventCallState(event, call, "connecting");
> +    receive("call.onconnecting");

In my opinion, the items in 'pending' should be parallel. But for 'connecting' and 'connected', there is a strong order. Maybe we could remove "call.onconnecting".

Comment 13

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to Szu-Yu Chen [:aknow] from comment #12)
> Comment on attachment 8367759 [details] [diff] [review]
> patch v1 - wait for conference.statechange event before checking it's state
> 
> Review of attachment 8367759 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: dom/telephony/test/marionette/test_conference.js
> @@ +132,5 @@
> > +  };
> > +  let receive = function(name) {
> > +    receivedPending(name, pending, done);
> > +  };
> > +  let pending = ["call.onconnecting", "call.onconnected"];
> 
> In other functions, we usually put 'pending' part above 'receive' part.
> 
> @@ +151,5 @@
> >    call.onconnecting = function onconnectingIn(event) {
> >      log("Received 'connecting' call event for incoming call.");
> >      call.onconnecting = null;
> >      checkEventCallState(event, call, "connecting");
> > +    receive("call.onconnecting");
> 
> In my opinion, the items in 'pending' should be parallel. But for
> 'connecting' and 'connected', there is a strong order. Maybe we could remove
> "call.onconnecting".

Thanks for the review.
I'll address the comments in the final version, thank you~

Comment 14

[Hsin-Yi Tsai (she/her) [:hsinyi]]

https://tbpl.mozilla.org/?tree=Try&rev=62a9af3cbc4f try green. Ready to push.

Comment 15

[Hsin-Yi Tsai (she/her) [:hsinyi]]

https://hg.mozilla.org/integration/b2g-inbound/rev/ef68842735e8

Comment 17

[Legacy TBPL/Treeherder Robot]

KWierso
https://tbpl.mozilla.org/php/getParsedLog.php?id=34257391&tree=Mozilla-Inbound
b2g_emulator_vm mozilla-inbound opt test marionette-webapi on 2014-02-06 19:10:45
revision: 37795f73f9c7
slave: tst-linux64-spot-181

AssertionError: 1 tests failed:
TEST-UNEXPECTED-FAIL | test_conference.js | got connected, expected held | conference.state
Return code: 10
02-07 03:28:22.393    45    45 I Gecko   : MARIONETTE TEST RESULT:TEST-UNEXPECTED-FAIL | test_conference.js | conference.state - got connected, expected held

Comment 18

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ef68842735e8

Comment 19

[(PTO June 19-July 7) Ryan VanderMeulen]

https://hg.mozilla.org/releases/mozilla-aurora/rev/4eddc2978e86
https://hg.mozilla.org/releases/mozilla-beta/rev/8d553f0b4a8b

Comment 20

[(PTO June 19-July 7) Ryan VanderMeulen]

https://hg.mozilla.org/releases/mozilla-b2g28_v1_3/rev/8d553f0b4a8b

Comment 21

[Legacy TBPL/Treeherder Robot]

KWierso
https://tbpl.mozilla.org/php/getParsedLog.php?id=36528993&tree=Mozilla-Aurora
b2g_emulator_vm mozilla-aurora opt test marionette-webapi on 2014-03-21 15:43:55
revision: 853ae686dc4d
slave: tst-linux64-spot-786

raise ScriptTimeoutException(message=message, status=status, stacktrace=stacktrace)
ScriptTimeoutException: ScriptTimeoutException: timed out
TEST-UNEXPECTED-FAIL | test_conference.js |
TEST-UNEXPECTED-FAIL | test_call_mute.js |
Return code: 10

Comment 22

[Legacy TBPL/Treeherder Robot]

RyanVM
https://tbpl.mozilla.org/php/getParsedLog.php?id=38192898&tree=B2g-Inbound
b2g_emulator_vm b2g-inbound opt test marionette-webapi on 2014-04-21 09:46:30
revision: aa586a291995
slave: tst-linux64-spot-182

raise ScriptTimeoutException(message=message, status=status, stacktrace=stacktrace)
ScriptTimeoutException: ScriptTimeoutException: timed out
TEST-UNEXPECTED-FAIL | test_conference_two_hold_resume.js |
TEST-UNEXPECTED-FAIL | test_conference_two_remove_one.js |
Return code: 10

Comment 23

[Legacy TBPL/Treeherder Robot]

RyanVM
https://tbpl.mozilla.org/php/getParsedLog.php?id=41623086&tree=Mozilla-B2g30-v1.4
b2g_emulator_vm mozilla-b2g30_v1_4 opt test marionette-webapi on 2014-06-12 12:11:33
revision: 4d866dff4c18
slave: tst-linux64-spot-211

TEST-UNEXPECTED-FAIL | test_conference.js | ScriptTimeoutException: ScriptTimeoutException: timed out
raise Exception('bad telnet response: %s' % line)
TEST-UNEXPECTED-FAIL | test_call_mute.js | Exception: bad telnet response: KO: could not cancel this number
Return code: 10

Comment 24

[Legacy TBPL/Treeherder Robot]

edmorley
https://tbpl.mozilla.org/php/getParsedLog.php?id=41953519&tree=Mozilla-B2g28-v1.3
b2g_emulator_vm mozilla-b2g28_v1_3 opt test marionette-webapi on 2014-06-18 04:01:43
revision: b1a1c8c5d440
slave: tst-linux64-spot-458

TEST-UNEXPECTED-FAIL | test_conference.js | ScriptTimeoutException: ScriptTimeoutException: timed out
Exception TypeError: TypeError("'NoneType' object is not callable",) in <bound method MarionetteTestRunner.cleanup of <__main__.MarionetteTestRunner object at 0x27df6d0>> ignored
Exception TypeError: TypeError("'NoneType' object is not callable",) in <bound method MozHttpd.stop of <mozhttpd.mozhttpd.MozHttpd object at 0x2829050>> ignored
Return code: 10

Comment 25

[Legacy TBPL/Treeherder Robot]

RyanVM
https://tbpl.mozilla.org/php/getParsedLog.php?id=42931815&tree=Mozilla-B2g28-v1.3
b2g_emulator_vm mozilla-b2g28_v1_3 opt test marionette-webapi on 2014-07-02 03:53:20
revision: e1f405094f41
slave: tst-linux64-spot-071

TEST-UNEXPECTED-FAIL | test_conference.js | ScriptTimeoutException: ScriptTimeoutException: timed out
TEST-UNEXPECTED-FAIL | test_call_mute.js | MarionetteException: MarionetteException: Emulator callback still pending when finish() called
Exception TypeError: TypeError("'NoneType' object is not callable",) in <bound method MarionetteTestRunner.cleanup of <__main__.MarionetteTestRunner object at 0x15e06d0>> ignored
Exception TypeError: TypeError("'NoneType' object is not callable",) in <bound method MozHttpd.stop of <mozhttpd.mozhttpd.MozHttpd object at 0x1628050>> ignored
Return code: 10

Comment 26

[Legacy TBPL/Treeherder Robot]

RyanVM
https://tbpl.mozilla.org/php/getParsedLog.php?id=47792859&tree=Mozilla-B2g30-v1.4
b2g_emulator_vm mozilla-b2g30_v1_4 opt test marionette-webapi on 2014-09-10 08:44:05
revision: 39c9dbc311f7
slave: tst-linux64-spot-1290

TEST-UNEXPECTED-FAIL | test_conference.js | ScriptTimeoutException: ScriptTimeoutException: timed out
TEST-UNEXPECTED-FAIL | test_call_mute.js | MarionetteException: MarionetteException: Emulator callback still pending when finish() called
Return code: 10

Comment 27

[BMO Automation]

Moving bug to Testing::Marionette Client and Harness component per bug 1815831.