943750 - [fugu][hamachi]Music app will not show files in pick mode if device is shared using USB and then unplugged

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Music, defect)

Description

[cheng.luo]

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/535.19 (KHTML, like Gecko) Ubuntu/11.04 Chromium/18.0.1025.168 Chrome/18.0.1025.168 Safari/535.19

Steps to reproduce:

bug 899866 is ok now.But I found the other steps could reproduce it on v1.2.
Reproduce Steps:
1、Connect to PC with SD storage share using USB enabled;
2、press “homescreen” to IDLE, press "message" icon,launch message app;
3、"new message" --> "add attachment",select "music" type,prompt "Unplug the phone to play music";
4、Unplug USB;


Actual results:

the music list is empty; 


Expected results:

Songs(or list) can be displayed.

Comment 1

[Danny Liang [:dliang]]

This bug can be reproduced by follow the reporduse steps 1~4, but it can be easily recovered by re-selected "music" after step 4.
The state of SD card should be right but music app might not refresh list of songs after unplug USB cable.

Comment 2

[Dominic Kuo [:dkuo]]

I can also reproduce this and looks like music app did not handle well in the picker mode, taking this.

Comment 3

[Steven Yang [:styang]]

After discussed with our partner, it will not block fugu.

Comment 4

[Peipei Cheng (needinfo if you need my action)]

This is still reproducible on following build:
Buri V1.3
Gaia      522779225e86b7a4d1bf759036678dc321a1486e                         
Gecko     http://hg.mozilla.org/releases/mozilla-aurora/rev/2287f2839256   
BuildID   20140108004001                                                   
Version   28.0a2                                                           
ro.build.version.incremental=eng.archermind.20131114.105818                
ro.build.date=Thu Nov 14 10:58:33 CST 2013

Comment 5

[Preeti Raghunath(:Preeti)]

QA

Please help with regression window.

Comment 6

[Sarah Parsons]

This issue reproduces on all 1.2 builds starting at the Buri 1.2 Build ID: 20130621031231

Gaia   e2f19420fa6a26c4287588701efaec09a750dba1
SourceStamp 7ba8c86f1a56
BuildID 20130621031231
Version 24.0a1


I was not able to repro this issue on 1.1.

Comment 7

[Jean Gong :jgong]

PM triaged this bug and believes that it should be a blocker.

Comment 8

[Hema Koka [:hema]]

Dominic, please provide an update on this fix.

Comment 9

[Jim Porter (:squib)]

I could take this, since Dominic looks like he's pretty busy with other bugs.

Comment 10

[Jim Porter (:squib)]

Taking this per discussion with Hema. Sorry if I'm stepping on your toes, Dominic!

Comment 11

[Dominic Kuo [:dkuo]]

No problem Jim, thanks for taking this cause my plate is kind of full, feel free to ping me if you need any info from me!

Comment 12

[Jim Porter (:squib)]

Ok, I'm pretty sure bug 911108 regressed this. Updating deps. Patch forthcoming momentarily.

Comment 13

[Jim Porter (:squib)]

Attachment: Fix it

Ok, this should fix it. No tests because we have no integration test infrastructure for music yet. :(

Comment 14

[Dominic Kuo [:dkuo]]

Comment on attachment 8364825 [details] [review]
Fix it

Thanks Jim, the patch looks good to me and it did fixed the issue!

Comment 15

[Jim Porter (:squib)]

Landed: https://github.com/mozilla-b2g/gaia/commit/79346c6ad8d29c1aa338845f9e56466364c33343

Comment 16

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 79346c6ad8d29c1aa338845f9e56466364c33343 to:
v1.3: 4dd113626f8ffd2206e6e9d6adbb08ab0580572a