944235 - Modify the CostControl app of gaiatest

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Askeing Yen[:askeing][:fyen]]

The Bug 937244 added three buttons to delete data usages of Wifi/Mobile.

ref: https://github.com/mozilla-b2g/gaia/commit/f20aee1acb1bc3612bd42330c25f03f9c5a5d4bd#diff-436d80a6049b12e0a07272f67afd2ab4

Comment 1

[Askeing Yen[:askeing][:fyen]]

Attachment: PR 14158

Comment 2

[Zac C (:zac)]

Comment on attachment 8339714 [details] [review]
PR 14158

r- , can you remove the unused locators?

we don't want them to rot.

Comment 3

[Askeing Yen[:askeing][:fyen]]

Comment on attachment 8339714 [details] [review]
PR 14158

Updated the commit

Comment 4

[Zac C (:zac)]

Comment on attachment 8339714 [details] [review]
PR 14158

Hey Askeing this test is now behaving OK, it is reaching the end assertion OK, but there seems to be a problem with the app itself.

It is not resetting the data properly. You can see it just using it manually, tap reset from the Settings menu and it does not reset.

The screen with the graph does not update when more wifi is used either.

Can you investigate this further? I've run out of time for the day.

Change the xfail for the test if you find a new bug, too.

Comment 5

[Askeing Yen[:askeing][:fyen]]

(In reply to Zac C (:zac) from comment #4)
> Comment on attachment 8339714 [details] [review]
> PR 14158
> 
> Hey Askeing this test is now behaving OK, it is reaching the end assertion
> OK, but there seems to be a problem with the app itself.
> It is not resetting the data properly. You can see it just using it
> manually, tap reset from the Settings menu and it does not reset.
> The screen with the graph does not update when more wifi is used either.
> Can you investigate this further? I've run out of time for the day.
> Change the xfail for the test if you find a new bug, too.

You are right, there are two root causes of cost_control_rest_wifi.
1st is UI change, so I file this bug.
2nd is data doesn't update after tap reset wifi usage, so I file Bug 944243 for this problem.

Comment 6

[Askeing Yen[:askeing][:fyen]]

Update: Bug 944234 is dup of Bug 944008.

Comment 7

[Askeing Yen[:askeing][:fyen]]

(In reply to Askeing Yen[:askeing] from comment #6)
> Update: Bug 944234 is dup of Bug 944008.
typo: s/944234/944243/g

Submit the new Bug 944458 to change the xfail.
And set Bug 944008 as blocker

Comment 8

[Zac C (:zac)]

Merged
https://github.com/mozilla-b2g/gaia/commit/1d14eb7c8b866c7d086c2952208734b8587825bc

Comment 9

[Zac C (:zac)]

Thanks Askeing, I merged it so that it can start passing when the bug 944008 is resolved!

Comment 10

[Askeing Yen[:askeing][:fyen]]

(In reply to Zac C (:zac) from comment #9)
> Thanks Askeing, I merged it so that it can start passing when the bug 944008
> is resolved!
Thanks Zac :)