944436 - Re-enable set alarm time coverage in test_clock_create_new_alarm.py when Bug 946130 is fixed

Status: RESOLVED DUPLICATE of bug 968741

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Zac C (:zac)]

We hadn't realised it but this test can actually be re-enabled.

A lot of locators and scroll/flick have rot and need some serious updating.

Comment 1

[Viorela Ioia [:viorela]]

I've been working on this bug for some hours and I believe we shouldn't enable this test. I updated the locators till I got to the step where I have to modify the time (select hour, minute, AM/PM). The update process got really complicated on that step, because we can't use the _current_element method, which returns the selected values of hours, minutes and AM/PM. As we can't use that method, we won't be able to use spin_hour(), spin_seconds() and spin_hour24() either. I tried to use Action chain with flick to change the selected values, but it doesn't work, not even for spin_hour24() method. I couldn't realise what should we use instead of those methods. 
I will unassign myself, in case someone else has a good idea of how to modify the test and update the locators. Thanks! :)

Comment 2

[Zac C (:zac)]

This looks like a Marionette bug now.

The action chain should work on those elements, no doubt.

Viorela, can you create a reduced test case and file a bug against Marionette?

Comment 3

[Viorela Ioia [:viorela]]

Sure, Zac.

Comment 4

[Florin Strugariu [:Bebe]]

I can give this a try

Comment 5

[Florin Strugariu [:Bebe]]

Yep no luck 
I tried every trick I know....

For the future make a TimePicker class in the system app so we can work with those elements more easy

Comment 6

[[:AndreiH]]

Since alarm tests were merged the new code is in test_clock_create_new_alarm.py and it needs to be uncommented when Bug 946130 is fixed.

https://github.com/mozilla-b2g/gaia/blob/master/tests/python/gaia-ui-tests/gaiatest/tests/functional/clock/test_clock_create_new_alarm.py#L55

Comment 7

[Viorela Ioia [:viorela]]

Changes for re-enabling set alarm time coverage will be done in Bug 968741