968741 - Update test_create_new_alarm to wait for the alarm to trigger

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect, P2)

Description

[Zac C (:zac)]

This may be difficult or not worth it but let's try anyway..

To create parity with the manual smoke tests, update test_create_new_alarm.py to wait for the alarm to trigger.

After creating the alarm, kill the Clock app and wait for the alarm alert.

Update the test's name to suit.

Be very wary of any race condition between the trigger time of the alarm and the current time passing (which might mean the alarm would not trigger for 23hr 59 minutes). 

If you run into problems that mean the test code is too difficult,fragile or causes the test to take too long to run then please push back on this task.

This may be blocked by:
https://bugzilla.mozilla.org/show_bug.cgi?id=946130

Similarly using actions might be slow or unreliable so investigate other ways to set the alarm's time if need be.

Comment 1

[Viorela Ioia [:viorela]]

I've been investigating this bug and I have an idea. As we can't change the alarm time, I thought that we might change the time on the device.
After we set the alarm, we set the device time to be some seconds less than the current time. We can do that by using the set_time method from data_layer. Then we open Clock app, we disable the alarm and re-enable it. That way we will get the message that our alarm is set for less than a minute. 
The next step would be to close the Clock app and wait for the alarm to be triggered.
I'm not sure if this is a good way of modifying the test, as we need to add some extra steps.   
What do you think, Zac?

Comment 2

[Zac C (:zac)]

Good thinking Viorela. It sounds like you'll need to be very careful with the timing. Possibly turn off nitz (automatic time update) during the setUp and then some very thorough intermittent testing!

Can you do a proof of concept and make sure it works on both desktopb2g and device? If it doesn't work on desktopb2g it might be a blocker.

Comment 3

[Viorela Ioia [:viorela]]

Attachment: Github Pr: https://github.com/mozilla-b2g/gaia/pull/16826

Comment 5

[Zac C (:zac)]

Comment on attachment 8420953 [details] [review]
Github Pr: https://github.com/mozilla-b2g/gaia/pull/16826

r-, some changes to make

Comment 6

[Zac C (:zac)]

Viorela, can you try work on this again?

Comment 7

[Viorela Ioia [:viorela]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23036/files

I updated the test, but it will fail at the end, because we still blocked by Bug 947317

Comment 8

[Florin Strugariu [:Bebe]]

Comment on attachment 8475122 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23036/files

The code looks good but I have some concerns

Comment 9

[Zac C (:zac)]

Comment on attachment 8475122 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23036/files

I didn't run it so only f-, but I tihnk we should be sure we're setting the minutes reliably.

Comment 10

[Florin Strugariu [:Bebe]]

Viorela any updates on this issue?

Comment 11

[Viorela Ioia [:viorela]]

The PR is updated, but the test will fail at the end, because of Bug 947317. After closing the alarm frame, no code is executed.

Comment 12

[Viorela Ioia [:viorela]]

Comment on attachment 8475122 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23036/files

I updated the PR. The test is working as expected on device, but it is skipped on desktopb2g, as we cannot set the time.

I started an adhoc here: http://jenkins1.qa.scl3.mozilla.com/job/flame-kk.ui.adhoc/340/console

Please take a look over the changes. Thanks!

Comment 13

[Zac C (:zac)]

Comment on attachment 8475122 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23036/files

It runs well but just needs the wait updated ;) ;)

Comment 14

[Viorela Ioia [:viorela]]

Comment on attachment 8475122 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23036/files

waits are updated

Comment 15

[Zac C (:zac)]

Comment on attachment 8475122 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23036/files

New waits are good! R+

Comment 16

[Viorela Ioia [:viorela]]

Merged in: https://github.com/mozilla-b2g/gaia/commit/6ee6cbb5f05cdc9563fecc106ed1d68994698b1e