944658 - [Flatfish][Contact] no setting page shown when taping on setting gear in Contacts

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Eric Chang [:ericcc] [:echang]]

Attachment: ContactsGear.png

Gaia:     f2562a74396da6d50a1a3f474ad72d935f8c3e90  │  
Gecko:    58fd6fd69cf4f78e715108a7393cf34b3d87e1af  │  
BuildID   20131129064521                            │  
Version   28.0a1                                    │  
ro.build.version.incremental=20131129  

1. Open "Contact".
2. Tap the setting gear.
3. No setting page shown.

Comment 1

[Francis Lee [:frlee]]

this is a bug, change it to 1.3+

Comment 2

[Anthony Ricaud (:rik)]

I'm seeing two errors when I press the gear button:
E/GeckoConsole( 3794): [JavaScript Error: "TypeError: iccManager is undefined" {file: "app://communications.gaiamobile.org/contacts/js/utilities/icc_handler.js" line: 16}]

And when I go to another app, come back to Contacts (without killing Contacts), I'm seeing this when pressing it again:
E/GeckoConsole( 2868): [JavaScript Error: "TypeError: orderCheckBox is undefined" {file: "app://communications.gaiamobile.org/contacts/js/views/settings.js" line: 82}]

Comment 3

[Anthony Ricaud (:rik)]

OK so looking at this screen on mobile, this is not an error but actually a "feature". The settings menu has some import contacts and export contacts items. We query the SIM cards to display this. So we need to remove those menu items and the code shouldn't query the SIM cards.

Joe: I think someone more familiar with the contacts code base should look at this. Also, I'm on PTO for 3 weeks so… :)

Comment 4

[Joe Young]

I trace Contacts app code
before Setting page shown it will do Contacts.Settings.init() in 
[ apps/communications/contacts/js/contacts.js line 603 function:showSettings ]
and it will trigger
[ apps/communications/contacts/js/contacts.js line 42 -> 
  IccHandler.init(new SimDomGenerator(), contacts.Settings.cardStateChanged); ]
this code try to get navigator.mozIccManager in icc_handler.js, but navigator.mozIccManager === undefined, so it cause an error.

there is no SIM card in flatfish, so this code need to avoid to access navigator.mozIccManager or Gecko need to handle this situation.
maybe it will happen in device without SIM card, not just flatfish.

Comment 5

[Francisco Jordano [:arcturus] [:francisco]]

(In reply to Joe Young from comment #4)

> there is no SIM card in flatfish, so this code need to avoid to access
> navigator.mozIccManager or Gecko need to handle this situation.
> maybe it will happen in device without SIM card, not just flatfish.

It won't happen in a device without SIM, cause the API will be present and we will show the buttons for import/export to the SIM disabled.

I guess we will need a bit of work to be aware of cases where we have devices with no API, not just flatfish, but also the simulator and similar.

Probably this is a regression of the DSDS work, but we will need a bit of extra work, cause showing a button disabled I think is not acceptable in flatfish.

Cheers,
F.

Comment 6

[Joe Cheng [:jcheng] (please needinfo)]

to Rik when he returns after the new year

Comment 7

[Joe Cheng [:jcheng] (please needinfo)]

QAWANTED. it is beleived that another bug should have fixed this bug
ni? francisco for the bug #

Comment 8

[Francisco Jordano [:arcturus] [:francisco]]

Hi, I think this has been fixed in bug 947859

Cheers!

Comment 9

[Joe Young]

Cheers!!

Comment 10

[Jason Smith [:jsmith]]

I'm unsure why this would be 1.3 blocker specifically, as I don't recall work happening for flatfish on any branch other than trunk. Renominating for more discussion.

Comment 11

[Jason Smith [:jsmith]]

See https://bugzilla.mozilla.org/show_bug.cgi?id=944594#c5.

Comment 12

[Francis Lee [:frlee]]

contribution program build will be based on master-C. remove 1.3? flag.

Comment 13

[Anthony Ricaud (:rik)]

Setting qawanted per comment 7 and 8 to close this bug if it has been fixed.

Comment 14

[Anthony Ricaud (:rik)]

I checked myself and it was fixed.