94491 - tree in file open dialog does not need mutliple selection

Status: VERIFIED FIXED

(Core :: XUL, defect)

Description

[Mike Potter]

The tree that you get when you go to open a file does not need multiple
selection.  I can't find an instance where I am allowed to open multiple files.
I came across this bug as I was attaching files to an email message.  I wanted
to attach multiple files, so I held down ctrl as I selected files.  They were
selected, however I could only attach one at a time.  The same happens if you go
to open a file in the browser or editor.
Fix this by adding "multiple=false" to the tree tag.  Unfortunately, I don't
know where the file open XUL is.

Comment 1

[Chad Austin]

*** This bug has been marked as a duplicate of 69528 ***

Comment 2

[Chad Austin]

oops

Comment 3

[Chad Austin]

*** This bug has been marked as a duplicate of 43015 ***

Comment 4

[Mike Potter]

I don't know if its a duplicate, but they are certainly related.
I think this bug covers more of the other applications, like Navigator and
Editor, whereas the other bugs only cover email attachments.
Suggest it be reopened and put as a dependancy on the other bugs.
This will also impact the OEone team as we use the open file dialog many times.
 I guess what we really need is to pass the open file dialog a parameter on
whether you can open > 1 document.  If true, set the tree to multiple=true,
otherwise set it to multiple = false.
Adding keyword oeone and asking that it be reopened.

Comment 5

[Chad Austin]

Sorry, I guess I was just assuming that when bug 43015 is fixed we'll get
nsILocalFile improvements for free.  ;)  I don't know if there's a specific bug
for multiple-selection support in nsIFilePicker, so I'll just leave this open
for now.  Anyone else?

Comment 6

[Mike Pinkerton (not reading bugmail)]

--> bryner

Comment 7

[John Morrison]

May God have mercy on us all. The 212 bug spam-o-rama is Now!

Comment 8

[Brian Ryner (not reading)]

yep, really easy fix.

Comment 9

[Brian Ryner (not reading)]

Attachment: patch

Comment 10

[jag (Peter Annema)]

r=jag.

Though isn't there a bug on making the xp filepicker support multiple selection?

Comment 11

[Johnny Stenback (:jst)]

sr=jst

Comment 12

[Brian Ryner (not reading)]

checked in.

Comment 13

[sairuh (rarely reading bugmail)]

vrfy fixed using 2001.10.04.08-trunk bits on linux.

fiddled around with modifier keys here, and filed bug 103243, where
ctrl+clicking moves the focus ring but not the highlight.