Closed Bug 43015 Opened 24 years ago Closed 22 years ago

Cannot add multiple attachment in Attach File dialog-Linux and Macosx only

Categories

(MailNews Core :: Composition, defect, P2)

Product:
MailNews Core
Component:
Composition
Platform:
x86
Linux
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
mozilla1.2alpha

People

(Reporter: bugzilla, Assigned: sspitzer)

References

Details

(Whiteboard: [fixed on Windows and Mac])

Attachments

(3 files, 1 obsolete file)

patch
1.40 KB, patch
asa
: approval+
Details | Diff | Splinter Review
Two attached files become a folder
29.99 KB, image/png
Details
html spam
6.09 KB, text/plain
Details 
After pressing Attach File you're presented with the standard window Open File 
(Attach File) dialog. In this dialog it's only possible to attach one file at a 
time. In 4.x you could attach many files at a time saving a lot of time if 
you're gonna attach fx 10 files....

Build 2000061820
I think this is a dup of an enhancement bug we may have.
QA Contact: lchiang → pmock
*** Bug 44123 has been marked as a duplicate of this bug. ***
moving to future milestone.
Severity: normal → enhancement
Target Milestone: --- → Future
Status: NEW → ASSIGNED
*** Bug 55903 has been marked as a duplicate of this bug. ***
*** Bug 60564 has been marked as a duplicate of this bug. ***
*** Bug 62296 has been marked as a duplicate of this bug. ***
also seen on linux
OS: Windows 2000 → All
Hardware: PC → All
nominating as mail3.
Keywords: mail3
triage team FYI: Still cannot multiple select in attachment dialog with dec21
trunk build, all platforms.
marking nsbeta1+ and moving to mozilla0.8
Keywords: nsbeta1
Whiteboard: [nsbeta1+]
Target Milestone: Future → mozilla0.8
Reassigning "attach file" bugs to varada.
Assignee: ducarroz → varada
Status: ASSIGNED → NEW
Marking dependant on bugs 44464(Backend support for Multiple file selection) &
63687(Frontend support for NSIFilePicker)
Status: NEW → ASSIGNED
Depends on: 44464, 63687
moving to mozilla0.9
Target Milestone: mozilla0.8 → mozilla0.9
Would support for drag/drop multiple files to the compose window's attachment 
area fall under this bug?
Lisa, we should have another bug for that though some of that bug might get
fixed with this bug. For this bug we need to make it so that we can get multiple
files from the attachment dialog.
marking nsbeta1- and moving to future milestone.
Keywords: nsbeta1 → nsbeta1-
Whiteboard: [nsbeta1+] → [nsbeta1+ 2/13]
Target Milestone: mozilla0.9 → Future
I don't see this as an enhancement.  This is standard OS behavior.  If I'm
wrong, please re-adjust.
Severity: enhancement → normal
*** Bug 69528 has been marked as a duplicate of this bug. ***
QA Contact: pmock → esther
*** Bug 78776 has been marked as a duplicate of this bug. ***
*** Bug 79728 has been marked as a duplicate of this bug. ***
Summary: Only one file can be select in Attach File dialog → Only one file can be selected in Attach File dialog
*** Bug 84892 has been marked as a duplicate of this bug. ***
*** Bug 85910 has been marked as a duplicate of this bug. ***
*** Bug 89260 has been marked as a duplicate of this bug. ***
*** Bug 89314 has been marked as a duplicate of this bug. ***
More than 10 dupes.
Keywords:->mostfreq
Keywords: mostfreq
*** Bug 69177 has been marked as a duplicate of this bug. ***
 Adding 4xp per the latest dup and the original report of this bug.
Keywords: 4xp
*** Bug 90311 has been marked as a duplicate of this bug. ***
*** Bug 91668 has been marked as a duplicate of this bug. ***
*** Bug 92063 has been marked as a duplicate of this bug. ***
*** Bug 92226 has been marked as a duplicate of this bug. ***
Keywords: mozilla0.9.4, mozilla1.0
nominating nsbranch.
Keywords: nsBranch
Marking as blocker for the "makes Mozilla advocacy harder" tracking bug.
Blocks: advocacybugs
*** Bug 93415 has been marked as a duplicate of this bug. ***
*** Bug 94491 has been marked as a duplicate of this bug. ***
Keywords: nsenterprise
Keywords: nsBranch → nsbranch
Blocks: 99230
No longer depends on: 44464
Untandling dependencies on bug 44464 and bug 63867, which have to do 
with HTML forms INPUT TYPE=FILE, not email attachments.
No longer depends on: 63687
cleaning up the keywords. Bringing into .9.6 for the next release.
Keywords: mozilla0.9.4, mozilla0.9.5, mozilla0.9.6, mozilla0.9.7, mozilla1.0, nsbeta1-, nsbranch
Target Milestone: Future → mozilla0.9.6
No longer blocks: 99230
marking nsenterprise-.
Keywords: nsenterprise+ → nsenterprise-
moving to 0.9.7
Target Milestone: mozilla0.9.6 → mozilla0.9.7
*** Bug 104182 has been marked as a duplicate of this bug. ***
*** Bug 105396 has been marked as a duplicate of this bug. ***
Keywords: nsbeta1
Whiteboard: [nsbeta1+ 2/13]
Keywords: mail3, nsbeta1 → nsbeta1+
Target Milestone: mozilla0.9.7 → mozilla0.9.9
Priority: P3 → P2
*** Bug 112945 has been marked as a duplicate of this bug. ***
*** Bug 114602 has been marked as a duplicate of this bug. ***
actually you can select multiple files but only the first one gets attached.
Summary: Only one file can be selected in Attach File dialog → Only one file can be attached in Attach File dialog
*** Bug 115143 has been marked as a duplicate of this bug. ***
QA Contact: esther → trix
*** Bug 121061 has been marked as a duplicate of this bug. ***
Depends on: 121122
See also bug 69528 (which has a patched attached to it), about being able to
drag and drop multiple files into the attachment tree.
Running out of time for 0.9.9 -- what's the status here? Varada, any good news?

/be
This is dependant on 121122 (nsIFilePicker should allow picking multiple files)
but that has been futured.
Target Milestone: mozilla0.9.9 → mozilla1.0
Discussed at 2/19/02 bug meeting w/ Eng/PjctMg/Marketing: decided to move to
1.2, and change nsbeta+ to nsbeta-
Depends on: 122274
Keywords: nsbeta1+ → nsbeta1-
Target Milestone: mozilla1.0 → mozilla1.2
How can something so basic be marked off until the far future? I mean, maybe not
for 0.99, but this should definetly be there by 1.0. I don't care for version
numbers, but the fact is that 1.0 will be looked, and used, by a lot of people,
just because it is the "real" release. Maybe this bug should be discussed again
in the next meeting...

Oh and I know 1.2 is not really far away, but it keeps getting pushed back all
the time!
I think the reason is that the enginners are FLOODED with bugs. And with this
bug you work can actually be done (by attaching one file at a time). So this bug
does not hinder your work other than making your life a bit harder...
Whip up a patch for the blocking bug and this one will be trivial. You can't fix
this one before bug 121122 is fixed.
> Oh and I know 1.2 is not really far away, but it keeps getting pushed back all
> the time!

Don't mean to fuel the flame, but in accordance with the regularity of the 
current roadmap (http://www.mozilla.org/roadmap.html), version 1.2 won't be 
released till around September 25th.  I would consider this pretty darn far 
away.
Fixing a dependency which I mis-entered on 2/20.
No longer depends on: 122274
Blocks: 122274
*** Bug 132531 has been marked as a duplicate of this bug. ***
*** Bug 132906 has been marked as a duplicate of this bug. ***
mscott: how about this: 


look at thread pane: you can shift- / ctrl, drag click multiple number of
posts/emails you wanna delete/copy or move.  This seems to work by using an
arrayed or linked list index.  Now could filepicker use such an dynamic linked
list to go retrieve each and then drag & drop them as if the user had these drag
& drop steps manually?

Seems like it would work in theory.


Dennis, this bug cannot be fixed, until the bug it is depending on (bug 121122)
is fixed. That bug is pp (you will need to implement it for every major
platform)... Anyway, if you want to discuss a solution, you should do so there.
*** Bug 135907 has been marked as a duplicate of this bug. ***
*** Bug 138235 has been marked as a duplicate of this bug. ***
*** Bug 141838 has been marked as a duplicate of this bug. ***
*** Bug 143275 has been marked as a duplicate of this bug. ***
*** Bug 146933 has been marked as a duplicate of this bug. ***
*** Bug 147302 has been marked as a duplicate of this bug. ***
*** Bug 148567 has been marked as a duplicate of this bug. ***
*** Bug 148768 has been marked as a duplicate of this bug. ***
Well, maybe it's the time to increase the priority of bug #121122, because
currently it is considered "enhancement" and targeted to "future", which given
the number of dups and votes here seems somewhat strange.
*** Bug 151197 has been marked as a duplicate of this bug. ***
*** Bug 154119 has been marked as a duplicate of this bug. ***
Blocks: 154188
*** Bug 155153 has been marked as a duplicate of this bug. ***
*** Bug 155764 has been marked as a duplicate of this bug. ***
Blocks: majorbugs
change summary to make this bug more discoverable.
Summary: Only one file can be attached in Attach File dialog → c
what the...?
Summary: c → Cannot add multiple attachment in Attach File dialog
Nominating for next release.
Keywords: nsbeta1- → nsbeta1
taking.  initial patch in hand, for this bug and #121122 (at least for windows)
Assignee: varada → sspitzer
Status: ASSIGNED → NEW
What to do with it?
*** Bug 167060 has been marked as a duplicate of this bug. ***
accepting.  watch #12112 for the patch.  I'm going to fix both bugs at once.
Status: NEW → ASSIGNED
Comment on attachment 97930 [details] [diff] [review]
initial patch, works for windows, still needs cleanup

obsolete, see #121122 for the patch.
Attachment #97930 - Attachment is obsolete: true
fixed.  

note to QA: 

we can't verify on mac until bug 167149 is fixed or on linux until bug 167152 
is fixed.

for now, only win32.
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
supplimental patch is needed.

wcyeh@zydas.com.tw writes:

  "In normal cases, it works just fine.
   However, when I attach files from a folder with its using
   number, the files are inccorectly attached.
   For example,
     Path: c:\xxx\yyy\1234
     Files: files1.txt, files2.txt

   The files name shown in the attachment panel will look like this

     1234files1.txt
     1234files2.txt

   and the mozilla will refuse to send this e-mail.
   When these files are selected one by one or are selected from a
   folder not using a name starting by a number, your patch will work
   just fine.

   My configuration: OS: win2k with SP3, and built 2002090804."

wcyeh@zydas.com.tw is right.  supplimental patch that fixes this problem coming up.
Comment on attachment 98550 [details] [diff] [review]
patch

a=asa (on behalf of drivers) for checkin to 1.2a
Attachment #98550 - Flags: approval+
supplimental fix checked into the trunk, r/sr=bienvenu.

thanks wcyeh@zydas.com.tw for the bug report.
changing qa contact to yulian
QA Contact: trix → yulian
This bug is marked as resolved fixed, but it doesn't work for me in build ID
2002121008.

I can ctrl-select or shift-select multiple files, but what appears in the
attachment window is a folder icon.  This is in fact a list of all the files in
the folder from which I selected files to attach.  I can provide screenshots if
this is unclear.
seems OK for me with
 Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.3a) Gecko/20021210
Am I doing something stupid?  Here are the steps of attaching two files and
getting a folder as the attachment.
Attached file html spam — 
Here's what it looks like when I receive the attachment.
The attachment in comment 91 appears to be corrupt. Here's the message when
clicking on the link:

The image “http://bugzilla.mozilla.org/attachment.cgi?id=109017&action=view”
cannot be displayed, because it contains errors.

Ian, are you running Windows 9x? This (or something very similar) has been
discussed in the NGs (probably n.p.m.mail-news). It's a Win 9x thing that
doesn't affect NT-class Windows, i.e. Windows is doing it, not Moz.

Comment on attachment 109017 [details]
html spam

it's actually random spam, i think he managed to attach the wrong file.

that said, can you please file a new bug so that you don't clutter this one up?
Attachment #109017 - Attachment description: Contents of the "folder" attachment → html spam
Attachment #109017 - Attachment mime type: image/png → text/plain
Yes, Win98.  I've raised bug 184885 if anyone wants to see the real screenshots.
QA Contact: yulian → stephend
OS: All → Windows 2000
Hardware: All → PC
I found this in build 1.3a as well.  It will let you add multiple attachments if
you do it one at a time, but when I tried to select two attachments to add to an
e-mail, the folder that the files were in was displayed.
This obviously isn't working as people would expect it too. New bug: bug 171211
WinXP build 20030202 (mozilla 1.3b) & Win98 this is fixed.  Multiple select of
message paste them into the attachment area with correct file name.  Also, I
don't see the problem mentioned in comment 90, I see individual files not a
folder.  
Linux build 20030211 (mozilla 1.3b) & Maco OSX build 20030206 (mozilla 1.3b)
still a problem but as pointed out in comment 82 this bug can't be tested and
verified until bug 167152 is fixed. 

This will remain not verified until the linux & mac blocker bugs are fixed.
Changing OS to linux and adding to summary.
OS: Windows 2000 → Linux
Summary: Cannot add multiple attachment in Attach File dialog → Cannot add multiple attachment in Attach File dialog-Linux and Macosx only
adding the other 2 depend bugs
Depends on: 167149, 167152
QA Contact: stephend → esther
Whiteboard: [note, only fixed on windows]
Flags: blocking1.3?
Flags: blocking1.3? → blocking1.3-
Using trunk build 20030317 on linux this is fixed.   Only Mac OSX depend bug
167151 needs to be fixed to verify this. 
*** Bug 199081 has been marked as a duplicate of this bug. ***
Re dup bug 199081: Are there any plans about backporting this to the 1.0.* branch?
Note that this should work on Mac too, now.
Whiteboard: [note, only fixed on windows] → [fixed on Windows and Mac]
On what build should this work on Mac? and which Mac OS?  Using trunk build
20030408 on Mac OSX 10.2 I can't multiple select files to attach to a mail message. 
works on macosx build 20030415 verified
Status: RESOLVED → VERIFIED
Product: MailNews → Core
No longer blocks: majorbugs
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: