Closed Bug 945496 Opened 6 years ago Closed 6 years ago

Disable unified builds on mozilla-aurora+

Categories

(Firefox Build System :: General, defect)

x86
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla28

People

(Reporter: ehsan, Assigned: glandium)

References

Details

Attachments

(2 files)

See the dev.platform discussion.

glandium, can you please take this, or tell me what the magical flag to test for in configure.in is so that I can take it myself?  Thanks!
Flags: needinfo?(mh+mozilla)
Assignee: nobody → mh+mozilla
Flags: needinfo?(mh+mozilla)
Until we can do something better
Attachment #8341379 - Flags: review?(ehsan)
Attachment #8341378 - Flags: review?(ehsan) → review+
Comment on attachment 8341379 [details] [diff] [review]
Disable unified builds on tbpl debug builds

Review of attachment 8341379 [details] [diff] [review]:
-----------------------------------------------------------------

I'm not convinced that we should do this for now.  I would like us to address these kinds of bustages with a lower priority than backing out the patch immediately, so I don't want them to turn debug builds red.

(And this should go into its own bug if we want to re-evaluate anyway.)
Attachment #8341379 - Flags: review?(ehsan) → review-
(In reply to :Ehsan Akhgari (needinfo? me!) from comment #3)
> Comment on attachment 8341379 [details] [diff] [review]
> Disable unified builds on tbpl debug builds
> 
> Review of attachment 8341379 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> I'm not convinced that we should do this for now.  I would like us to
> address these kinds of bustages with a lower priority than backing out the
> patch immediately, so I don't want them to turn debug builds red.
> 
> (And this should go into its own bug if we want to re-evaluate anyway.)

The thing is, with the first patch, we run in a serious chance of busting aurora when merging. I'm running non-unified builds on birch, which kind of helps, but i already hit two different build failures that slipped in within the past 10 hours.
And yes, i do think at 7 days from the merge, we should start being proactive, not reactive. Also, those errors should be fixed by the people that land them, not you and me.
(In reply to Mike Hommey [:glandium] from comment #4)
> The thing is, with the first patch, we run in a serious chance of busting
> aurora when merging. I'm running non-unified builds on birch, which kind of
> helps, but i already hit two different build failures that slipped in within
> the past 10 hours.

And a third one just landed.
Comment on attachment 8341379 [details] [diff] [review]
Disable unified builds on tbpl debug builds

OK, let's give it a shot, I guess...  Please post to dev-platform on a new thread before landing this.  Thanks!
Attachment #8341379 - Flags: review- → review+
So is this fixed now?
Ah yes, I'm too used to landing on inbound.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Blocks: 946576
(In reply to :Ehsan Akhgari (not reading bugmail, needinfo? me!) from comment #0)
> See the dev.platform discussion.

For future reference, this was: https://lists.mozilla.org/pipermail/dev-platform/2013-December/002393.html
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.