946576 - Disable unified builds on all debug builds

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

+++ This bug was initially created as a clone of Bug #945496 +++

Bug 945496 disabled for browser, but not b2g/android/xulrunner. And guess what, a build error already slipped in for android.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Disable unified builds on b2g and xulrunner builds, and android debug builds

There aren't debug builds on all platforms for b2g, so i just enabled everywhere. Likewise for xulrunner.

Comment 2

[Honza Bambas (:mayhemer)]

Is this because of problems on tbpl only?  I'm very happy with unified builds, it speeds up builds so much for me locally!  Can I opt-out when building locally?  What problems can I expect then?

Comment 3

[Trevor Saunders (:tbsaunde)]

(In reply to Honza Bambas (:mayhemer) from comment #2)
> Is this because of problems on tbpl only?  I'm very happy with unified
> builds, it speeds up builds so much for me locally!  Can I opt-out when
> building locally?  What problems can I expect then?

if you read the patch you'll see it just changes the in tree mozconfigs which you shouldn't be using anyway so it has no effect.

Comment 4

[Honza Bambas (:mayhemer)]

(In reply to Trevor Saunders (:tbsaunde) from comment #3)
> (In reply to Honza Bambas (:mayhemer) from comment #2)
> > Is this because of problems on tbpl only?  I'm very happy with unified
> > builds, it speeds up builds so much for me locally!  Can I opt-out when
> > building locally?  What problems can I expect then?
> 
> if you read the patch you'll see it just changes the in tree mozconfigs
> which you shouldn't be using anyway so it has no effect.

The in-tree mozconfig structure is not clear to ordinary mortals ;)  Thanks for explanation!

Comment 5

[Alex Vincent [:WeirdAl]]

(In reply to Mike Hommey [:glandium] from comment #1)
> Created attachment 8342873 [details] [diff] [review]
> Disable unified builds on b2g and xulrunner builds, and android debug builds
> 
> There aren't debug builds on all platforms for b2g, so i just enabled
> everywhere. Likewise for xulrunner.

Why XULRunner?

Comment 6

[(no longer active)]

(In reply to comment #5)
> (In reply to Mike Hommey [:glandium] from comment #1)
> > Created attachment 8342873 [details] [diff] [review]
> > Disable unified builds on b2g and xulrunner builds, and android debug builds
> > 
> > There aren't debug builds on all platforms for b2g, so i just enabled
> > everywhere. Likewise for xulrunner.
> 
> Why XULRunner?

Because it can also break in similar ways to other types of builds.

Comment 7

[Mike Hommey [:glandium]]

https://hg.mozilla.org/mozilla-central/rev/258bb2ea7c1a

Comment 8

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

(In reply to Trevor Saunders (:tbsaunde) from comment #3)
> if you read the patch you'll see it just changes the in tree mozconfigs
> which you shouldn't be using anyway so it has no effect.

Except for b2g, where gonk-misc/default-gecko-config (which is used for all builds, local and tinderbox and whatever else) includes gecko/b2g/config/mozconfigs/common.

Comment 9

[(no longer active)]

Shoot!  Mike, can you please see if you can do something to avoid putting this into b2g/config/mozconfigs/common?

Comment 10

[Mike Hommey [:glandium]]

(In reply to Jed Davis [:jld] from comment #8)
> (In reply to Trevor Saunders (:tbsaunde) from comment #3)
> > if you read the patch you'll see it just changes the in tree mozconfigs
> > which you shouldn't be using anyway so it has no effect.
> 
> Except for b2g, where gonk-misc/default-gecko-config (which is used for all
> builds, local and tinderbox and whatever else) includes
> gecko/b2g/config/mozconfigs/common.

How does one discriminate between local builds and tinderbox builds in this wonderful system?

Comment 11

[Mike Hommey [:glandium]]

(In reply to :Ehsan Akhgari (needinfo? me!) from comment #9)
> Shoot!  Mike, can you please see if you can do something to avoid putting
> this into b2g/config/mozconfigs/common?

Please file a followup. B2G developers can live with slower builds until the merge, which is on monday.