947317 - MarionetteException after a tap() closes a frame - MarionetteException: {u'message': u'"toString" is read-only', u'error': u"error occurred while processing 'findElement"}

Status: RESOLVED DUPLICATE of bug 1065933

(Remote Protocol :: Marionette, defect, P1)

Description

[Zac C (:zac)]

When adding a contact from the dialer after we close the Contacts frame Marionette cannot use the find element command.

The contacts frame can be opened in different ways - ie just by normal Contacts app operation or via the dialer. When coming back from adding a contact via the dialer there is a wait for the button we tap to be not displayed. In normal operation this works fine but when Contacts is opened via the dialer it involves changing frames.
The "wait for not displayed" would technically be performed on the wrong frame, or perhaps on both frames as Gaia transitions between them.

this can be replicated by running on a device:

tests/functional/dialer/test_dialer_add_contact.py

Comment 1

[Zac C (:zac)]

Disabling the test because of this

Comment 2

[Zac C (:zac)]

Updating to major, causes device freeze and blocks test coverage.

Comment 3

[David Burns :automatedtester]

needinfoing myself and will try pick it up next week, currently on PTO

Comment 4

[David Burns :automatedtester]

This appears to not be a regression since it was caused by a change to a bug. 

Change happened in https://github.com/mozilla-b2g/gaia/commit/9bd709d310f26dc4e3c4d6a1a51a3e4567558375#diff-92508c5b8215627dee173d2d7e2d1f53

Comment 5

[Zac C (:zac)]

(In reply to David Burns :automatedtester from comment #4)
> This appears to not be a regression since it was caused by a change to a
> bug. 
> 
> Change happened in
> https://github.com/mozilla-b2g/gaia/commit/
> 9bd709d310f26dc4e3c4d6a1a51a3e4567558375#diff-
> 92508c5b8215627dee173d2d7e2d1f53

Just reviewing this commit; there's flawed logic in this code anyway so I am going to revert it and also work around this Marionette bug at the same time.

It means this test will no longer be xfailed, but the Marionette bug is still outstanding as Marionette should handle closing frames like this. I'm sure this bug is a dupe of a known Marionette issue where a tap closes a frame and Marionette hangs but I can't find it just yet.

Comment 6

[Zac C (:zac)]

Sorry I cannot find the old bug for this but I know we've dealt with this problem before where a tap closes the frame that Marionette is working on and Marionette can't continue, as if it's lost the reference to the frame and doesn't fall back onto one to keep the session alive.

This is almost certainly a regression but given the time frames I'll leave this bug open as a new one.

Comment 7

[David Teller [:Yoric] - still alive but not very active]

Probably related to bug 909511.

Comment 8

[Dave Hunt [:davehunt] [he/him] ⌚BST]

This bug doesn't appear to have steps to reproduce, and is probably now a duplicate of bug 1065933. If we see this issue again then we should catch the Marionette exception when an action is expected to close the current frame.