947826 - [Gaia][WAP Push] Update object format wrt bug 947814

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

update dataLength to data.length

Comment 1

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Attachment: Pull Request

Comment 2

[Gabriele Svelto [:gsvelto] (PTO)]

Comment on attachment 8344513 [details] [review]
Pull Request

Looks good to me, ask for review when you land bug 947814 and I will r+ this.

Comment 3

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Comment on attachment 8344513 [details] [review]
Pull Request

Bug 947814 is landed, thanks!

Comment 4

[Gabriele Svelto [:gsvelto] (PTO)]

Comment on attachment 8344513 [details] [review]
Pull Request

Looking good, land at will.

Comment 5

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Merged to Gaia master,
https://github.com/mozilla-b2g/gaia/commit/7e8b532adaa3919d3170313a183a4b1f754c6983

Comment 6

[José Antonio Olivera Ortega [:jaoo]]

Requesting 1.3+ per comment https://bugzilla.mozilla.org/show_bug.cgi?id=951436#c27

Comment 7

[Jason Smith [:jsmith]]

(In reply to José Antonio Olivera Ortega [:jaoo] from comment #6)
> Requesting 1.3+ per comment
> https://bugzilla.mozilla.org/show_bug.cgi?id=951436#c27

blocking+ per this comment

Comment 8

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 7e8b532adaa3919d3170313a183a4b1f754c6983 to:
v1.3: 5f4a1f34123b6dd3ff79bde52cdb2a111115c241