949052 - [User Story] FxA - Sign in to Firefox Accounts from Settings

Status: RESOLVED DUPLICATE of bug 949051

(Firefox OS Graveyard :: Gaia, defect)

Description

[Adam Rogers (:arog)]

User Story:

As a user, I want to be able to sign in to my Firefox account from the Settings menu so that I can take advantage of Firefox Accounts.

Acceptance Criteria

1. I can log in under Settings using my previously configured Firefox Account account using my email address and password.
2. If my device drops connectivity while in the process of signing in, I am made aware the of the lack of connectivity and asked to try again later.
3. If my device drops connectivity while in the process of creating an account, I am made aware the of the lack of connectivity and asked to sign in later through Settings.

Comment 1

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

UX questions for jgruen:

1. If the user changes state (logged out vs staged vs logged in/confirmed) while the settings app is open, how do we transition between screens cleanly? Overlay + spinner + some text, I'd guess? I don't see anything like this spec'd, though I can look at the overlay in the system fxa app and try to make reasonable guesses.

2. If the user tries to sign in from the settings app, and fails due to network problems, the system app will tell them there's been a network error, so I'm guessing we just go back to the settings app logged-out screen when the user exits that flow. Am I right? Or do you want to add some messaging in the settings app about "try again later"? I think we could probably be fine without this, but thought I'd ask.


Dev questions for spenrose/ferjm:

Looking at the specs[1], I'm not totally sure which screens need to be in the settings app, and which are handled by the fxa system app flows.

I think the settings app will need (using identifiers from the spec):
* screen B1, add a 'firefox accounts' entry to main settings screen
* screen B2, logged out state
* screen C2, logged in state

I'm not sure about
* screen B11, "email sent" state -- is this in the settings app? if so, we'll need to know we are in the "staged" state when we call FxAccountsIACHelper.getAccounts(), and the onlogin() callback will need to provide this data, too. (Maybe this data is already provided--I will look again at borja's big pull request to try to understand the API responses better.)


[1] https://bug905637.bugzilla.mozilla.org/attachment.cgi?id=825368

Comment 2

[Fernando Jiménez Moreno [:ferjm]]

(In reply to Jared Hirsch [:_6a68] from comment #1)
> 
> I'm not sure about
> * screen B11, "email sent" state -- is this in the settings app? if so,
> we'll need to know we are in the "staged" state when we call
> FxAccountsIACHelper.getAccounts(), and the onlogin() callback will need to
> provide this data, too. (Maybe this data is already provided--I will look
> again at borja's big pull request to try to understand the API responses
> better.)
> 

B11 is part of the system dialog.

Also E2 seems to be part of Settings.

If by "staged" you mean logged-in with an unverified account, FxAccountsIACHelper.getAccounts returns an object like: { accountId: <string>, verified: <bool> }, so you will be able to know if the account is verified or not to show E2 when needed.

Comment 3

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

ferjm: thanks for the info!

Talked this out a bit with jgruen:
- Yes, we will have a third screen in settings app for unverified accounts.
- Transitioning between states while settings is open is a fairly remote edge case, but using a shared spinner/overlay is an easy way to handle it.
- New specs on the way.

Comment 4

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

ferjm: thanks for the feedback! I had been wondering what the response object looked like.

Comment 5

[Noemí Freire (:noemi)]

The patch corresponding to this US will be part of the one available in Bug 949051, is it right?.

Comment 6

[Sam Penrose]

Noemi, yes, that will be the patch. It is on github here as of Monday afternoon 27 Jan: https://github.com/mozilla-b2g/gaia/pull/15692 (check the bug for updates after this time).

Comment 7

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

this should be closed, if 949051 is. so, marking as a dupe.

we can un-dupe later, when we figure out the qa rules to call stuff "really done"

Comment 8

[No-Jun Park [:njpark]]

Manual test case steps are available here:

https://moztrap.mozilla.org/manage/case/12862/