949379 - [Gaia][Messages] Message report panel visual polish

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Steve Chung [:steveck]]

Follow up bug for Bug #933131. Visual assets and guide in bug 919977. Except for some layout adjustment and image assets replacement, the delivery tick in message bubble will be removed per ux request.

Comment 1

[Steve Chung [:steveck]]

Attachment: Screen Shot 2013-12-05 at 16.22.06.png

Hi Jose, this view is the original group participient view with the participient list. This view comes from activating the group participient header, and report view also reuse this contact list for the basic structure. Since you specify some visual requirement for contact list in the report view, should we sync the changes in group participient view?

Comment 2

[José Vittone]

Hi Steve,

The contact list in the message report view is also aligned with Contacts app. It seems that this is a similar case. I can't access to the view you shared, could you tell me how to do it if it is possible on my phone?

Thanks,
Jose

Comment 3

[Julien Wajsberg [:julienw] (PTO -> Mar 17)]

José: bug 933131 has not landed yet, that's why you don't see the panel on builds yet.

Comment 4

[Steve Chung [:steveck]]

Attachment: Link to github

Hi Julien, I polished the layout and fixed the re-translate issue for some date related element. The fixing seems works right after chaging the language but still need you help to see if that is the proper place/method to do the re-translate, thanks.

Comment 5

[Julien Wajsberg [:julienw] (PTO -> Mar 17)]

Comment on attachment 8356645 [details] [review]
Link to github

added comments on github

overall this looks good :)

Comment 6

[Steve Chung [:steveck]]

Comment on attachment 8356645 [details] [review]
Link to github

Hi Julien, I've updated the patch based on your suggestions, thanks for the comments!

Comment 7

[Julien Wajsberg [:julienw] (PTO -> Mar 17)]

I've found 2 issues while reviewing. I think each of them belongs to a different bug:

* when you long press on a message that is in the bottom, then the menu item are triggered. This is a APZC bug, bug 959199.

* the "sent" timestamp is supposed to be displayed somewhere in the delivery panel, but I think we missed it in the original bug, and in this bug as well. Can we add it in a follow-up bug ?

Comment 8

[Julien Wajsberg [:julienw] (PTO -> Mar 17)]

Comment on attachment 8356645 [details] [review]
Link to github

r=me, with the small nit

please also file the follow-up bug

thanks!

Comment 9

[Steve Chung [:steveck]]

Thanks for the review, follow up bug 959449 created.
Landed in master: 3a19266097b436aa2e23a2bc3c9d4383d27e88bc

Comment 10

[Julien Wajsberg [:julienw] (PTO -> Mar 17)]

Steve, see comment 7, I'd like a follow-up bug to display the "sent" timestamp too! (which was implemented in Gecko in bug 901457)

Comment 11

[Steve Chung [:steveck]]

(In reply to Julien Wajsberg [:julienw] from comment #10)
> Steve, see comment 7, I'd like a follow-up bug to display the "sent"
> timestamp too! (which was implemented in Gecko in bug 901457)

I create another bug 961574 for sent timestamp.