949741 - [CDMA] Settings supplementary services (SS) broken

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Michael Schwartz [:m4]]

In CDMA, SS are performed via dial strings sent to the network as normal phone calls.  Although settings could initiate calls to perform SS operations, the lack of feedback from the NW results in a poor UX.  Please consider removing these supplementary service items from the Settings app.

Comment 1

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Triage: We need a step to reproduce here. Flagging UX for consideration.

Comment 2

[Anshul]

What M4 meant is to remove the CLIR and the call forwarding settings option from the UI for CDMA.

Comment 3

[Stephany Wilkes]

Flagging Neo on Settings.

Comment 4

[Michael Schwartz [:m4]]

Steps to reproduce:
# Connect to a CDMA network
# Go to Settings app

Seen:
# GSM SS is available

Expected:
# GSM SS not visible

Comment 5

[Neo Hsieh [:neo]]

Hi. Is this caused by non-config file build ?

Comment 6

[Michael Schwartz [:m4]]

Sorry for the delay, on vacation.  Not sure what you mean by "non-config file build".  How can I check?

Comment 7

[Neo Hsieh [:neo]]

last time I heard about this problem is caused by non-config file build. Means if user use CDMA device, system will hide GSM options. But for global version that will shows all optins (CDMA & GSM...) . 

And Tim discussed this topic with Gecko team, they will fix it. but I don't know if this can resolve this bug ?

Comment 8

[Tim Guan-tin Chien [:timdream] (please needinfo)]

You are confusing this issue with bug 950185 :'( This has nothing to do with that.

Comment 9

[Michael Schwartz [:m4]]

Hi Neo, note that instead of removing the items, as recommended above, we could simply disable them if the current network type is CDMA.

Comment 10

[Neo Hsieh [:neo]]

Hi Enpei, Please help to doulble confirm that was caused by non-config file build problem then we can resolve it.

Comment 11

[José Antonio Olivera Ortega [:jaoo]]

Let me jump into the discussion here please. This is not caused by not having the config file in the build but the code itself. I mean some supplementary services such as the CLIR and the call forwarding settings have to be removed/hidden or whatever for CDMA devices (per comment #2) and as today we don't do that. So it this is needed we have to touch the code a bit.

Comment 12

[Tim Guan-tin Chien [:timdream] (please needinfo)]

José, does hide/show the menu depend on knowing the device capability? For example, only hide the entry if this is a CDMA-only phone ...

Comment 13

[José Antonio Olivera Ortega [:jaoo]]

(In reply to Tim Guan-tin Chien [:timdream] (MoCo-TPE) (please ni?) from comment #12)
> José, does hide/show the menu depend on knowing the device capability? For
> example, only hide the entry if this is a CDMA-only phone ...

The setting app (call setting panel) shows/hides some menu item relaying on the telephony technology underneath (GSM, CDMA) such as voice privacy settings but not the CLIR and the call forwarding settings options.

Comment 14

[Neo Hsieh [:neo]]

This bug is duplicated to 950185 bug.

Comment 15

[Neo Hsieh [:neo]]

About UX wording, Please refer to https://bugzilla.mozilla.org/show_bug.cgi?id=950185

Comment 16

[José Antonio Olivera Ortega [:jaoo]]

(In reply to Neo Hsieh from comment #14)
> This bug is duplicated to 950185 bug.
> 
> *** This bug has been marked as a duplicate of bug 950185 ***

IHMO this is not a duplicated of 950185 bug.

Comment 17

[Jason Smith [:jsmith]]

Going to reopen for tracking per comment 16

Comment 18

[Andrew Overholt [:overholt]]

Is this a regression from 1.2?

Comment 19

[José Antonio Olivera Ortega [:jaoo]]

(In reply to Andrew Overholt [:overholt] from comment #18)
> Is this a regression from 1.2?

Not at all, somehow a new request.

Comment 20

[Andrew Overholt [:overholt]]

(In reply to José Antonio Olivera Ortega [:jaoo] from comment #19)
> (In reply to Andrew Overholt [:overholt] from comment #18)
> > Is this a regression from 1.2?
> 
> Not at all, somehow a new request.

Ah, that was the reason for 1.3+.  I'll move it back to a nom and ask Michael why he nommed it.

Comment 21

[Michael Schwartz [:m4]]

I think this bug is related to https://bugzilla.mozilla.org/show_bug.cgi?id=950185 but not necessarily a duplicate.  950185 is about what UX support be be there regardless of underlying phone support.  This CR is about what UX support will be there in different service state scenarios ie GSM SS Settings options should not be available while we have CDMA service.

Comment 22

[Arthur Chen [:arthurcc][inactive after 6/30]]

Bug 952043 provides an API for checking the supported network types of the device. We should waiting for bug 952043 in order to have a solid fix.

Comment 23

[Arthur Chen [:arthurcc][inactive after 6/30]]

Hsin-yi, based on my understanding only roaming preference and voice privacy are limited to CDMA devices. Other call settings such as call forwarding should be supported by both CDMA and GSM devices. Could you help clarify what is GSM supplementary service?

Comment 25

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Hi Arthur,

In CDMA, we should hide the followings:
Call waiting, Caller ID and Call forwarding. 

As previous comments said, these supplementary features are supported by the network but user need to contact customer services by dialing a operator-specified string. It's unable to have UI menu for those settings.

In GSM, we should hide:
voice privacy mode and roaming preference while these two are CDMA limited features.

And regarding FDN... though as Enpei mentioned in bug 941532 comment#0, it's not normal on CDMA networks, FDN is, however, a SIM/ICC/UICC function, not related to network types. So, we don't hide this as default on CDMA product.

Hi m4 and jaoo,
Please let me know if we are still missing something. :)

Comment 26

[José Antonio Olivera Ortega [:jaoo]]

(In reply to Hsin-Yi Tsai  [:hsinyi] from comment #25)

> Hi m4 and jaoo,
> Please let me know if we are still missing something. :)

Cristal clear, thanks Hsin-Yi.

I will be happy to take the bug and work on it once bug 952043 gets landed (if nobody else is going to work on it).

Comment 27

[Anshul]

CDMA is not advertised on 1.3 so marking it not blocking for 1.3

Comment 28

[Tim Guan-tin Chien [:timdream] (please needinfo)]

(In reply to Hsin-Yi Tsai  [:hsinyi] from comment #25)
> In GSM, we should hide:
> voice privacy mode and roaming preference while these two are CDMA limited
> features.
> 

We should still land this on 1.3 or otherwise this will be a regression for GSM-only phones (dead feature being present in the settings).

José, I won't stop you if you want to fix this :) however you own too many 1.3+ bugs so I would advice you to make sure all of them could be addressed on time before taking another one.

Comment 29

[José Antonio Olivera Ortega [:jaoo]]

(In reply to Tim Guan-tin Chien [:timdream] (MoCo-TPE) (please ni?) from comment #28)

> José, I won't stop you if you want to fix this :) however you own too many
> 1.3+ bugs so I would advice you to make sure all of them could be addressed
> on time before taking another one.

Yes, I meant to take this bug if nobody else wants to take once I finish all 1.3+ I own.

Comment 30

[Preeti Raghunath(:Preeti)]

Minus for now. please renom if needed.

Comment 31

[Anshul]

Requesting for 1.4 as this bug will improve the UI for CDMA voice call settings for 1.4.

Comment 32

[Ken Chang[:kenkai]]

Ivan, you may need to have someone into this bug.

Comment 33

[Preeti Raghunath(:Preeti)]

1.4+ for QC CS

Comment 34

[Ivan Tsay (:ITsay)]

(In reply to Ken Chang[:ken] from comment #32)
> Ivan, you may need to have someone into this bug.

Hi Ken,

Per discussion with Arthur, our gecko and gaia parts are ready to get the network type in order to show the correct supplementary service setting for CDMA or GSM. Please refer to the comment 63 in bug 952043 and ask our partner to add the similar property to see if the setting can be displayed correctly.

Comment 35

[Ken Chang[:kenkai]]

(In reply to Ivan Tsay (:ITsay) from comment #34)
> partner to add the similar property to see if the setting can be displayed
> correctly.
If device support world mode(GSM+CDMA), how do we handle this? Can we base on current network type to decide setting mane?

Comment 36

[Arthur Chen [:arthurcc][inactive after 6/30]]

No, this case is not handled. The menu does not change on the fly.

Comment 37

[Ken Chang[:kenkai]]

After offline discussing with Michael and Anshul, we don't need to fix this bug before 3/14. But we have to fix this bug before 3/28.

Comment 38

[Preeti Raghunath(:Preeti)]

Thanks Ken.

Comment 39

[Anshul]

(In reply to Ken Chang[:ken] from comment #37)
> After offline discussing with Michael and Anshul, we don't need to fix this
> bug before 3/14. But we have to fix this bug before 3/28.
Need by date of 3/28 is okay.

Comment 40

[Arthur Chen [:arthurcc][inactive after 6/30]]

Attachment: WIP

Jose, could you have a look on the patch to see if it makes sense to you? I tried to show/hide the menus when connected network type changes, and then call to corresponding update functions. The update function early returns if the UI is hidden.

I only finished the part of call settings, will continue to add similar logic for data roaming.

Comment 41

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8394012 [details]
WIP

Hi Jose, sorry for all the patches.

I've finished the part of network operator settings and tested it on Inari(GSM) and Wasabi(CDMA) phones. Because I don't have world phones in hand, I will ask QA to see if the partner is able to test the patch for us. Thanks for your great help!

Comment 42

[Anshul]

I will run some tests on Monday on a world mode phone and get back with the results.

Comment 43

[José Antonio Olivera Ortega [:jaoo]]

Anshul, is there any chance a device to report a network voice type change (gsm/cdma) on the fly?, is that supposed to happen on an aforementioned world mode phone?

Comment 44

[José Antonio Olivera Ortega [:jaoo]]

Anshul, I'm wondering also if FDN should be hidden for CDMA phones. Could you shed some light into it please? Thanks.

Comment 45

[José Antonio Olivera Ortega [:jaoo]]

Comment on attachment 8394012 [details]
WIP

Arthur, thanks for the patch. Left some comments on the PR. Could you take a look a it please? Thanks!

Comment 46

[Anshul]

(In reply to José Antonio Olivera Ortega [:jaoo] from comment #43)
> Anshul, is there any chance a device to report a network voice type change
> (gsm/cdma) on the fly?, is that supposed to happen on an aforementioned
> world mode phone?

Jose, yes a world mode phone can change the network from gsm/cdma on the fly if for example user selected a different network type. Let me find information about FDN and get back in some time.

Comment 47

[Anshul]

(In reply to José Antonio Olivera Ortega [:jaoo] from comment #44)
> Anshul, I'm wondering also if FDN should be hidden for CDMA phones. Could
> you shed some light into it please? Thanks.
Antonio, FDN is radio tech independent feature and so should be available for both GSM and CDMA family of radio techs.

Comment 48

[Anshul]

Antonio and Arthur, I pulled in the patch and below are my observations.

What worked
1. With a SIM card with device registered on the network I am able to see GSM options correctly. 
2. With a SIM card with both USIM and RUIM app switching the network to CDMA now shows CDMA options on the fly.

What didn't work
3. If phone doesn't have service there are no data call and voice call settings specific to either GSM or CDMA that are shown even though the network selected is GSM and there is a SIM card present. The only Network Operator option I see in this case is Network Type and Call Setting is Voicemail and FDN. 
4. GSM settings disappeared when radio tech reported is hspa. I left a note in github pointing to the issue.
5. Once I saw that the Gaia wasn't making a request to get individual call settings from RIL. Due to the issue #4 I am finding it hard to reproduce the bug. I will fix that locally and reproduce this tomorrow.

Comment 49

[Arthur Chen [:arthurcc][inactive after 6/30]]

Thanks for the test result.

(In reply to Anshul from comment #48)
> Antonio and Arthur, I pulled in the patch and below are my observations.
> 
> What worked
> 1. With a SIM card with device registered on the network I am able to see
> GSM options correctly. 
> 2. With a SIM card with both USIM and RUIM app switching the network to CDMA
> now shows CDMA options on the fly.
> 
> What didn't work
> 3. If phone doesn't have service there are no data call and voice call
> settings specific to either GSM or CDMA that are shown even though the
> network selected is GSM and there is a SIM card present. The only Network
> Operator option I see in this case is Network Type and Call Setting is
> Voicemail and FDN.
This is the current implementation whereas I'm not sure the correct behavior. If the connected voice type is unknown, the best choice seems to hide both CDMA and GSM options. Or I should ignore the change to no service, so that it keeps the last option?
 
> 4. GSM settings disappeared when radio tech reported is hspa. I left a note
> in github pointing to the issue.
Ok, I'll fix this.

> 5. Once I saw that the Gaia wasn't making a request to get individual call
> settings from RIL. Due to the issue #4 I am finding it hard to reproduce the
> bug. I will fix that locally and reproduce this tomorrow.

Comment 50

[Arthur Chen [:arthurcc][inactive after 6/30]]

Patch updated. Will request a review when everything works well.

Comment 51

[Arthur Chen [:arthurcc][inactive after 6/30]]

Anshul, could you help test the patch again? Thanks!

Comment 52

[Anshul]

I tested the latest patch and it seems to be working fine. Thanks for providing the fix.

Comment 53

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8394012 [details]
WIP

Thanks anshul!

Jose, mind take a look at it again? Thanks!

Comment 54

[José Antonio Olivera Ortega [:jaoo]]

Comment on attachment 8394012 [details]
WIP

Arthur, thanks for the patch. I left a comment on the PR, please take a look. I've tested the patch on peak and everything seems to work correctly. I don't have a global phone to test the patch properly but Anshul does and told us everything works correctly (see comment #c52) so that's great (thanks Anshul). 

r=me

Comment 55

[Arthur Chen [:arthurcc][inactive after 6/30]]

Attachment: PR on v1.4

Comment 56

[Arthur Chen [:arthurcc][inactive after 6/30]]

Jose, the line has been removed as you suggested, thanks!

master: 8697ff1031861b680140b96badfe37833fd21043

Comment 57

[Arthur Chen [:arthurcc][inactive after 6/30]]

Travis passed (https://github.com/mozilla-b2g/gaia/pull/18141)

v1.4: 4405ba39da4ffdabc9a7eb1c95a2a33b96b7e8c3

Comment 58

[[:RJ]]

test case needs to be written for this

Comment 59

[KTucker [:KTucker][Inactive 3/4/2016]]

Test case added to moztrap:

https://moztrap.mozilla.org/manage/case/14336/