949980 - [Gaia][DSDS] Fine tune signal strength bar and call forwarding visuals

Status: RESOLVED DUPLICATE of bug 1056969

(Firefox OS Graveyard :: Gaia, defect)

Description

[Arthur Chen [:arthurcc][inactive after 6/30]]

Attachment: DSDS Status Bar visuals

The visual style should follow the spec.

Comment 1

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

(In reply to Arthur Chen [:arthurcc] from comment #0)
> Created attachment 8347150 [details]
> DSDS Status Bar visuals
> 
> The visual style should follow the spec.

Arthur, is there any icon for this ? Can't find them in the zip.

Comment 2

[Arthur Chen [:arthurcc][inactive after 6/30]]

There is no new icon added. It is just layout and color issue.

Comment 3

[Al Tsai [:atsai]]

Please refer to bug 949978 for visual design. Thanks.

Comment 4

[Al Tsai [:atsai]]

I don't think we need it to block the user story. The feature is done and just need a little modification. Still nominate it as v1.4+ because it worth. :p

Comment 5

[Al Tsai [:atsai]]

Oops. my bad, I thought bug 949978 was the original user story. put the blocker back.

Comment 6

[Preeti Raghunath(:Preeti)]

Moving to backlog for later release

Comment 7

[Fang Shih [:fang]]

Attachment: DSDS status bar visual spec .pdf

Hi Arthur, I've updated all the scenario for DSDS status bar in this visual spec, Thanks!

Comment 8

[Michael Henretty [:mikehenrty][:mhenretty]]

Stealing this bug, since I have a WIP from bug 975973.

Comment 9

[Michael Henretty [:mikehenrty][:mhenretty]]

Attachment: Github PR

Arthur, I hope you don't mind that I stole this from you. Would you take a look here?

Comment 10

[Arthur Chen [:arthurcc][inactive after 6/30]]

Thank you for taking care of this as currently I don't have time working on it. :)

Comment 11

[Arthur Chen [:arthurcc][inactive after 6/30]]

Attachment: gap1.png

Comment 12

[Arthur Chen [:arthurcc][inactive after 6/30]]

Attachment: gap2.png

Comment 13

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8397395 [details] [review]
Github PR

There are gaps as the attachments shown after enabling data connection and setting the primary sim of data call to the second one.

Comment 14

[Michael Henretty [:mikehenrty][:mhenretty]]

Thanks for the quick review.

So there are two gaps I see in your attachment. One is a gap between the call forwarding icon and the data signal icons. I have fixed that in the PR. I added it as a separate commit, so you can see the interdiff, but I will of course squash before anything is merged.

The second gap is the one where the connection type ('E', or '3G' for example) should be. It seems that even if no connection type is displayed, it still takes up space on the statusbar. The problem is, I cannot reproduce this locally. I've tried setting default SIM to 2, enabling disabling all data connections, enabling disabling wifi, and even hacking statusbar.js to explicitly set connection type. Can you provide me with some more steps to reproduce what you are seeing?

Comment 15

[Michael Henretty [:mikehenrty][:mhenretty]]

Attachment: feedback.png

Hi Fang, how is this looking? Any tweaks?

Comment 16

[Michael Henretty [:mikehenrty][:mhenretty]]

Sorry, meant to ni? Aurthur on comment 14.

Comment 17

[Fang Shih [:fang]]

Comment on attachment 8398246 [details]
feedback.png

Hi Michael, Thanks for the updates, they look great! This is very close!! 
I'm just wondering is the font weight of the SIM number are medium? They seem a little thin on my device. Or maybe is a screen capture problem? 

The other one is if that’s possible can we move the call forwarding icon 3px closer to the right? Cause they (SIM number 1, call forwarding icon and number 2) seem a little apart from each other. Thanks!!!

Comment 18

[Arthur Chen [:arthurcc][inactive after 6/30]]

I may place the images in a wrong order.

My steps were:
1. Set the primary sim to sim 1.
2. Enable data connection and wait for the data call established.
3. Switch the primary sim to sim 2. --> (gap2.png)
4. Wait for the data call established.
5. Disable data connection. --> (gap1.png)

Comment 19

[Michael Henretty [:mikehenrty][:mhenretty]]

All the work for signal strength was done in bug 1056969.