950644 - Multiple Contact Selection Screen for SMS, Email application

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[ashayb2g]

This issue is to check the scenarios for picking multiple contact for sms and Email application.

1. Single Contact Selection from SMS composer
Current Scenario: From SMS composer , selection of contacts will list all the contacts that are present. We display popup for empty contact while adding it to SMS.

Proposed Scenario: When we select contact icon from SMS composer, Contact application should list only those contact which has phone number.

2. Multi Contact selection from SMS and EMail composers. 

a. Proposing "multiPick" as parameter for the 'pick' activity in order to identify single selection or multiple selection.

b. Based on the application which called pick activity, we will create a list of contacts either with telephone numbers only or with email. So no validation is required at later part after selecting the contacts.

c. Pick activity result will be the array list of name and number in case of SMS and name and email in case of email app.


Please suggest any changes.

Comment 1

[ashayb2g]

Attachment: CAM00090.mp4

Video Showing App based single/Multiple contact selection

Comment 2

[Wayne Chang [:wchang]]

Can you let me know whats needed? UX review?

Comment 3

[ashayb2g]

Yes, because there is a change in UX and also proposing "multiPick" as parameter for the 'pick' activity

Comment 4

[Wayne Chang [:wchang]]

Our UX team will follow up here.

Comment 5

[Harly Hsu[:harly]]

We are aware of the same issue and we agree that multiple selection and contact filtering in Message/Email are a must do. We actually are working on a consistent UI behavior for Edit Mode/Select Mode/Picker at this moment. And formal spec will be released after Frameworks team evaluates it. Thank you for the suggestion.
 
p.s.Can you please tell us which build are you using since current build only has single select for contact picker in Email.

Comment 6

[ashayb2g]

We are referring to Mozilla Gaia Master and done implementation considering the above points.

We want to confirm the UX before uploading the patch.

Comment 7

[ashayb2g]

@Mr Chang, can you please help me assigning this task to me as I am unable to assign it to myself.

Thanks
Ashay

Comment 8

[Wayne Chang [:wchang]]

Thank you. Please liaise with Harly on the UX aspects.

Comment 9

[GoodMike]

UX team is working on a pattern for multi-selction in Contact Picker. Please liaise with Harly for estimate schedule. I suggest you wait for the new patter spec before releasing patch, so we can make it right at a time. Thank you.

(For your proposal based on current patter/building block, there is only one thing need to be improved. When one or more items are selected, the "Select" text in the header should change to "# Selected" ex. 3 selected. The multi-select behavior can also be seen at Contact-> Export Contact, it's just the header status needs to be improved as well. There will be big file for that. )

Comment 10

[ashayb2g]

@GoodMike, I can implement the improvement part as well and its not a big change. 

The same screen is shared at different places in the application like Export Contacts, Multiple contact delete, Contact Pick screen from Email or any other application. So, Please update about making changes in the above screens also. 

Thanks
Ashay

Comment 11

[GoodMike]

Typo in Comment 9, end of line 8 -> bug not big. Sure, we will inform other teams to do that.

Comment 12

[Francisco Jordano [:arcturus] [:francisco]]

Hi,

would like to jump into the conversation to clarify some points:

- First we will need a global review for contact selection.
- We must be sure we don't break any other app using contacts web activity, so perhaps an extra parameter in the activity call would be necessary.
- Current contacts app provides a 'selection mode' that shows the checks, as in the video, but since no code provided cannot check if it's using it or not.
- Once that first point is clear, will be happy to r?

Cheers,
F.

Comment 13

[ashayb2g]

@Francisco, as shown in the video SMS application is using the normal contacts web activity without any parameter so while calling activity contacts application doesn't not offer to pick multiple contacts. while in case of Email application we are passing "multipick" as a parameter with some non zero value, because of that contact application is offering Multiple Pick option.

we'll upload the code once we'll get input from UX team as we need to modify the code based on UX changes.

Comment 14

[Francisco Jordano [:arcturus] [:francisco]]

(In reply to ashayb2g from comment #13)
> @Francisco, as shown in the video SMS application is using the normal
> contacts web activity without any parameter so while calling activity
> contacts application doesn't not offer to pick multiple contacts. while in
> case of Email application we are passing "multipick" as a parameter with
> some non zero value, because of that contact application is offering
> Multiple Pick option.
> 
> we'll upload the code once we'll get input from UX team as we need to modify
> the code based on UX changes.

Perfect, let's wait from UX input and take a look to that code.

Thanks a lot!

Comment 15

[Wayne Chang [:wchang]]

Just spoke to Goodmike and current UX comment is already provided in comment 9 to include the addition of "# Selected" to the header so that it is consistent with other multiple selection scenarios.

(In reply to GoodMike from comment #9)

> (For your proposal based on current patter/building block, there is only one
> thing need to be improved. When one or more items are selected, the "Select"
> text in the header should change to "# Selected" ex. 3 selected. The
> multi-select behavior can also be seen at Contact-> Export Contact, it's
> just the header status needs to be improved as well. There will be big file
> for that. )

Comment 16

[ashayb2g]

This thing I have already included in my code. But we need some other inputs as in sms application while picking contacts it should show only those contacts who are having phone no. in it, or in Email application while picking up contacts it should show only those contacts who have email address present in it. 
   Currently the scenario is like while picking any contact it display all the contacts present in the contact list doesn't matter whether it is empty or not having the required details. Popup is shown once you click an contact. So we are skipping this popup part.
   Also we are proposing for a "multipick" parameter that also needs approval.



Thanks
Ashay

Comment 17

[ashayb2g]

@GoodMike, can you please update on UX input from your end.

Comment 18

[GoodMike]

@[e-mail], can you please ask Ayman ([e-mail]) for his input on your question related to SMS in comment 16. He is in charge of sms UX design, thank you.

Comment 19

[ashayb2g]

@Ayman, Can you please provide your input related to SMS UX changes related to multiple contact selection.

Thank you.
Ashay

Comment 20

[ayman maat :maat]

(In reply to ashayb2g from comment #16)
> This thing I have already included in my code. But we need some other inputs
> as in sms application while picking contacts it should show only those
> contacts who are having phone no. in it, or in Email application while
> picking up contacts it should show only those contacts who have email
> address present in it. 
>    Currently the scenario is like while picking any contact it display all
> the contacts present in the contact list doesn't matter whether it is empty
> or not having the required details. Popup is shown once you click an
> contact. So we are skipping this popup part.
>    Also we are proposing for a "multipick" parameter that also needs
> approval.
> 
> 
> 
> Thanks
> Ashay

Hi Ashley 

i am actually overseeing ux for both contacts and messages. 

Within the message app when the contact list is shown at the moment we should only be showing contacts that have phone numbers (send to SMS or MMS) and/or email addresses (send to MMS only) associated to them. However i believe at the time there were performance issues with doing this which is which is why all contacts are displayed and then, when a contact does not have a phone number or email, the overlay stating there is no number associated to the contact is displayed. If we can get over that performance issue, great! …lets limit the list to displaying only phone numbers and email addresses.

However there is one problem that your solution does not address. This is the scenario when a contact has more than one phone number associated to it or more than one email address associated to it or both a phone number and email address associated to it. In this instance it is not sufficient to show just a single contact and in a multiple selection list (in this instance what phone number or email address are we using?). What we will need to do is show an individual entry within the list for each phone number and email address instance associated to a contact. Again this might have performance issues and might also be quite high risk.

Here is what i am looking for from this patch before i can ok this form a UX perspective:

1) the header must reflect the number of contact instances selected from the list.
2) contacts that have more than one phone number or email associated to them or have both phone numbers and email addresses associated to them will have more than one entry in the list: one for each phone number and/or email address associated to them
3) we must be able to display phone numbers and or email addresses that have been linked from social network sites such as facebook and are present within the contact list

ni? me if you require UX input, i am happy to support you from a design PoV.

ni? to Ashley to flag my late response
ni? to Francisco and julien as they have detailed knowledge of the contact list display from within the messages app and can advise on performance issues and risk

Comment 21

[ashayb2g]

Attachment: Multiple Entry in single contact

Hi Ayman,

1. Regarding showing number of contact instance selected, we have already considered it. it'll show "n Selected".

2. For contacts that have more than one phone number or email associated to them, are you expecting some thing like the image I have attached here? Please see the attachment. This is the android's contact list behavior.

3. Contacts from social network site also will shown.

Regards
Ashay

Comment 22

[Julien Wajsberg [:julienw]]

I actually don't know much about the Contacts app, so removing my NI.

I have only once concern: I don't think we can add arbitrary new properties to an existing activity, especially when it's a core activity like "pick". I think we should bring this issue to the webapi mailing list, so please do before even shipping some code about this. Having one device support "multiPick" and another support (eg) "pickSeveral" would be a nightmare.

Comment 23

[ayman maat :maat]

(In reply to ashayb2g from comment #21)
> Created attachment 8369864 [details]
> Multiple Entry in single contact
> 
> Hi Ayman,
> 
> 1. Regarding showing number of contact instance selected, we have already
> considered it. it'll show "n Selected".

Cool

> 
> 2. For contacts that have more than one phone number or email associated to
> them, are you expecting some thing like the image I have attached here?
> Please see the attachment. This is the android's contact list behavior.

Yes similar to that. For now I would advise to align the presentation of information within this list to the presentation of the auto suggest list when the is typing into the ‘to field’ .  So whereas your screenshot shows one module containing multiple numbers we would have one number (or email address) per module. Let me know if you need a Wireframe or some Visual Design work

> 
> 3. Contacts from social network site also will shown.

Cool

> 
> Regards
> Ashay

Comment 24

[ashayb2g]

Attachment: ScreenShots.zip

@ayman, Please find attached zip containing two screen shots, one from Email contact add screen and another from Multiple Select screen for contact pick.

Are you expecting this kind of UI? or suggest any further changes.

Comment 25

[ashayb2g]

Regarding performance of contacts loading, We have checked with 500 contacts.
while picking contact from app like sms/email, there is a difference of 2 seconds when loading filtered contact then all contacts.

Comment 26

[ayman maat :maat]

(In reply to ashayb2g from comment #24)
> Created attachment 8373192 [details]
> ScreenShots.zip
> 
> @ayman, Please find attached zip containing two screen shots, one from Email
> contact add screen and another from Multiple Select screen for contact pick.
> 
> Are you expecting this kind of UI? or suggest any further changes.

Yes I would advise that data structure illustrated in the attachments for now as it aligns to data structures that are already on the device. Obviously I only see Emails illustrated here so when you specifically output a phone number I would look for the following data structure:

--------------------
Luzie Zull
mobile | 1234
--------------------
Luzie Zull
mobile | 5678  
--------------------

Could i please test the actual patch before we attempt to land it.
Thanks

ni? to [e-mail]

Comment 27

[ashayb2g]

Attachment: WIP_MultipleContactPick.patch

Hi Ayman,

PFA WIP patch to test the UI for multiple contact pick from SMS/EMAIL application. I have included all the changes you suggested.
Please provide your feedback ASAP.

Thanks

Comment 28

[ayman maat :maat]

Comment on attachment 8374754 [details] [diff] [review]
WIP_MultipleContactPick.patch

Seems fine to me so far from a UX PoV. Good work. 

Please do not forget to include email addresses in the search results though. 

please ni? me to test when that is also done

Thanks

Comment 29

[ashayb2g]

Attachment: WIP_MultipleContactSelect.patch

Hi Ayman,

PFA WIP patch including your changes suggested related to email search.
Please let me know your feedback ASAP.

Thanks

Comment 30

[ayman maat :maat]

(In reply to ashayb2g from comment #29)
> Created attachment 8375424 [details] [diff] [review]
> WIP_MultipleContactSelect.patch
> 
> Hi Ayman,
> 
> PFA WIP patch including your changes suggested related to email search.
> Please let me know your feedback ASAP.
> 
> Thanks

Hey there. 

I have tested this patch, but unfortunately email addresses do not seem to be presented in the contact list generated from the Messages App. Path i follow is as follows:

**PRECONDITION**
a) have single contact in contact list that has only an email address associated to it

**PATH**
1) open messages app
2) select new message composer
3) select contact list (+ in right hand side of 'to field')

**EXPECTED**
contact list opens containing contact in precondition 'a'
  
**ACTUAL**
full screen message stating 'Cannot add to contact as your contact list is empty'

ni? me know when your ready and i will test again
ni? to [e-mail] regarding content of this comment

Comment 31

[Julien Wajsberg [:julienw]]

Should we really be able to select the contacts that only have an email, since we don't support sending MMS to email yet?

Comment 32

[ashayb2g]

Hi Ayman,
 
We can do that as well, but as Julien said, we don't support sending MMS to Email that's the reason its not shown from SMS app.

Current Implementation says from SMS app user can add contacts with numbers only, from Email user can add contacts with Email only. 
My last updated patch was for Email search support in search field.
Let me know in case any thing else.

Comment 33

[ashayb2g]

Attachment: Pointer to Pull Request.html

Hi Francisco,

Please review the patch and let me know in case any changes.

Regards
Ashay

Comment 34

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8376154 [details]
Pointer to Pull Request.html

This patch is way to big and adds a lot of complexity.

Would prefer a simplier approach. But also I understand that is not easy having a multiple list, since we display contacts that may have not a single number, or contacts that do have several numbers.

Definitely, way to big and risky to add.

Could you reach me in IRC and we can discuss about the possible solution?

Comment 35

[ashayb2g]

Hi Francisco,

Please let me know your convenient time tomorrow when you'll be available on IRC, in the mean time i'll also analyze the code how to optimize it further.

Comment 36

[ashayb2g]

Hi Francisco,

As discussed over IRC please review the patch and let me know your inputs.

Comment 37

[Wayne Chang [:wchang]]

pinging francisco to get some traction here.

Comment 38

[Francisco Jordano [:arcturus] [:francisco]]

Hei,

can we rebase the patch, since we branched now it's the time to land this wanted features :)

Comment 39

[ashayb2g]

Hi Francisco,

Can you please review this first ?
As some part of this code is also present in Implementation of Multiple Contact Delete. So once that is merged in Master any way we have to do rebase again. So in one shot only we'll have both the changes.

Thanks

Comment 40

[Francisco Jordano [:arcturus] [:francisco]]

Hei Ashay,

Now it's the turn of this feature to land.

Could you rebase your patch?

Comment 41

[Noemí Freire (:noemi)]

Hi Ashay,

Could you please ask for ui-review? to visual design team (Victoria Gerchinhoren: [e-mail]) once the patch is rebased?. Thanks!

Comment 42

[ashayb2g]

Attachment: Pointer to Pull Request.html

PFA PR for Multiple contact Pick for SMS n Email.

Please review and let me know in case any changes.

Ashay

Comment 43

[ashayb2g]

Attachment: email_updated.patch

PFA patch for testing Email to support multiple contact Pick.

Regards
Ashay

Comment 44

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8400503 [details]
Pointer to Pull Request.html

Hi,

great job, we still need to fix the errors in travis  for the linter and unit tests:

https://travis-ci.org/mozilla-b2g/gaia/jobs/22088088
https://travis-ci.org/mozilla-b2g/gaia/jobs/22088089

Thanks!

Comment 45

[Victoria Gerchinhoren [:vicky]]

Comment on attachment 8400505 [details] [diff] [review]
email_updated.patch

Review of attachment 8400505 [details] [diff] [review]:
-----------------------------------------------------------------

Can you please paste a screenshot of what you need feedback from? Thanks!
V

Comment 46

[ashayb2g]

Attachment: MultipleContactPick.png

Hi Victoria,

PFA screen shot of Multiple contact pick screen. Please check it and let me know your feedback.

Comment 47

[Victoria Gerchinhoren [:vicky]]

Thanks Ashay. This would be ok before, but with the visual refresh there's a different approach to edit modes that is lighter and should be consistent in all same instances. So the header should be light gray and the footer light as well.

But I guess as this screen belongs to Contacts app, it should be solved by this bug: https://bugzilla.mozilla.org/show_bug.cgi?id=990478

Thanks.

Comment 48

[Wayne Chang [:wchang]]

Vicky,
Can we resolve this bug as intended for v1.4 visual styles and use a follow up bug to address the visual refresh?

Partner's target device here at the moment is based on 1.4. You may also see a few other bugs with similar concerns, I hope we can address them this way?

Thanks

Comment 49

[Victoria Gerchinhoren [:vicky]]

This is not a visual refresh thing, it is a wrong use of patterns. But if time is not on our side, you can close it, just make sure we have the follow up present.

thanks

Comment 50

[Noemí Freire (:noemi)]

(In reply to Victoria Gerchinhoren [:vicky] from comment #49)
> This is not a visual refresh thing, it is a wrong use of patterns. But if
> time is not on our side, you can close it, just make sure we have the follow
> up present.
> 
> thanks

As previously mentioned, the wrong use of patterns will be fixed within Bug 990478

Comment 51

[ashayb2g]

Attachment: Pointer to Pull Request.html

Hi Francisco,

Please review the PR, this time with travis green.

Comment 52

[Wayne Chang [:wchang]]

ping

Comment 53

[Noemí Freire (:noemi)]

Since Francisco is on PTO, José Manuel will take a look and review it

Comment 54

[Jose Manuel Cantera]

the PR needs a rebase

Comment 55

[ashayb2g]

Attachment: Pointer to Pull Request.html

Hi Jose,

PFA new PR for review.

Thanks
Ashay

Comment 56

[Jose Manuel Cantera]

Comment on attachment 8419889 [details]
Pointer to Pull Request.html

handing over review to Francisco as he is back

Comment 57

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8419889 [details]
Pointer to Pull Request.html

Hi folks,

just came back from my break, I saw that we didn't advance in the review of this bug :(

A pity, will take care of it, first I will another rebase. (so sorry)

Comment 58

[Victoria Gerchinhoren [:vicky]]

Comment on attachment 8400505 [details] [diff] [review]
email_updated.patch

Review of attachment 8400505 [details] [diff] [review]:
-----------------------------------------------------------------

removing flag

Comment 59

[BMO Automation]

Firefox OS is not being worked on