Closed
Bug 950973
Opened 11 years ago
Closed 7 years ago
[js-marionette-client] Scope states are not isolated
Categories
(Testing Graveyard :: JSMarionette, defect)
Tracking
(Not tracked)
RESOLVED
INCOMPLETE
People
(Reporter: jugglinmike, Assigned: jugglinmike)
References
Details
Attachments
(1 file)
When new "scopes" are created via `Client#scope`, their `_scope` property is copied from the "parent" client, but their `_state` property is kept as a reference. Scoped clients should define an isolated `_state`, copied from the parent at creation time.
|
Assignee | |
Comment 1•11 years ago
|
||
Hey Gareth! I came across this bug while implementing your suggestion for my patch for bug 950749.
Attachment #8348423 -
Flags: review?(gaye)
|
|
Assignee | |
Comment 2•11 years ago
|
||
Gareth,
These intermittent failures are due to an unguarded references to the mobile-only `mozBluetooth` API. After some digging, I've found that the tests will also intermittently fail on a different error originating from the System application. I've opened bug 951886 and bug 951888 to track the resolution of those problems.
|
||
Comment 3•11 years ago
|
||
Comment on attachment 8348423 [details] [review]
Pull request on GitHub.com
Thanks Mike! Sorry again for the review delay.
Attachment #8348423 -
Flags: review?(gaye) → review+
|
|
||
Comment 4•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
|
||
Comment 5•11 years ago
|
||
https://github.com/mozilla-b2g/marionette-js-client/commit/80561bcedc092ce9f76cfd7d3027433770b29175 this broke things (see https://bugzilla.mozilla.org/show_bug.cgi?id=985112)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
||
Comment 6•7 years ago
|
||
Bulk closed as part of https://bugzilla.mozilla.org/show_bug.cgi?id=1422750
Status: REOPENED → RESOLVED
Closed: 11 years ago → 7 years ago
Resolution: --- → INCOMPLETE
|
||
Updated•7 years ago
|
Product: Testing → Testing Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•