[js-marionette-client] Scope states are not isolated

REOPENED
Assigned to

Status

Testing
JSMarionette
REOPENED
4 years ago
4 years ago

People

(Reporter: jugglinmike, Assigned: jugglinmike)

Tracking

(Depends on: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
When new "scopes" are created via `Client#scope`, their `_scope` property is copied from the "parent" client, but their `_state` property is kept as a reference. Scoped clients should define an isolated `_state`, copied from the parent at creation time.
(Assignee)

Comment 1

4 years ago
Created attachment 8348423 [details] [review]
Pull request on GitHub.com

Hey Gareth! I came across this bug while implementing your suggestion for my patch for bug 950749.
Attachment #8348423 - Flags: review?(gaye)
(Assignee)

Updated

4 years ago
Blocks: 950749
(Assignee)

Updated

4 years ago
Depends on: 951886
(Assignee)

Updated

4 years ago
Depends on: 951888
(Assignee)

Comment 2

4 years ago
Gareth,

These intermittent failures are due to an unguarded references to the mobile-only `mozBluetooth` API. After some digging, I've found that the tests will also intermittently fail on a different error originating from the System application. I've opened bug 951886 and bug 951888 to track the resolution of those problems.
Comment on attachment 8348423 [details] [review]
Pull request on GitHub.com

Thanks Mike! Sorry again for the review delay.
Attachment #8348423 - Flags: review?(gaye) → review+
https://github.com/mozilla-b2g/marionette-js-client/commit/e2e594aa7ef5a95e1c5ff1f762ad253650d276eb
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
https://github.com/mozilla-b2g/marionette-js-client/commit/80561bcedc092ce9f76cfd7d3027433770b29175 this broke things (see https://bugzilla.mozilla.org/show_bug.cgi?id=985112)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
You need to log in before you can comment on or make changes to this bug.