985112 - marionette-client@1.1.1 is borked

Status: RESOLVED FIXED

(Testing Graveyard :: JSMarionette, defect)

Description

[Gareth Aye [:gaye] (back from PTO)]

I tried to bump the gaia dependency on marionette-client to 1.1.1 from >=1.0.0 and a bunch of marionette js builds failed in gaia with the below error... yikes!

 JavaScriptError: (17) No such strategy.

Remote Stack:

<none>

at Error.MarionetteError (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/error.js:67:13)

at Object.Client._handleCallback (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/client.js:474:19)

at /home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/client.js:508:21

at TcpSync.send (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/drivers/tcp-sync.js:94:10)

at Object.send (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/client.js:455:36)

at Object.Client._sendCommand (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/client.js:501:19)

at Object._findElement (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/client.js:1290:19)

at Object.findElement (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/client.js:1339:32)

at waitForAppSync (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-apps/lib/waitforapp.js:40:19)

at waitForApp (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-apps/lib/waitforapp.js:23:5)

at launch (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-apps/lib/launch.js:37:3)

at Object.Gallery.launch (/home/travis/build/mozilla-b2g/gaia/apps/gallery/test/marionette/lib/gallery.js:265:22)

at Context.<anonymous> (/home/travis/build/mozilla-b2g/gaia/apps/gallery/test/marionette/fullscreen_image_test.js:28:9)

at Hook.Runnable.run (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runnable.js:211:32)

at next (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runner.js:257:10)

at /home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runner.js:269:7

at done (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runnable.js:185:5)

at /home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runnable.js:197:9

at Object.executeHook (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/client.js:370:18)

at process._tickCallback (node.js:415:13)

Comment 2

[Evan Tseng [:evanxd]]

Attachment: Pull request

Comment 3

[Gareth Aye [:gaye] (back from PTO)]

This is blocking :kgrandon from resolving https://bugzilla.mozilla.org/show_bug.cgi?id=962918, so I might grab this real quick...

Comment 4

[Gareth Aye [:gaye] (back from PTO)]

I backed out :jugginmike's patch for 950973 which fixes this.

Comment 5

[Gareth Aye [:gaye] (back from PTO)]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia-node-modules/pull/12

Comment 6

[Gareth Aye [:gaye] (back from PTO)]

https://github.com/mozilla-b2g/gaia-node-modules/commit/9f47ac42b707f437df9219667f5b4c15c9eaa60f

Comment 7

[Gareth Aye [:gaye] (back from PTO)]

https://github.com/mozilla-b2g/gaia/commit/d19a7fb3efa74c479be7f0b24f030e9895eb4b7a also

Comment 8

[(Inactive after June) George Duan [:gduan] [:喬智]]

Hi Gareth,
why did we revert this patch in comment 7? Will it reland?
9ab5a8efbe530cb959b66c29800bcf316cac646b

Comment 9

[(Inactive after June) George Duan [:gduan] [:喬智]]

It seems someone has added it back.

Comment 10

[Derek Harris [:DerekH] - Dont need info. Last day 6/5/15]

Unable to verify, this seems to be a back end issue. Adding [QAnalyst-verify-] to the whiteboard section due to their not being a QA whiteboard tag section.